* [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource @ 2019-12-22 19:08 ` Yangtao Li 0 siblings, 0 replies; 14+ messages in thread From: Yangtao Li @ 2019-12-22 19:08 UTC (permalink / raw) To: mst, jasowang; +Cc: Yangtao Li, linux-kernel, virtualization Use devm_platform_ioremap_resource() to simplify code, which contains platform_get_resource, devm_request_mem_region and devm_ioremap. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/virtio/virtio_mmio.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index e09edb5c5e06..97d5725fd9a2 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; - struct resource *mem; unsigned long magic; int rc; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -EINVAL; - - if (!devm_request_mem_region(&pdev->dev, mem->start, - resource_size(mem), pdev->name)) - return -EBUSY; - vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); if (!vm_dev) return -ENOMEM; @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) INIT_LIST_HEAD(&vm_dev->virtqueues); spin_lock_init(&vm_dev->lock); - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); - if (vm_dev->base == NULL) - return -EFAULT; + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(vm_dev->base)) + return PTR_ERR(vm_dev->base); /* Check magic value */ magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); -- 2.17.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource @ 2019-12-22 19:08 ` Yangtao Li 0 siblings, 0 replies; 14+ messages in thread From: Yangtao Li @ 2019-12-22 19:08 UTC (permalink / raw) To: mst, jasowang; +Cc: virtualization, linux-kernel, Yangtao Li Use devm_platform_ioremap_resource() to simplify code, which contains platform_get_resource, devm_request_mem_region and devm_ioremap. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/virtio/virtio_mmio.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index e09edb5c5e06..97d5725fd9a2 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; - struct resource *mem; unsigned long magic; int rc; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -EINVAL; - - if (!devm_request_mem_region(&pdev->dev, mem->start, - resource_size(mem), pdev->name)) - return -EBUSY; - vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); if (!vm_dev) return -ENOMEM; @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) INIT_LIST_HEAD(&vm_dev->virtqueues); spin_lock_init(&vm_dev->lock); - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); - if (vm_dev->base == NULL) - return -EFAULT; + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(vm_dev->base)) + return PTR_ERR(vm_dev->base); /* Check magic value */ magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); -- 2.17.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource 2019-12-22 19:08 ` Yangtao Li (?) @ 2019-12-23 8:43 ` Jason Wang -1 siblings, 0 replies; 14+ messages in thread From: Jason Wang @ 2019-12-23 8:43 UTC (permalink / raw) To: Yangtao Li, mst; +Cc: virtualization, linux-kernel On 2019/12/23 上午3:08, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code, which > contains platform_get_resource, devm_request_mem_region and > devm_ioremap. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/virtio/virtio_mmio.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > index e09edb5c5e06..97d5725fd9a2 100644 > --- a/drivers/virtio/virtio_mmio.c > +++ b/drivers/virtio/virtio_mmio.c > @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) > static int virtio_mmio_probe(struct platform_device *pdev) > { > struct virtio_mmio_device *vm_dev; > - struct resource *mem; > unsigned long magic; > int rc; > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!mem) > - return -EINVAL; > - > - if (!devm_request_mem_region(&pdev->dev, mem->start, > - resource_size(mem), pdev->name)) > - return -EBUSY; > - > vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); > if (!vm_dev) > return -ENOMEM; > @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) > INIT_LIST_HEAD(&vm_dev->virtqueues); > spin_lock_init(&vm_dev->lock); > > - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); > - if (vm_dev->base == NULL) > - return -EFAULT; > + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(vm_dev->base)) > + return PTR_ERR(vm_dev->base); > > /* Check magic value */ > magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); Acked-by: Jason Wang <jasowang@redhat.com> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource 2019-12-22 19:08 ` Yangtao Li (?) (?) @ 2019-12-23 8:43 ` Jason Wang -1 siblings, 0 replies; 14+ messages in thread From: Jason Wang @ 2019-12-23 8:43 UTC (permalink / raw) To: Yangtao Li, mst; +Cc: linux-kernel, virtualization On 2019/12/23 上午3:08, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code, which > contains platform_get_resource, devm_request_mem_region and > devm_ioremap. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/virtio/virtio_mmio.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > index e09edb5c5e06..97d5725fd9a2 100644 > --- a/drivers/virtio/virtio_mmio.c > +++ b/drivers/virtio/virtio_mmio.c > @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) > static int virtio_mmio_probe(struct platform_device *pdev) > { > struct virtio_mmio_device *vm_dev; > - struct resource *mem; > unsigned long magic; > int rc; > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!mem) > - return -EINVAL; > - > - if (!devm_request_mem_region(&pdev->dev, mem->start, > - resource_size(mem), pdev->name)) > - return -EBUSY; > - > vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); > if (!vm_dev) > return -ENOMEM; > @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) > INIT_LIST_HEAD(&vm_dev->virtqueues); > spin_lock_init(&vm_dev->lock); > > - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); > - if (vm_dev->base == NULL) > - return -EFAULT; > + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(vm_dev->base)) > + return PTR_ERR(vm_dev->base); > > /* Check magic value */ > magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); Acked-by: Jason Wang <jasowang@redhat.com> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/6] iommu/omap: convert to devm_platform_ioremap_resource @ 2019-12-23 18:59 Yangtao Li 2019-12-23 18:59 ` Yangtao Li 2019-12-23 18:59 ` Yangtao Li 0 siblings, 2 replies; 14+ messages in thread From: Yangtao Li @ 2019-12-23 18:59 UTC (permalink / raw) To: m.szyprowski, joro, kgene, krzk, matthias.bgg, agross, bjorn.andersson, robdclark, heiko, mst, jasowang, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-mediatek, linux-arm-msm, linux-rockchip, virtualization Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/iommu/omap-iommu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index be551cc34be4..297c1be7ecb0 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -1175,7 +1175,6 @@ static int omap_iommu_probe(struct platform_device *pdev) int err = -ENODEV; int irq; struct omap_iommu *obj; - struct resource *res; struct device_node *of = pdev->dev.of_node; struct orphan_dev *orphan_dev, *tmp; @@ -1218,8 +1217,7 @@ static int omap_iommu_probe(struct platform_device *pdev) spin_lock_init(&obj->iommu_lock); spin_lock_init(&obj->page_table_lock); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - obj->regbase = devm_ioremap_resource(obj->dev, res); + obj->regbase = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(obj->regbase)) return PTR_ERR(obj->regbase); -- 2.17.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource 2019-12-23 18:59 [PATCH 1/6] iommu/omap: " Yangtao Li 2019-12-23 18:59 ` Yangtao Li 2019-12-23 18:59 ` Yangtao Li @ 2019-12-23 18:59 ` Yangtao Li 1 sibling, 0 replies; 14+ messages in thread From: Yangtao Li @ 2019-12-23 18:59 UTC (permalink / raw) To: m.szyprowski, joro, kgene, krzk, matthias.bgg, agross, bjorn.andersson, robdclark, heiko, mst, jasowang, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-mediatek, linux-arm-msm, linux-rockchip, virtualization Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code, which contains platform_get_resource, devm_request_mem_region and devm_ioremap. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/virtio/virtio_mmio.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index e09edb5c5e06..97d5725fd9a2 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; - struct resource *mem; unsigned long magic; int rc; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -EINVAL; - - if (!devm_request_mem_region(&pdev->dev, mem->start, - resource_size(mem), pdev->name)) - return -EBUSY; - vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); if (!vm_dev) return -ENOMEM; @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) INIT_LIST_HEAD(&vm_dev->virtqueues); spin_lock_init(&vm_dev->lock); - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); - if (vm_dev->base == NULL) - return -EFAULT; + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(vm_dev->base)) + return PTR_ERR(vm_dev->base); /* Check magic value */ magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); -- 2.17.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource @ 2019-12-23 18:59 ` Yangtao Li 0 siblings, 0 replies; 14+ messages in thread From: Yangtao Li @ 2019-12-23 18:59 UTC (permalink / raw) To: m.szyprowski, joro, kgene, krzk, matthias.bgg, agross, bjorn.andersson, robdclark, heiko, mst, jasowang, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-mediatek, linux-arm-msm, linux-rockchip, virtualization Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code, which contains platform_get_resource, devm_request_mem_region and devm_ioremap. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/virtio/virtio_mmio.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index e09edb5c5e06..97d5725fd9a2 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; - struct resource *mem; unsigned long magic; int rc; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -EINVAL; - - if (!devm_request_mem_region(&pdev->dev, mem->start, - resource_size(mem), pdev->name)) - return -EBUSY; - vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); if (!vm_dev) return -ENOMEM; @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) INIT_LIST_HEAD(&vm_dev->virtqueues); spin_lock_init(&vm_dev->lock); - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); - if (vm_dev->base == NULL) - return -EFAULT; + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(vm_dev->base)) + return PTR_ERR(vm_dev->base); /* Check magic value */ magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource @ 2019-12-23 18:59 ` Yangtao Li 0 siblings, 0 replies; 14+ messages in thread From: Yangtao Li @ 2019-12-23 18:59 UTC (permalink / raw) To: m.szyprowski, joro, kgene, krzk, matthias.bgg, agross, bjorn.andersson, robdclark, heiko, mst, jasowang, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-mediatek, linux-arm-msm, linux-rockchip, virtualization Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code, which contains platform_get_resource, devm_request_mem_region and devm_ioremap. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/virtio/virtio_mmio.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index e09edb5c5e06..97d5725fd9a2 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; - struct resource *mem; unsigned long magic; int rc; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -EINVAL; - - if (!devm_request_mem_region(&pdev->dev, mem->start, - resource_size(mem), pdev->name)) - return -EBUSY; - vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); if (!vm_dev) return -ENOMEM; @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) INIT_LIST_HEAD(&vm_dev->virtqueues); spin_lock_init(&vm_dev->lock); - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); - if (vm_dev->base == NULL) - return -EFAULT; + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(vm_dev->base)) + return PTR_ERR(vm_dev->base); /* Check magic value */ magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); -- 2.17.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource @ 2019-12-23 18:59 ` Yangtao Li 0 siblings, 0 replies; 14+ messages in thread From: Yangtao Li @ 2019-12-23 18:59 UTC (permalink / raw) To: m.szyprowski, joro, kgene, krzk, matthias.bgg, agross, bjorn.andersson, robdclark, heiko, mst, jasowang, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-mediatek, linux-arm-msm, linux-rockchip, virtualization Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code, which contains platform_get_resource, devm_request_mem_region and devm_ioremap. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/virtio/virtio_mmio.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index e09edb5c5e06..97d5725fd9a2 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; - struct resource *mem; unsigned long magic; int rc; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -EINVAL; - - if (!devm_request_mem_region(&pdev->dev, mem->start, - resource_size(mem), pdev->name)) - return -EBUSY; - vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); if (!vm_dev) return -ENOMEM; @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) INIT_LIST_HEAD(&vm_dev->virtqueues); spin_lock_init(&vm_dev->lock); - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); - if (vm_dev->base == NULL) - return -EFAULT; + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(vm_dev->base)) + return PTR_ERR(vm_dev->base); /* Check magic value */ magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); -- 2.17.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource 2019-12-23 18:59 ` Yangtao Li (?) (?) @ 2019-12-23 19:00 ` Frank Lee -1 siblings, 0 replies; 14+ messages in thread From: Frank Lee @ 2019-12-23 19:00 UTC (permalink / raw) To: m.szyprowski, joro, Kukjin Kim, Krzysztof Kozlowski, Matthias Brugger, agross, bjorn.andersson, Rob Clark, Heiko Stübner, mst, jasowang, iommu, Linux ARM, linux-samsung-soc, Linux Kernel Mailing List, linux-mediatek, linux-arm-msm, open list:ARM/Rockchip SoC..., virtualization Please ignore this patch. Thx! ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource @ 2019-12-23 19:00 ` Frank Lee 0 siblings, 0 replies; 14+ messages in thread From: Frank Lee @ 2019-12-23 19:00 UTC (permalink / raw) To: m.szyprowski, joro, Kukjin Kim, Krzysztof Kozlowski, Matthias Brugger, agross, bjorn.andersson, Rob Clark, Heiko Stübner, mst, jasowang, iommu, Linux ARM, linux-samsung-soc, Linux Kernel Mailing List, linux-mediatek, linux-arm-msm, open list:ARM/Rockchip SoC..., virtualization Please ignore this patch. Thx! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource @ 2019-12-23 19:00 ` Frank Lee 0 siblings, 0 replies; 14+ messages in thread From: Frank Lee @ 2019-12-23 19:00 UTC (permalink / raw) To: m.szyprowski, joro, Kukjin Kim, Krzysztof Kozlowski, Matthias Brugger, agross, bjorn.andersson, Rob Clark, Heiko Stübner, mst, jasowang, iommu, Linux ARM, linux-samsung-soc, Linux Kernel Mailing List, linux-mediatek, linux-arm-msm, open list:ARM/Rockchip SoC..., virtualization Please ignore this patch. Thx! _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource @ 2019-12-23 19:00 ` Frank Lee 0 siblings, 0 replies; 14+ messages in thread From: Frank Lee @ 2019-12-23 19:00 UTC (permalink / raw) To: m.szyprowski, joro, Kukjin Kim, Krzysztof Kozlowski, Matthias Brugger, agross, bjorn.andersson, Rob Clark, Heiko Stübner, mst, jasowang, iommu, Linux ARM, linux-samsung-soc, Linux Kernel Mailing List, linux-mediatek, linux-arm-msm, open list:ARM/Rockchip SoC..., virtualization Please ignore this patch. Thx! _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource 2019-12-23 18:59 ` Yangtao Li ` (3 preceding siblings ...) (?) @ 2019-12-23 19:00 ` Frank Lee -1 siblings, 0 replies; 14+ messages in thread From: Frank Lee @ 2019-12-23 19:00 UTC (permalink / raw) To: m.szyprowski, joro, Kukjin Kim, Krzysztof Kozlowski, Matthias Brugger, agross, bjorn.andersson, Rob Clark, Heiko Stübner, mst, jasowang, iommu, Linux ARM, linux-samsung-soc, Linux Kernel Mailing List, linux-mediatek, linux-arm-msm, open list:ARM/Rockchip SoC..., virtualization Please ignore this patch. Thx! ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource 2019-12-23 18:59 [PATCH 1/6] iommu/omap: " Yangtao Li 2019-12-23 18:59 ` Yangtao Li @ 2019-12-23 18:59 ` Yangtao Li 1 sibling, 0 replies; 14+ messages in thread From: Yangtao Li @ 2019-12-23 18:59 UTC (permalink / raw) To: m.szyprowski, joro, kgene, krzk, matthias.bgg, agross, bjorn.andersson, robdclark, heiko, mst, jasowang, iommu, linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-mediatek, linux-arm-msm, linux-rockchip, virtualization Cc: Yangtao Li Use devm_platform_ioremap_resource() to simplify code, which contains platform_get_resource, devm_request_mem_region and devm_ioremap. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/virtio/virtio_mmio.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index e09edb5c5e06..97d5725fd9a2 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -531,18 +531,9 @@ static void virtio_mmio_release_dev(struct device *_d) static int virtio_mmio_probe(struct platform_device *pdev) { struct virtio_mmio_device *vm_dev; - struct resource *mem; unsigned long magic; int rc; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -EINVAL; - - if (!devm_request_mem_region(&pdev->dev, mem->start, - resource_size(mem), pdev->name)) - return -EBUSY; - vm_dev = devm_kzalloc(&pdev->dev, sizeof(*vm_dev), GFP_KERNEL); if (!vm_dev) return -ENOMEM; @@ -554,9 +545,9 @@ static int virtio_mmio_probe(struct platform_device *pdev) INIT_LIST_HEAD(&vm_dev->virtqueues); spin_lock_init(&vm_dev->lock); - vm_dev->base = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); - if (vm_dev->base == NULL) - return -EFAULT; + vm_dev->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(vm_dev->base)) + return PTR_ERR(vm_dev->base); /* Check magic value */ magic = readl(vm_dev->base + VIRTIO_MMIO_MAGIC_VALUE); -- 2.17.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-12-23 19:02 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-12-22 19:08 [PATCH] virtio-mmio: convert to devm_platform_ioremap_resource Yangtao Li 2019-12-22 19:08 ` Yangtao Li 2019-12-23 8:43 ` Jason Wang 2019-12-23 8:43 ` Jason Wang -- strict thread matches above, loose matches on Subject: below -- 2019-12-23 18:59 [PATCH 1/6] iommu/omap: " Yangtao Li 2019-12-23 18:59 ` [PATCH] virtio-mmio: " Yangtao Li 2019-12-23 18:59 ` Yangtao Li 2019-12-23 18:59 ` Yangtao Li 2019-12-23 18:59 ` Yangtao Li 2019-12-23 19:00 ` Frank Lee 2019-12-23 19:00 ` Frank Lee 2019-12-23 19:00 ` Frank Lee 2019-12-23 19:00 ` Frank Lee 2019-12-23 19:00 ` Frank Lee 2019-12-23 18:59 ` Yangtao Li
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.