* [PATCH 0/3] Engicam icore fixes
@ 2019-12-23 16:35 Michael Trimarchi
2019-12-23 16:35 ` [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit Michael Trimarchi
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michael Trimarchi @ 2019-12-23 16:35 UTC (permalink / raw)
To: Shawn Guo, linux-kernel
Cc: Fabio Estevam, Pengutronix Kernel Team, devicetree
Fix ethernet in imx6dl-icore-1.5 mipi developent kit. Adjust ethernet
reset in icore boards
Michael Trimarchi (3):
ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit
ARM: dts: imx6dl: Remove duplication in Engicam i.CoreM6 1.5 Quad/Dual
MIPI
arm: dts: imx6qdl: Move the phy reset at device level
arch/arm/boot/dts/imx6dl-icore-mipi.dts | 2 +-
arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 2 --
arch/arm/boot/dts/imx6qdl-icore.dtsi | 15 ++++++++++++++-
3 files changed, 15 insertions(+), 4 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit
2019-12-23 16:35 [PATCH 0/3] Engicam icore fixes Michael Trimarchi
@ 2019-12-23 16:35 ` Michael Trimarchi
2019-12-23 16:42 ` Fabio Estevam
2019-12-23 16:35 ` [PATCH 2/3] ARM: dts: imx6dl: Remove duplication in Engicam i.CoreM6 1.5 Quad/Dual MIPI Michael Trimarchi
2019-12-23 16:35 ` [PATCH 3/3] arm: dts: imx6qdl: Move the phy reset at device level Michael Trimarchi
2 siblings, 1 reply; 6+ messages in thread
From: Michael Trimarchi @ 2019-12-23 16:35 UTC (permalink / raw)
To: Shawn Guo, linux-kernel
Cc: Fabio Estevam, Pengutronix Kernel Team, devicetree
Fix the file to be included in dual mipi starter kit. This
fix ethernet probing
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
arch/arm/boot/dts/imx6dl-icore-mipi.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6dl-icore-mipi.dts b/arch/arm/boot/dts/imx6dl-icore-mipi.dts
index e43bccb78ab2..d8f3821a0ffd 100644
--- a/arch/arm/boot/dts/imx6dl-icore-mipi.dts
+++ b/arch/arm/boot/dts/imx6dl-icore-mipi.dts
@@ -8,7 +8,7 @@
/dts-v1/;
#include "imx6dl.dtsi"
-#include "imx6qdl-icore.dtsi"
+#include "imx6qdl-icore-1.5.dtsi"
/ {
model = "Engicam i.CoreM6 DualLite/Solo MIPI Starter Kit";
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit
2019-12-23 16:35 ` [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit Michael Trimarchi
@ 2019-12-23 16:42 ` Fabio Estevam
2019-12-23 16:44 ` Michael Nazzareno Trimarchi
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2019-12-23 16:42 UTC (permalink / raw)
To: Michael Trimarchi
Cc: Shawn Guo, linux-kernel, Pengutronix Kernel Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Jagan Teki
Hi Michael,
On Mon, Dec 23, 2019 at 1:35 PM Michael Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Fix the file to be included in dual mipi starter kit. This
> fix ethernet probing
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> arch/arm/boot/dts/imx6dl-icore-mipi.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-icore-mipi.dts b/arch/arm/boot/dts/imx6dl-icore-mipi.dts
> index e43bccb78ab2..d8f3821a0ffd 100644
> --- a/arch/arm/boot/dts/imx6dl-icore-mipi.dts
> +++ b/arch/arm/boot/dts/imx6dl-icore-mipi.dts
> @@ -8,7 +8,7 @@
> /dts-v1/;
>
> #include "imx6dl.dtsi"
> -#include "imx6qdl-icore.dtsi"
> +#include "imx6qdl-icore-1.5.dtsi"
Jagan submitted the same fix today:
http://lists.infradead.org/pipermail/linux-arm-kernel/2019-December/701895.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit
2019-12-23 16:42 ` Fabio Estevam
@ 2019-12-23 16:44 ` Michael Nazzareno Trimarchi
0 siblings, 0 replies; 6+ messages in thread
From: Michael Nazzareno Trimarchi @ 2019-12-23 16:44 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, linux-kernel, Pengutronix Kernel Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Jagan Teki
Hi
On Mon, Dec 23, 2019 at 5:43 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Michael,
>
> On Mon, Dec 23, 2019 at 1:35 PM Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Fix the file to be included in dual mipi starter kit. This
> > fix ethernet probing
> >
> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > ---
> > arch/arm/boot/dts/imx6dl-icore-mipi.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6dl-icore-mipi.dts b/arch/arm/boot/dts/imx6dl-icore-mipi.dts
> > index e43bccb78ab2..d8f3821a0ffd 100644
> > --- a/arch/arm/boot/dts/imx6dl-icore-mipi.dts
> > +++ b/arch/arm/boot/dts/imx6dl-icore-mipi.dts
> > @@ -8,7 +8,7 @@
> > /dts-v1/;
> >
> > #include "imx6dl.dtsi"
> > -#include "imx6qdl-icore.dtsi"
> > +#include "imx6qdl-icore-1.5.dtsi"
>
> Jagan submitted the same fix today:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2019-December/701895.html
Sorry, was not in copy. He said to me but I was not aware about one of my queue
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] ARM: dts: imx6dl: Remove duplication in Engicam i.CoreM6 1.5 Quad/Dual MIPI
2019-12-23 16:35 [PATCH 0/3] Engicam icore fixes Michael Trimarchi
2019-12-23 16:35 ` [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit Michael Trimarchi
@ 2019-12-23 16:35 ` Michael Trimarchi
2019-12-23 16:35 ` [PATCH 3/3] arm: dts: imx6qdl: Move the phy reset at device level Michael Trimarchi
2 siblings, 0 replies; 6+ messages in thread
From: Michael Trimarchi @ 2019-12-23 16:35 UTC (permalink / raw)
To: Shawn Guo, linux-kernel
Cc: Fabio Estevam, Pengutronix Kernel Team, devicetree
Avoid to re-define the reset gpio for ethernet multiple time. The
imx6qdl-icore-1.5.dtsi include imx6qdl-icore.dtsi that already
define the reset method
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi b/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
index d91d46b5898f..0fd7f2e24d9c 100644
--- a/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-icore-1.5.dtsi
@@ -25,10 +25,8 @@
&fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
- phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
clocks = <&clks IMX6QDL_CLK_ENET>,
<&clks IMX6QDL_CLK_ENET>,
<&clks IMX6QDL_CLK_ENET_REF>;
- phy-mode = "rmii";
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] arm: dts: imx6qdl: Move the phy reset at device level
2019-12-23 16:35 [PATCH 0/3] Engicam icore fixes Michael Trimarchi
2019-12-23 16:35 ` [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit Michael Trimarchi
2019-12-23 16:35 ` [PATCH 2/3] ARM: dts: imx6dl: Remove duplication in Engicam i.CoreM6 1.5 Quad/Dual MIPI Michael Trimarchi
@ 2019-12-23 16:35 ` Michael Trimarchi
2 siblings, 0 replies; 6+ messages in thread
From: Michael Trimarchi @ 2019-12-23 16:35 UTC (permalink / raw)
To: Shawn Guo, linux-kernel
Cc: Fabio Estevam, Pengutronix Kernel Team, devicetree
LAN8720 needs a reset of every clock enable. The reset needs
to be done at device level, due the flag PHY_RST_AFTER_CLK_EN
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
arch/arm/boot/dts/imx6qdl-icore.dtsi | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
index 7814f1ef0804..756f3a9f1b4f 100644
--- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
@@ -150,10 +150,23 @@
&fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_enet>;
- phy-reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
clocks = <&clks IMX6QDL_CLK_ENET>, <&clks IMX6QDL_CLK_ENET>, <&rmii_clk>;
phy-mode = "rmii";
+ phy-handle = <ð_phy>;
status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0>;
+ reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <4000>;
+ reset-deassert-us = <4000>;
+ };
+ };
};
&gpmi {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-23 16:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-23 16:35 [PATCH 0/3] Engicam icore fixes Michael Trimarchi
2019-12-23 16:35 ` [PATCH 1/3] ARM: dts: imx6dl: Fix typo in i.CoreM6 1.5 Dual MIPI starter kit Michael Trimarchi
2019-12-23 16:42 ` Fabio Estevam
2019-12-23 16:44 ` Michael Nazzareno Trimarchi
2019-12-23 16:35 ` [PATCH 2/3] ARM: dts: imx6dl: Remove duplication in Engicam i.CoreM6 1.5 Quad/Dual MIPI Michael Trimarchi
2019-12-23 16:35 ` [PATCH 3/3] arm: dts: imx6qdl: Move the phy reset at device level Michael Trimarchi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.