All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] platform: goldfish: pipe: switch to platform_get_irq
@ 2019-12-29  8:34 Yangtao Li
  0 siblings, 0 replies; 3+ messages in thread
From: Yangtao Li @ 2019-12-29  8:34 UTC (permalink / raw)
  To: ira.weiny, hubcap, akpm; +Cc: linux-kernel, Yangtao Li

platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index cef0133aa47a..a1ebaec6eea9 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!r)
-		return -EINVAL;
-
-	dev->irq = r->start;
+	dev->irq = platform_get_irq(pdev, 0);
+	if (dev->irq < 0)
+		return dev->irq;
 
 	/*
 	 * Exchange the versions with the host device
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache()
@ 2019-12-29 10:43 Yangtao Li
  2019-12-29 10:43 ` [PATCH] platform: goldfish: pipe: switch to platform_get_irq Yangtao Li
  0 siblings, 1 reply; 3+ messages in thread
From: Yangtao Li @ 2019-12-29 10:43 UTC (permalink / raw)
  To: corbet, gregkh, bgolaszewski, arnd, sboyd, mchehab+samsung,
	matti.vaittinen, phil.edworthy, suzuki.poulose, saravanak,
	heikki.krogerus, dan.j.williams, joe, jeffrey.t.kirsher, mans,
	tglx, hdegoede, akpm, ulf.hansson, ztuowen, sergei.shtylyov,
	linux-doc, linux-kernel
  Cc: Yangtao Li

Provide a variant of devm_ioremap_resource() for nocache ioremap.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 Documentation/driver-api/driver-model/devres.rst |  1 +
 include/linux/device.h                           |  2 ++
 lib/devres.c                                     | 15 +++++++++++++++
 3 files changed, 18 insertions(+)

diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
index 13046fcf0a5d..af1b1b9e3a17 100644
--- a/Documentation/driver-api/driver-model/devres.rst
+++ b/Documentation/driver-api/driver-model/devres.rst
@@ -317,6 +317,7 @@ IOMAP
   devm_ioremap_uc()
   devm_ioremap_wc()
   devm_ioremap_resource() : checks resource, requests memory region, ioremaps
+  devm_ioremap_resource_nocache()
   devm_ioremap_resource_wc()
   devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device
   devm_platform_ioremap_resource_wc()
diff --git a/include/linux/device.h b/include/linux/device.h
index 96ff76731e93..3aa353aa52e2 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -962,6 +962,8 @@ extern void devm_free_pages(struct device *dev, unsigned long addr);
 
 void __iomem *devm_ioremap_resource(struct device *dev,
 				    const struct resource *res);
+void __iomem *devm_ioremap_resource_nocache(struct device *dev,
+					    const struct resource *res);
 void __iomem *devm_ioremap_resource_wc(struct device *dev,
 				       const struct resource *res);
 
diff --git a/lib/devres.c b/lib/devres.c
index f56070cf970b..a182f8479fbf 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -188,6 +188,21 @@ void __iomem *devm_ioremap_resource(struct device *dev,
 }
 EXPORT_SYMBOL(devm_ioremap_resource);
 
+/**
+ * devm_ioremap_resource_nocache() - nocache variant of
+ *				      devm_ioremap_resource()
+ * @dev: generic device to handle the resource for
+ * @res: resource to be handled
+ *
+ * Returns a pointer to the remapped memory or an ERR_PTR() encoded error code
+ * on failure.
+ */
+void __iomem *devm_ioremap_resource_nocache(struct device *dev,
+					    const struct resource *res)
+{
+	return __devm_ioremap_resource(dev, res, DEVM_IOREMAP_NC);
+}
+
 /**
  * devm_ioremap_resource_wc() - write-combined variant of
  *				devm_ioremap_resource()
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-29 10:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-29  8:34 [PATCH] platform: goldfish: pipe: switch to platform_get_irq Yangtao Li
  -- strict thread matches above, loose matches on Subject: below --
2019-12-29 10:43 [PATCH 1/2] lib: devres: provide devm_ioremap_resource_nocache() Yangtao Li
2019-12-29 10:43 ` [PATCH] platform: goldfish: pipe: switch to platform_get_irq Yangtao Li
2019-12-29 10:44   ` Frank Lee

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.