All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Add Wa_1407352427:icl,ehl
@ 2019-12-26 17:46 Matt Roper
  2019-12-26 18:10 ` Lionel Landwerlin
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Matt Roper @ 2019-12-26 17:46 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

The workaround database now indicates we need to disable psdunit clock
gating as well.

Bspec: 32354
Bspec: 33450
Bspec: 33451
Suggested-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h | 3 +++
 drivers/gpu/drm/i915/intel_pm.c | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index bbfedeb00b7f..b98734378c9a 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4179,6 +4179,9 @@ enum {
 #define UNSLICE_UNIT_LEVEL_CLKGATE	_MMIO(0x9434)
 #define  VFUNIT_CLKGATE_DIS		(1 << 20)
 
+#define UNSLICE_UNIT_LEVEL_CLKGATE2	_MMIO(0x94e4)
+#define   PSDUNIT_CLKGATE_DIS		REG_BIT(5)
+
 #define INF_UNIT_LEVEL_CLKGATE		_MMIO(0x9560)
 #define   CGPSF_CLKGATE_DIS		(1 << 3)
 
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 31ec82337e4f..8bc8f0836368 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6590,6 +6590,10 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)
 	/* WaEnable32PlaneMode:icl */
 	I915_WRITE(GEN9_CSFE_CHICKEN1_RCS,
 		   _MASKED_BIT_ENABLE(GEN11_ENABLE_32_PLANE_MODE));
+
+	/* Wa_1407352427:icl,ehl */
+	intel_uncore_rmw(&dev_priv->uncore, UNSLICE_UNIT_LEVEL_CLKGATE2,
+			 0, PSDUNIT_CLKGATE_DIS);
 }
 
 static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2020-01-01  2:50 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-26 17:46 [Intel-gfx] [PATCH] drm/i915: Add Wa_1407352427:icl,ehl Matt Roper
2019-12-26 18:10 ` Lionel Landwerlin
2019-12-26 18:40   ` [Intel-gfx] [PATCH v2] " Matt Roper
2019-12-26 18:40     ` Matt Roper
2019-12-30  0:56     ` [Intel-gfx] " Sasha Levin
2019-12-31 19:07     ` [Intel-gfx] [PATCH v3] " Matt Roper
2019-12-31 19:07       ` Matt Roper
2019-12-26 18:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2019-12-26 19:16 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add Wa_1407352427:icl,ehl (rev2) Patchwork
2019-12-31 18:53 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add Wa_1407352427:icl,ehl (rev3) Patchwork
2019-12-31 19:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add Wa_1407352427:icl,ehl (rev4) Patchwork
2020-01-01  2:00 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-01-01  2:50   ` Matt Roper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.