From: Krzysztof Kozlowski <krzk@kernel.org>
To: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
mark.rutland@arm.com, kgene@kernel.org, hminas@synopsys.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com,
amelie.delaunay@st.com
Subject: Re: [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" from hsotg node
Date: Mon, 30 Dec 2019 16:37:58 +0100 [thread overview]
Message-ID: <20191230153758.GB4918@pi3> (raw)
In-Reply-To: <20191219103536.25485-3-benjamin.gaignard@st.com>
On Thu, Dec 19, 2019 at 11:35:36AM +0100, Benjamin Gaignard wrote:
> Remove "snps,dwc2" from hsotg@12480000 node compatible list because
> "samsung,s3c6400-hsotg" should be enough.
The more detailed compatible is almost always "enough". Some other nodes
also have detailed+generic compatible. In this case there is a driver
matching "snps,dwc2" so why removing it?
Best regards,
Krzysztof
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index b016b0b68306..d4866269f4ee 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -362,7 +362,7 @@
> };
>
> hsotg: hsotg@12480000 {
> - compatible = "samsung,s3c6400-hsotg", "snps,dwc2";
> + compatible = "samsung,s3c6400-hsotg";
> reg = <0x12480000 0x20000>;
> interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cmu CLK_USBOTG>;
> --
> 2.15.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
amelie.delaunay@st.com, linux-samsung-soc@vger.kernel.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
kgene@kernel.org, hminas@synopsys.com,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" from hsotg node
Date: Mon, 30 Dec 2019 16:37:58 +0100 [thread overview]
Message-ID: <20191230153758.GB4918@pi3> (raw)
In-Reply-To: <20191219103536.25485-3-benjamin.gaignard@st.com>
On Thu, Dec 19, 2019 at 11:35:36AM +0100, Benjamin Gaignard wrote:
> Remove "snps,dwc2" from hsotg@12480000 node compatible list because
> "samsung,s3c6400-hsotg" should be enough.
The more detailed compatible is almost always "enough". Some other nodes
also have detailed+generic compatible. In this case there is a driver
matching "snps,dwc2" so why removing it?
Best regards,
Krzysztof
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index b016b0b68306..d4866269f4ee 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -362,7 +362,7 @@
> };
>
> hsotg: hsotg@12480000 {
> - compatible = "samsung,s3c6400-hsotg", "snps,dwc2";
> + compatible = "samsung,s3c6400-hsotg";
> reg = <0x12480000 0x20000>;
> interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cmu CLK_USBOTG>;
> --
> 2.15.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-30 15:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 10:35 [PATCH v2 0/2] Add yaml DWC2 bindings Benjamin Gaignard
2019-12-19 10:35 ` Benjamin Gaignard
2019-12-19 10:35 ` [PATCH v2 1/2] dt-bindings: usb: Convert DWC2 bindings to json-schema Benjamin Gaignard
2019-12-19 10:35 ` Benjamin Gaignard
2019-12-30 15:35 ` Krzysztof Kozlowski
2019-12-30 15:35 ` Krzysztof Kozlowski
2020-01-02 8:43 ` Benjamin GAIGNARD
2020-01-02 8:43 ` Benjamin GAIGNARD
2019-12-19 10:35 ` [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" from hsotg node Benjamin Gaignard
2019-12-19 10:35 ` [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps, dwc2" " Benjamin Gaignard
2019-12-30 15:37 ` Krzysztof Kozlowski [this message]
2019-12-30 15:37 ` [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" " Krzysztof Kozlowski
2020-01-02 8:50 ` Benjamin GAIGNARD
2020-01-02 8:50 ` [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps, dwc2" " Benjamin GAIGNARD
2020-01-03 11:16 ` [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2" " Krzysztof Kozlowski
2020-01-03 11:16 ` Krzysztof Kozlowski
2019-12-19 12:54 ` [PATCH v2 0/2] Add yaml DWC2 bindings Minas Harutyunyan
2019-12-19 12:54 ` Minas Harutyunyan
2019-12-20 22:53 ` Rob Herring
2019-12-20 22:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230153758.GB4918@pi3 \
--to=krzk@kernel.org \
--cc=amelie.delaunay@st.com \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.