All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <gaoxiang25@huawei.com>
To: Vladimir Zapolskiy <vladimir@tuxera.com>
Cc: linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
	Gao Xiang <xiang@kernel.org>, Miao Xie <miaoxie@huawei.com>,
	Anton Altaparmakov <anton@tuxera.com>
Subject: Re: [PATCH] erofs: correct indentation of an assigned structure inside a function
Date: Thu, 2 Jan 2020 20:25:30 +0800	[thread overview]
Message-ID: <20200102122530.GA39947@architecture4> (raw)
In-Reply-To: <20200102120232.15074-1-vladimir@tuxera.com>

On Thu, Jan 02, 2020 at 02:02:32PM +0200, Vladimir Zapolskiy wrote:
> Trivial change, the expected indentation ruled by the coding style
> hasn't been met.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
> ---
>  fs/erofs/xattr.h | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/fs/erofs/xattr.h b/fs/erofs/xattr.h
> index 3585b84d2f20..50966f1c676e 100644
> --- a/fs/erofs/xattr.h
> +++ b/fs/erofs/xattr.h
> @@ -46,18 +46,19 @@ extern const struct xattr_handler erofs_xattr_security_handler;
>  
>  static inline const struct xattr_handler *erofs_xattr_handler(unsigned int idx)
>  {
> -static const struct xattr_handler *xattr_handler_map[] = {
> -	[EROFS_XATTR_INDEX_USER] = &erofs_xattr_user_handler,
> +	static const struct xattr_handler *xattr_handler_map[] = {
> +		[EROFS_XATTR_INDEX_USER] = &erofs_xattr_user_handler,
>  #ifdef CONFIG_EROFS_FS_POSIX_ACL
> -	[EROFS_XATTR_INDEX_POSIX_ACL_ACCESS] = &posix_acl_access_xattr_handler,
> -	[EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT] =
> -		&posix_acl_default_xattr_handler,
> +		[EROFS_XATTR_INDEX_POSIX_ACL_ACCESS] =
> +			&posix_acl_access_xattr_handler,
> +		[EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT] =
> +			&posix_acl_default_xattr_handler,
>  #endif
> -	[EROFS_XATTR_INDEX_TRUSTED] = &erofs_xattr_trusted_handler,
> +		[EROFS_XATTR_INDEX_TRUSTED] = &erofs_xattr_trusted_handler,
>  #ifdef CONFIG_EROFS_FS_SECURITY
> -	[EROFS_XATTR_INDEX_SECURITY] = &erofs_xattr_security_handler,
> +		[EROFS_XATTR_INDEX_SECURITY] = &erofs_xattr_security_handler,
>  #endif
> -};
> +	};
>  
>  	return idx && idx < ARRAY_SIZE(xattr_handler_map) ?
>  		xattr_handler_map[idx] : NULL;
> -- 
> 2.20.1
>

Thanks, will apply for linux-next.

Thanks,
Gao Xiang


WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <gaoxiang25@huawei.com>
To: Vladimir Zapolskiy <vladimir@tuxera.com>
Cc: Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
	<linux-fsdevel@vger.kernel.org>, <linux-erofs@lists.ozlabs.org>,
	"Anton Altaparmakov" <anton@tuxera.com>,
	Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH] erofs: correct indentation of an assigned structure inside a function
Date: Thu, 2 Jan 2020 20:25:30 +0800	[thread overview]
Message-ID: <20200102122530.GA39947@architecture4> (raw)
In-Reply-To: <20200102120232.15074-1-vladimir@tuxera.com>

On Thu, Jan 02, 2020 at 02:02:32PM +0200, Vladimir Zapolskiy wrote:
> Trivial change, the expected indentation ruled by the coding style
> hasn't been met.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
> ---
>  fs/erofs/xattr.h | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/fs/erofs/xattr.h b/fs/erofs/xattr.h
> index 3585b84d2f20..50966f1c676e 100644
> --- a/fs/erofs/xattr.h
> +++ b/fs/erofs/xattr.h
> @@ -46,18 +46,19 @@ extern const struct xattr_handler erofs_xattr_security_handler;
>  
>  static inline const struct xattr_handler *erofs_xattr_handler(unsigned int idx)
>  {
> -static const struct xattr_handler *xattr_handler_map[] = {
> -	[EROFS_XATTR_INDEX_USER] = &erofs_xattr_user_handler,
> +	static const struct xattr_handler *xattr_handler_map[] = {
> +		[EROFS_XATTR_INDEX_USER] = &erofs_xattr_user_handler,
>  #ifdef CONFIG_EROFS_FS_POSIX_ACL
> -	[EROFS_XATTR_INDEX_POSIX_ACL_ACCESS] = &posix_acl_access_xattr_handler,
> -	[EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT] =
> -		&posix_acl_default_xattr_handler,
> +		[EROFS_XATTR_INDEX_POSIX_ACL_ACCESS] =
> +			&posix_acl_access_xattr_handler,
> +		[EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT] =
> +			&posix_acl_default_xattr_handler,
>  #endif
> -	[EROFS_XATTR_INDEX_TRUSTED] = &erofs_xattr_trusted_handler,
> +		[EROFS_XATTR_INDEX_TRUSTED] = &erofs_xattr_trusted_handler,
>  #ifdef CONFIG_EROFS_FS_SECURITY
> -	[EROFS_XATTR_INDEX_SECURITY] = &erofs_xattr_security_handler,
> +		[EROFS_XATTR_INDEX_SECURITY] = &erofs_xattr_security_handler,
>  #endif
> -};
> +	};
>  
>  	return idx && idx < ARRAY_SIZE(xattr_handler_map) ?
>  		xattr_handler_map[idx] : NULL;
> -- 
> 2.20.1
>

Thanks, will apply for linux-next.

Thanks,
Gao Xiang


  reply	other threads:[~2020-01-02 12:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02 12:02 [PATCH] erofs: correct indentation of an assigned structure inside a function Vladimir Zapolskiy
2020-01-02 12:02 ` Vladimir Zapolskiy
2020-01-02 12:25 ` Gao Xiang [this message]
2020-01-02 12:25   ` Gao Xiang
2020-01-02 12:33 ` Chao Yu
2020-01-02 12:33   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200102122530.GA39947@architecture4 \
    --to=gaoxiang25@huawei.com \
    --cc=anton@tuxera.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=vladimir@tuxera.com \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.