From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Noralf Trønnes" <noralf@tronnes.org>,
"David Lechner" <david@lechnology.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
"Chris Brandt" <chris.brandt@renesas.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] dt-bindings: display: sitronix, st7735r: Add Okaya rh128128t
Date: Thu, 2 Jan 2020 15:46:36 +0100 [thread overview]
Message-ID: <20200102144636.GA10075@ravnborg.org> (raw)
In-Reply-To: <20200102141246.370-2-geert+renesas@glider.be>
Hi Geert.
On Thu, Jan 02, 2020 at 03:12:44PM +0100, Geert Uytterhoeven wrote:
> Document support for the Okaya RH128128T display, which is a 128x128
> 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver.
>
> ST7715R and ST7735R are very similar. Their major difference is that
> the former is restricted to displays of up to 132x132 pixels, while the
> latter supports displays up to 132x162 pixels.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/display/sitronix,st7735r.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> index cd5c7186890a2be7..87ebdcb294e29798 100644
> --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
While touching the bindings file, can I convince you to convert it to
meta-schema format (.yaml)?
> @@ -4,7 +4,9 @@ This binding is for display panels using a Sitronix ST7735R controller in SPI
> mode.
>
> Required properties:
> -- compatible: "jianda,jd-t18003-t01", "sitronix,st7735r"
> +- compatible: Must be one of the following combinations:
> + - "jianda,jd-t18003-t01", "sitronix,st7735r"
> + - "okaya,rh128128t", "sitronix,st7715r"
It would be nice if there was a "description" for each pair of
compatible that identified the actual panel.
In your case "Okaya RH128128T 1.44" 128x128 TFT display"
It can be looked up in git history - but better to have it in the
binding file.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Lechner <david@lechnology.com>,
David Airlie <airlied@linux.ie>,
linux-renesas-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Chris Brandt <chris.brandt@renesas.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] dt-bindings: display: sitronix, st7735r: Add Okaya rh128128t
Date: Thu, 2 Jan 2020 15:46:36 +0100 [thread overview]
Message-ID: <20200102144636.GA10075@ravnborg.org> (raw)
In-Reply-To: <20200102141246.370-2-geert+renesas@glider.be>
Hi Geert.
On Thu, Jan 02, 2020 at 03:12:44PM +0100, Geert Uytterhoeven wrote:
> Document support for the Okaya RH128128T display, which is a 128x128
> 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver.
>
> ST7715R and ST7735R are very similar. Their major difference is that
> the former is restricted to displays of up to 132x132 pixels, while the
> latter supports displays up to 132x162 pixels.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/display/sitronix,st7735r.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> index cd5c7186890a2be7..87ebdcb294e29798 100644
> --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
> +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt
While touching the bindings file, can I convince you to convert it to
meta-schema format (.yaml)?
> @@ -4,7 +4,9 @@ This binding is for display panels using a Sitronix ST7735R controller in SPI
> mode.
>
> Required properties:
> -- compatible: "jianda,jd-t18003-t01", "sitronix,st7735r"
> +- compatible: Must be one of the following combinations:
> + - "jianda,jd-t18003-t01", "sitronix,st7735r"
> + - "okaya,rh128128t", "sitronix,st7715r"
It would be nice if there was a "description" for each pair of
compatible that identified the actual panel.
In your case "Okaya RH128128T 1.44" 128x128 TFT display"
It can be looked up in git history - but better to have it in the
binding file.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-02 14:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 14:12 [PATCH 0/3] drm: Add support for Okaya RH128128T Geert Uytterhoeven
2020-01-02 14:12 ` Geert Uytterhoeven
2020-01-02 14:12 ` [PATCH 1/3] dt-bindings: display: sitronix,st7735r: Add Okaya rh128128t Geert Uytterhoeven
2020-01-02 14:12 ` [PATCH 1/3] dt-bindings: display: sitronix, st7735r: " Geert Uytterhoeven
2020-01-02 14:46 ` Sam Ravnborg [this message]
2020-01-02 14:46 ` Sam Ravnborg
2020-01-06 16:47 ` David Lechner
2020-01-06 16:47 ` David Lechner
2020-01-02 14:12 ` [PATCH 2/3] drm/mipi_dbi: Add support for display offsets Geert Uytterhoeven
2020-01-02 14:12 ` Geert Uytterhoeven
2020-01-05 8:46 ` Sam Ravnborg
2020-01-05 8:46 ` Sam Ravnborg
2020-01-02 14:12 ` [PATCH 3/3] drm: tiny: st7735r: Add support for Okaya RH128128T Geert Uytterhoeven
2020-01-02 14:12 ` Geert Uytterhoeven
2020-01-05 9:13 ` Sam Ravnborg
2020-01-05 9:13 ` Sam Ravnborg
2020-01-06 9:28 ` Geert Uytterhoeven
2020-01-06 9:28 ` Geert Uytterhoeven
2020-01-06 17:08 ` Sam Ravnborg
2020-01-06 17:08 ` Sam Ravnborg
2020-01-07 12:00 ` Geert Uytterhoeven
2020-01-07 12:00 ` Geert Uytterhoeven
2020-01-06 17:12 ` David Lechner
2020-01-06 17:12 ` David Lechner
2020-01-07 12:46 ` Geert Uytterhoeven
2020-01-07 12:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102144636.GA10075@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=chris.brandt@renesas.com \
--cc=daniel@ffwll.ch \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.