[PATCH V2] u-boot-fw-utils: Add support for libubootenv

[PATCH V2] u-boot-fw-utils: Add support for libubootenv

[Stefano Babic]

libubootenv is a replacement for u-boot-fw-utils. It is
hardware-independent and provides fw_printenv and fw_setenv tools that
are full compatible with the ones provided by U-Boot. A library is
provided to access the environment from an own application.
License is LGPL-2.1 and this allow to link the library to proprietary
code. The user of the tools should install the configuration file
"fw_env.config", as he is already used to with u-boot-fw-utils. The
configuration file is compatible with u-boot-fw-utils.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---

Changes since V1:
	- drop PACKAGE_ARCH (M. Jansa)

 meta/recipes-bsp/u-boot/libubootenv.inc    | 25 ++++++++++++++++++++++
 meta/recipes-bsp/u-boot/libubootenv_0.2.bb |  2 ++
 2 files changed, 27 insertions(+)
 create mode 100644 meta/recipes-bsp/u-boot/libubootenv.inc
 create mode 100644 meta/recipes-bsp/u-boot/libubootenv_0.2.bb

diff --git a/meta/recipes-bsp/u-boot/libubootenv.inc b/meta/recipes-bsp/u-boot/libubootenv.inc
new file mode 100644
index 0000000000..de7bee9197
--- /dev/null
+++ b/meta/recipes-bsp/u-boot/libubootenv.inc
@@ -0,0 +1,25 @@
+SUMMARY = "U-Boot libraries and tools to access environment"
+DEPENDS += "mtd-utils"
+
+DESCRIPTION = "This package contains tools and libraries to read \
+and modify U-Boot environment. \
+It provides a hardware-independent replacement for fw_printenv/setenv utilities \
+provided by U-Boot"
+
+HOMEPAGE = "https://github.com/sbabic/libubootenv"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://Licenses/lgpl-2.1.txt;md5=4fbd65380cdd255951079008b364516c"
+SECTION = "libs"
+
+SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https"
+
+S = "${WORKDIR}/git"
+
+inherit cmake
+
+EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
+
+PROVIDES += "u-boot-fw-utils"
+RPROVIDES_${PN} += "u-boot-fw-utils"
+
+BBCLASSEXTEND = "native"
diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
new file mode 100644
index 0000000000..96a60cbc4b
--- /dev/null
+++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
@@ -0,0 +1,2 @@
+require libubootenv.inc
+SRCREV = "bf6ff631c0e38cede67268ceb8bf1383b5f8848e"
-- 
2.17.1

Re: [PATCH V2] u-boot-fw-utils: Add support for libubootenv

[Ross Burton]

On 02/01/2020 17:52, Stefano Babic wrote:
> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
> @@ -0,0 +1,2 @@
> +require libubootenv.inc
> +SRCREV = "bf6ff631c0e38cede67268ceb8bf1383b5f8848e"

I *really* dislike bb/inc splits where there's nothing gained apart from 
more work when editing recipes.  Can you just merge these?

Ross

Re: [PATCH V2] u-boot-fw-utils: Add support for libubootenv

[Stefano Babic]

Hi Ross,

On 02/01/20 19:22, Ross Burton wrote:
> On 02/01/2020 17:52, Stefano Babic wrote:
>> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.2.bb
>> @@ -0,0 +1,2 @@
>> +require libubootenv.inc
>> +SRCREV = "bf6ff631c0e38cede67268ceb8bf1383b5f8848e"
> 
> I *really* dislike bb/inc splits where there's nothing gained apart from
> more work when editing recipes.  Can you just merge these?

Of course, I'll do in V3.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [PATCH V2] u-boot-fw-utils: Add support for libubootenv

[Adrian Bunk]

On Thu, Jan 02, 2020 at 06:52:06PM +0100, Stefano Babic wrote:
> libubootenv is a replacement for u-boot-fw-utils. It is
> hardware-independent and provides fw_printenv and fw_setenv tools that
> are full compatible with the ones provided by U-Boot. A library is
> provided to access the environment from an own application.
> License is LGPL-2.1 and this allow to link the library to proprietary
> code. The user of the tools should install the configuration file
> "fw_env.config", as he is already used to with u-boot-fw-utils. The
> configuration file is compatible with u-boot-fw-utils.
>...

Why do we need two implementations of the same in OE-core?
meta-oe sounds more appropriate to me.

cu
Adrian

Re: [PATCH V2] u-boot-fw-utils: Add support for libubootenv

[Stefano Babic]

Hi Adrian,

On 02/01/20 19:30, Adrian Bunk wrote:
> On Thu, Jan 02, 2020 at 06:52:06PM +0100, Stefano Babic wrote:
>> libubootenv is a replacement for u-boot-fw-utils. It is
>> hardware-independent and provides fw_printenv and fw_setenv tools that
>> are full compatible with the ones provided by U-Boot. A library is
>> provided to access the environment from an own application.
>> License is LGPL-2.1 and this allow to link the library to proprietary
>> code. The user of the tools should install the configuration file
>> "fw_env.config", as he is already used to with u-boot-fw-utils. The
>> configuration file is compatible with u-boot-fw-utils.
>> ...
> 
> Why do we need two implementations of the same in OE-core?
> meta-oe sounds more appropriate to me.

Well, it looks to me more consistent that tools for U-Boot's environment
are grouped together. It seems to me more easy and transparent. I agree
with you if u-boot-fw-utils was in meta-oe/recipes-bsp.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================