From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: stable <stable@vger.kernel.org>, Stephen Boyd <sboyd@kernel.org>
Subject: Re: Clock related crashes in v5.4.y-queue
Date: Thu, 2 Jan 2020 22:01:19 +0100 [thread overview]
Message-ID: <20200102210119.GA250861@kroah.com> (raw)
In-Reply-To: <029dab5a-22f5-c4e9-0797-54cdba0f3539@roeck-us.net>
On Wed, Jan 01, 2020 at 06:44:08PM -0800, Guenter Roeck wrote:
> Hi,
>
> I see a number of crashes in the latest v5.4.y-queue; please see below
> for details. The problem bisects to commit 54a311c5d3988d ("clk: Fix memory
> leak in clk_unregister()").
>
> The context suggests recovery from a failed driver probe, and it appears
> that the memory is released twice. Interestingly, I don't see the problem
> in mainline.
>
> I would suggest to drop that patch from the stable queue.
That does not look right, as you point out, so I will go drop it now.
The logic of the clk structure lifetimes seems crazy, messing with krefs
and just "knowing" the lifecycle of the other structures seems like a
problem just waiting to happen...
thanks,
greg k-h
next prev parent reply other threads:[~2020-01-02 21:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 2:44 Clock related crashes in v5.4.y-queue Guenter Roeck
2020-01-02 3:41 ` Guenter Roeck
2020-01-02 7:30 ` Stephen Boyd
2020-01-02 14:13 ` Guenter Roeck
2020-01-02 14:19 ` Naresh Kamboju
2020-01-02 14:38 ` Guenter Roeck
2020-01-02 21:01 ` Greg Kroah-Hartman [this message]
2020-01-02 21:28 ` Guenter Roeck
2020-01-03 0:40 ` Sasha Levin
2020-01-03 14:50 ` Guenter Roeck
2020-01-05 16:02 ` Sasha Levin
2020-01-05 16:34 ` Guenter Roeck
2020-01-05 19:10 ` Sasha Levin
2020-01-06 13:20 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102210119.GA250861@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux@roeck-us.net \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.