From: Simon Horman <simon.horman@netronome.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Michal Kubecek <mkubecek@suse.cz>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH net-next] ethtool: remove set but not used variable 'lsettings'
Date: Fri, 03 Jan 2020 08:27:55 +0000 [thread overview]
Message-ID: <20200103082755.GG12930@netronome.com> (raw)
In-Reply-To: <20200103034856.177906-1-yuehaibing@huawei.com>
On Fri, Jan 03, 2020 at 03:48:56AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> net/ethtool/linkmodes.c: In function 'ethnl_set_linkmodes':
> net/ethtool/linkmodes.c:326:32: warning:
> variable 'lsettings' set but not used [-Wunused-but-set-variable]
> struct ethtool_link_settings *lsettings;
> ^
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@netronome.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Michal Kubecek <mkubecek@suse.cz>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH net-next] ethtool: remove set but not used variable 'lsettings'
Date: Fri, 3 Jan 2020 09:27:55 +0100 [thread overview]
Message-ID: <20200103082755.GG12930@netronome.com> (raw)
In-Reply-To: <20200103034856.177906-1-yuehaibing@huawei.com>
On Fri, Jan 03, 2020 at 03:48:56AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> net/ethtool/linkmodes.c: In function 'ethnl_set_linkmodes':
> net/ethtool/linkmodes.c:326:32: warning:
> variable 'lsettings' set but not used [-Wunused-but-set-variable]
> struct ethtool_link_settings *lsettings;
> ^
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
next prev parent reply other threads:[~2020-01-03 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 3:48 [PATCH net-next] ethtool: remove set but not used variable 'lsettings' YueHaibing
2020-01-03 3:48 ` YueHaibing
2020-01-03 7:39 ` Michal Kubecek
2020-01-03 7:39 ` Michal Kubecek
2020-01-03 8:25 ` Yuehaibing
2020-01-03 8:25 ` Yuehaibing
2020-01-03 20:22 ` David Miller
2020-01-03 20:22 ` David Miller
2020-01-03 8:27 ` Simon Horman [this message]
2020-01-03 8:27 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103082755.GG12930@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.