* [Intel-gfx] restore hdcp state same as previous @ 2020-01-03 13:00 Anshuman Gupta 2020-01-03 13:00 ` [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: " Anshuman Gupta 2020-01-03 15:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/1] " Patchwork 0 siblings, 2 replies; 4+ messages in thread From: Anshuman Gupta @ 2020-01-03 13:00 UTC (permalink / raw) To: intel-gfx Test-with: <20200103081107.28144-1-ramalingam.c@intel.com> Anshuman Gupta (1): drm/i915/hdcp: restore hdcp state same as previous drivers/gpu/drm/i915/display/intel_ddi.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: restore hdcp state same as previous 2020-01-03 13:00 [Intel-gfx] restore hdcp state same as previous Anshuman Gupta @ 2020-01-03 13:00 ` Anshuman Gupta 2020-01-03 13:34 ` Ramalingam C 2020-01-03 15:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/1] " Patchwork 1 sibling, 1 reply; 4+ messages in thread From: Anshuman Gupta @ 2020-01-03 13:00 UTC (permalink / raw) To: intel-gfx When port is disabled due to modeset or DPMS off actually it disables the HDCP encryption keeping its state to CP_ENABLED this doesn't enable HDCP again while port gets enable again. HDCP state should set accordingly when port is disabled. CC: Ramalingam C <ramalingam.c@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/display/intel_ddi.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 07acd0daca25..b1b79073e3f9 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -4137,7 +4137,14 @@ static void intel_disable_ddi(struct intel_encoder *encoder, const struct intel_crtc_state *old_crtc_state, const struct drm_connector_state *old_conn_state) { - intel_hdcp_disable(to_intel_connector(old_conn_state->connector)); + int ret; + + ret = intel_hdcp_disable(to_intel_connector(old_conn_state->connector)); + + if (old_conn_state->content_protection == + DRM_MODE_CONTENT_PROTECTION_ENABLED && !ret) + drm_hdcp_update_content_protection(old_conn_state->connector, + DRM_MODE_CONTENT_PROTECTION_DESIRED); if (intel_crtc_has_type(old_crtc_state, INTEL_OUTPUT_HDMI)) intel_disable_ddi_hdmi(encoder, old_crtc_state, old_conn_state); -- 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: restore hdcp state same as previous 2020-01-03 13:00 ` [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: " Anshuman Gupta @ 2020-01-03 13:34 ` Ramalingam C 0 siblings, 0 replies; 4+ messages in thread From: Ramalingam C @ 2020-01-03 13:34 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx On 2020-01-03 at 18:30:21 +0530, Anshuman Gupta wrote: > When port is disabled due to modeset or DPMS off actually > it disables the HDCP encryption keeping its state to > CP_ENABLED this doesn't enable HDCP again while port > gets enable again. HDCP state should set accordingly > when port is disabled. > > CC: Ramalingam C <ramalingam.c@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 07acd0daca25..b1b79073e3f9 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -4137,7 +4137,14 @@ static void intel_disable_ddi(struct intel_encoder *encoder, > const struct intel_crtc_state *old_crtc_state, > const struct drm_connector_state *old_conn_state) > { > - intel_hdcp_disable(to_intel_connector(old_conn_state->connector)); > + int ret; > + > + ret = intel_hdcp_disable(to_intel_connector(old_conn_state->connector)); > + > + if (old_conn_state->content_protection == > + DRM_MODE_CONTENT_PROTECTION_ENABLED && !ret) while relooking at it, locking is missing. mutex_lock(&hdcp->mutex); hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED; schedule_work(&hdcp->prop_work); mutex_unlock(&hdcp->mutex); -Ram > + drm_hdcp_update_content_protection(old_conn_state->connector, > + DRM_MODE_CONTENT_PROTECTION_DESIRED); > > if (intel_crtc_has_type(old_crtc_state, INTEL_OUTPUT_HDMI)) > intel_disable_ddi_hdmi(encoder, old_crtc_state, old_conn_state); > -- > 2.24.0 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/1] drm/i915/hdcp: restore hdcp state same as previous 2020-01-03 13:00 [Intel-gfx] restore hdcp state same as previous Anshuman Gupta 2020-01-03 13:00 ` [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: " Anshuman Gupta @ 2020-01-03 15:09 ` Patchwork 1 sibling, 0 replies; 4+ messages in thread From: Patchwork @ 2020-01-03 15:09 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: series starting with [1/1] drm/i915/hdcp: restore hdcp state same as previous URL : https://patchwork.freedesktop.org/series/71602/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7674 -> Patchwork_15987 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_15987 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_15987, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_15987: ### IGT changes ### #### Possible regressions #### * igt@i915_pm_rpm@module-reload: - fi-kbl-x1275: [PASS][1] -> [DMESG-WARN][2] +2 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live_gt_pm: - fi-icl-dsi: [PASS][3] -> [DMESG-FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-icl-dsi/igt@i915_selftest@live_gt_pm.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-icl-dsi/igt@i915_selftest@live_gt_pm.html * igt@i915_selftest@live_uncore: - fi-kbl-x1275: [PASS][5] -> [INCOMPLETE][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-kbl-x1275/igt@i915_selftest@live_uncore.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-kbl-x1275/igt@i915_selftest@live_uncore.html Known issues ------------ Here are the changes found in Patchwork_15987 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload-with-fault-injection: - fi-bxt-dsi: [PASS][7] -> [INCOMPLETE][8] ([fdo#103927]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][9] -> [FAIL][10] ([fdo#111096] / [i915#323]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html #### Possible fixes #### * igt@i915_module_load@reload-with-fault-injection: - fi-skl-6700k2: [INCOMPLETE][11] ([i915#671]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html - fi-skl-6770hq: [INCOMPLETE][13] ([i915#671]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html - fi-kbl-7500u: [INCOMPLETE][15] ([i915#879]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-kbl-7500u/igt@i915_module_load@reload-with-fault-injection.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-kbl-7500u/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_selftest@live_blt: - fi-hsw-4770: [DMESG-FAIL][17] ([i915#725]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7674/fi-hsw-4770/igt@i915_selftest@live_blt.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/fi-hsw-4770/igt@i915_selftest@live_blt.html [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#879]: https://gitlab.freedesktop.org/drm/intel/issues/879 Participating hosts (46 -> 40) ------------------------------ Additional (5): fi-hsw-4770r fi-bsw-n3050 fi-ilk-650 fi-elk-e7500 fi-byt-n2820 Missing (11): fi-kbl-soraka fi-hsw-4200u fi-hsw-peppy fi-glk-dsi fi-ctg-p8600 fi-bsw-kefka fi-blb-e6850 fi-tgl-y fi-byt-clapper fi-bdw-samus fi-snb-2600 Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7674 -> Patchwork_15987 CI-20190529: 20190529 CI_DRM_7674: 6cdc2db5a5641dd00f47fcc80b83bb8adb777797 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5357: a555a4b98f90dab655d24bb3d07e9291a8b8dac8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15987: deca4dc34bf61543d2f7433980cccccaf2cc154b @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == deca4dc34bf6 drm/i915/hdcp: restore hdcp state same as previous == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15987/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-03 15:09 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-01-03 13:00 [Intel-gfx] restore hdcp state same as previous Anshuman Gupta 2020-01-03 13:00 ` [Intel-gfx] [PATCH 1/1] drm/i915/hdcp: " Anshuman Gupta 2020-01-03 13:34 ` Ramalingam C 2020-01-03 15:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/1] " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.