* [PATCH netdev] net: stmmac: dwmac-sunxi: Allow all RGMII modes
@ 2020-01-06 3:09 ` Chen-Yu Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2020-01-06 3:09 UTC (permalink / raw)
To: David S. Miller, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
Maxime Ripard
Cc: netdev, Chen-Yu Tsai, linux-kernel, linux-arm-kernel
From: Chen-Yu Tsai <wens@csie.org>
Allow all the RGMII modes to be used. This would allow us to represent
the hardware better in the device tree with RGMII_ID where in most
cases the PHY's internal delay for both RX and TX are used.
Fixes: af0bd4e9ba80 ("net: stmmac: sunxi platform extensions for GMAC in Allwinner A20 SoC's")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Maybe CC stable so future device trees can be used with stable kernels?
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c
index 26353ef616b8..7d40760e9ba8 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c
@@ -44,7 +44,7 @@ static int sun7i_gmac_init(struct platform_device *pdev, void *priv)
* rate, which then uses the auto-reparenting feature of the
* clock driver, and enabling/disabling the clock.
*/
- if (gmac->interface == PHY_INTERFACE_MODE_RGMII) {
+ if (phy_interface_mode_is_rgmii(gmac->interface)) {
clk_set_rate(gmac->tx_clk, SUN7I_GMAC_GMII_RGMII_RATE);
clk_prepare_enable(gmac->tx_clk);
gmac->clk_enabled = 1;
--
2.24.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH netdev] net: stmmac: dwmac-sunxi: Allow all RGMII modes
@ 2020-01-06 3:09 ` Chen-Yu Tsai
0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2020-01-06 3:09 UTC (permalink / raw)
To: David S. Miller, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
Maxime Ripard
Cc: Chen-Yu Tsai, netdev, linux-arm-kernel, linux-kernel
From: Chen-Yu Tsai <wens@csie.org>
Allow all the RGMII modes to be used. This would allow us to represent
the hardware better in the device tree with RGMII_ID where in most
cases the PHY's internal delay for both RX and TX are used.
Fixes: af0bd4e9ba80 ("net: stmmac: sunxi platform extensions for GMAC in Allwinner A20 SoC's")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Maybe CC stable so future device trees can be used with stable kernels?
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c
index 26353ef616b8..7d40760e9ba8 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c
@@ -44,7 +44,7 @@ static int sun7i_gmac_init(struct platform_device *pdev, void *priv)
* rate, which then uses the auto-reparenting feature of the
* clock driver, and enabling/disabling the clock.
*/
- if (gmac->interface == PHY_INTERFACE_MODE_RGMII) {
+ if (phy_interface_mode_is_rgmii(gmac->interface)) {
clk_set_rate(gmac->tx_clk, SUN7I_GMAC_GMII_RGMII_RATE);
clk_prepare_enable(gmac->tx_clk);
gmac->clk_enabled = 1;
--
2.24.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH netdev] net: stmmac: dwmac-sunxi: Allow all RGMII modes
2020-01-06 3:09 ` Chen-Yu Tsai
@ 2020-01-06 21:47 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-01-06 21:47 UTC (permalink / raw)
To: wens
Cc: alexandre.torgue, netdev, linux-kernel, mripard, wens, joabreu,
peppe.cavallaro, linux-arm-kernel
From: Chen-Yu Tsai <wens@kernel.org>
Date: Mon, 6 Jan 2020 11:09:22 +0800
> Maybe CC stable so future device trees can be used with stable kernels?
Please read the netdev FAQ, you should never CC: stable for networking
changes.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH netdev] net: stmmac: dwmac-sunxi: Allow all RGMII modes
@ 2020-01-06 21:47 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-01-06 21:47 UTC (permalink / raw)
To: wens
Cc: peppe.cavallaro, alexandre.torgue, joabreu, mripard, wens, netdev,
linux-arm-kernel, linux-kernel
From: Chen-Yu Tsai <wens@kernel.org>
Date: Mon, 6 Jan 2020 11:09:22 +0800
> Maybe CC stable so future device trees can be used with stable kernels?
Please read the netdev FAQ, you should never CC: stable for networking
changes.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH netdev] net: stmmac: dwmac-sunxi: Allow all RGMII modes
2020-01-06 3:09 ` Chen-Yu Tsai
@ 2020-01-08 20:32 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-01-08 20:32 UTC (permalink / raw)
To: wens
Cc: alexandre.torgue, netdev, linux-kernel, mripard, wens, joabreu,
peppe.cavallaro, linux-arm-kernel
From: Chen-Yu Tsai <wens@kernel.org>
Date: Mon, 6 Jan 2020 11:09:22 +0800
> From: Chen-Yu Tsai <wens@csie.org>
>
> Allow all the RGMII modes to be used. This would allow us to represent
> the hardware better in the device tree with RGMII_ID where in most
> cases the PHY's internal delay for both RX and TX are used.
>
> Fixes: af0bd4e9ba80 ("net: stmmac: sunxi platform extensions for GMAC in Allwinner A20 SoC's")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied and queued up for -stable.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH netdev] net: stmmac: dwmac-sunxi: Allow all RGMII modes
@ 2020-01-08 20:32 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-01-08 20:32 UTC (permalink / raw)
To: wens
Cc: peppe.cavallaro, alexandre.torgue, joabreu, mripard, wens, netdev,
linux-arm-kernel, linux-kernel
From: Chen-Yu Tsai <wens@kernel.org>
Date: Mon, 6 Jan 2020 11:09:22 +0800
> From: Chen-Yu Tsai <wens@csie.org>
>
> Allow all the RGMII modes to be used. This would allow us to represent
> the hardware better in the device tree with RGMII_ID where in most
> cases the PHY's internal delay for both RX and TX are used.
>
> Fixes: af0bd4e9ba80 ("net: stmmac: sunxi platform extensions for GMAC in Allwinner A20 SoC's")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-08 20:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-06 3:09 [PATCH netdev] net: stmmac: dwmac-sunxi: Allow all RGMII modes Chen-Yu Tsai
2020-01-06 3:09 ` Chen-Yu Tsai
2020-01-06 21:47 ` David Miller
2020-01-06 21:47 ` David Miller
2020-01-08 20:32 ` David Miller
2020-01-08 20:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.