All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	Russell King <linux+etnaviv@armlinux.org.uk>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	etnaviv@lists.freedesktop.org
Subject: Re: [PATCH v2 0/6] update hwdw for gc400
Date: Mon, 6 Jan 2020 16:36:43 +0100	[thread overview]
Message-ID: <20200106153643.GA8535@ravnborg.org> (raw)
In-Reply-To: <20200106151655.311413-1-christian.gmeiner@gmail.com>

Hi Christian

On Mon, Jan 06, 2020 at 04:16:45PM +0100, Christian Gmeiner wrote:
> This patch series extends the hwdb for an entry for the gc400 found
> in the ST STM32 SoC. With this patches we report the same limits and
> features for this GPU as the galcore kernel driver does.

For future patches can you please incldue a small changelog
within each patch.

Something like

v2:
  - Drop redundant newlines (Lucas)

This serves several purposes:
- It explains what was changed since last version
- It allow the reader to focus on changed parts
- It attributes who requested a specific change
- It gives a good idea of the history of a patch

In the DRM sub-subsystem the idea is that if it is written it
should be visible in git too. So include the changelog part in the
normal commit-message.

	Sam

> 
> Christian Gmeiner (6):
>   drm/etnaviv: update hardware headers from rnndb
>   drm/etnaviv: determine product, customer and eco id
>   drm/etnaviv: show identity information in debugfs
>   drm/etnaviv: update gc7000 chip identity entry
>   drm/etnaviv: update hwdb selection logic
>   drm/etnaviv: add hwdb entry for gc400 found in STM32
> 
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c  | 18 ++++++++++-
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.h  |  6 ++--
>  drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 42 +++++++++++++++++++++++++-
>  drivers/gpu/drm/etnaviv/state_hi.xml.h | 29 +++++++++++-------
>  4 files changed, 79 insertions(+), 16 deletions(-)
> 
> -- 
> 2.24.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
	etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [PATCH v2 0/6] update hwdw for gc400
Date: Mon, 6 Jan 2020 16:36:43 +0100	[thread overview]
Message-ID: <20200106153643.GA8535@ravnborg.org> (raw)
In-Reply-To: <20200106151655.311413-1-christian.gmeiner@gmail.com>

Hi Christian

On Mon, Jan 06, 2020 at 04:16:45PM +0100, Christian Gmeiner wrote:
> This patch series extends the hwdb for an entry for the gc400 found
> in the ST STM32 SoC. With this patches we report the same limits and
> features for this GPU as the galcore kernel driver does.

For future patches can you please incldue a small changelog
within each patch.

Something like

v2:
  - Drop redundant newlines (Lucas)

This serves several purposes:
- It explains what was changed since last version
- It allow the reader to focus on changed parts
- It attributes who requested a specific change
- It gives a good idea of the history of a patch

In the DRM sub-subsystem the idea is that if it is written it
should be visible in git too. So include the changelog part in the
normal commit-message.

	Sam

> 
> Christian Gmeiner (6):
>   drm/etnaviv: update hardware headers from rnndb
>   drm/etnaviv: determine product, customer and eco id
>   drm/etnaviv: show identity information in debugfs
>   drm/etnaviv: update gc7000 chip identity entry
>   drm/etnaviv: update hwdb selection logic
>   drm/etnaviv: add hwdb entry for gc400 found in STM32
> 
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c  | 18 ++++++++++-
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.h  |  6 ++--
>  drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 42 +++++++++++++++++++++++++-
>  drivers/gpu/drm/etnaviv/state_hi.xml.h | 29 +++++++++++-------
>  4 files changed, 79 insertions(+), 16 deletions(-)
> 
> -- 
> 2.24.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-01-06 15:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 15:16 [PATCH v2 0/6] update hwdw for gc400 Christian Gmeiner
2020-01-06 15:16 ` Christian Gmeiner
2020-01-06 15:16 ` [PATCH v2 1/6] drm/etnaviv: update hardware headers from rnndb Christian Gmeiner
2020-01-06 15:16   ` Christian Gmeiner
2020-02-26 15:23   ` Lucas Stach
2020-02-26 15:23     ` Lucas Stach
2020-01-06 15:16 ` [PATCH v2 2/6] drm/etnaviv: determine product, customer and eco id Christian Gmeiner
2020-01-06 15:16   ` Christian Gmeiner
2020-01-06 15:16 ` [PATCH v2 3/6] drm/etnaviv: show identity information in debugfs Christian Gmeiner
2020-01-06 15:16   ` Christian Gmeiner
2020-01-06 15:16 ` [PATCH v2 4/6] drm/etnaviv: update gc7000 chip identity entry Christian Gmeiner
2020-01-06 15:16   ` Christian Gmeiner
2020-01-06 15:16 ` [PATCH v2 5/6] drm/etnaviv: update hwdb selection logic Christian Gmeiner
2020-01-06 15:16   ` Christian Gmeiner
2020-01-06 15:16 ` [PATCH v2 6/6] drm/etnaviv: add hwdb entry for gc400 found in STM32 Christian Gmeiner
2020-01-06 15:16   ` Christian Gmeiner
2020-01-06 15:36 ` Sam Ravnborg [this message]
2020-01-06 15:36   ` [PATCH v2 0/6] update hwdw for gc400 Sam Ravnborg
2020-01-06 16:01   ` Christian Gmeiner
2020-01-06 16:01     ` Christian Gmeiner
2020-01-06 16:28     ` Sam Ravnborg
2020-01-06 16:28       ` Sam Ravnborg
2020-02-24 13:16 ` Christian Gmeiner
2020-02-24 13:16   ` Christian Gmeiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200106153643.GA8535@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=christian.gmeiner@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=etnaviv@lists.freedesktop.org \
    --cc=linux+etnaviv@armlinux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.