All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
Date: Tue, 7 Jan 2020 10:04:49 +0100	[thread overview]
Message-ID: <20200107090449.GA32007@pi3> (raw)
In-Reply-To: <20200106191003.21584-2-tiny.windzz@gmail.com>

On Mon, Jan 06, 2020 at 07:10:03PM +0000, Yangtao Li wrote:
> This patch add at070tn92 panel for tiny4412 board.

Please fix description as in patch 1.

> 
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> index 2b62cb27420c..57f9d09233ad 100644
> --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
> +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> @@ -66,6 +66,16 @@
>  			clock-frequency = <24000000>;
>  		};
>  	};
> +
> +	panel {
> +		compatible = "innolux,at070tn92";
> +
> +		port {
> +			panel_input: endpoint {
> +				remote-endpoint = <&lcdc_output>;
> +			};
> +		};
> +	};
>  };
>  
>  &fimd {
> @@ -74,6 +84,12 @@
>  	#address-cells = <1>;
>  	#size-cells = <0>;
>  	status = "okay";

One empty space here.

> +	port@3 {
> +		reg = <3>;

Why starting from "3"? Why this is port@3, not just "port"?

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, kgene@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node
Date: Tue, 7 Jan 2020 10:04:49 +0100	[thread overview]
Message-ID: <20200107090449.GA32007@pi3> (raw)
In-Reply-To: <20200106191003.21584-2-tiny.windzz@gmail.com>

On Mon, Jan 06, 2020 at 07:10:03PM +0000, Yangtao Li wrote:
> This patch add at070tn92 panel for tiny4412 board.

Please fix description as in patch 1.

> 
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  arch/arm/boot/dts/exynos4412-tiny4412.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> index 2b62cb27420c..57f9d09233ad 100644
> --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
> +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> @@ -66,6 +66,16 @@
>  			clock-frequency = <24000000>;
>  		};
>  	};
> +
> +	panel {
> +		compatible = "innolux,at070tn92";
> +
> +		port {
> +			panel_input: endpoint {
> +				remote-endpoint = <&lcdc_output>;
> +			};
> +		};
> +	};
>  };
>  
>  &fimd {
> @@ -74,6 +84,12 @@
>  	#address-cells = <1>;
>  	#size-cells = <0>;
>  	status = "okay";

One empty space here.

> +	port@3 {
> +		reg = <3>;

Why starting from "3"? Why this is port@3, not just "port"?

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-07  9:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 19:10 [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Yangtao Li
2020-01-06 19:10 ` Yangtao Li
2020-01-06 19:10 ` [PATCH 2/2] ARM: dts: exynos: tiny4412: add proper panel node Yangtao Li
2020-01-06 19:10   ` Yangtao Li
2020-01-07  9:04   ` Krzysztof Kozlowski [this message]
2020-01-07  9:04     ` Krzysztof Kozlowski
2020-01-07 19:07     ` Frank Lee
2020-01-07 19:07       ` Frank Lee
2020-01-08  7:59       ` Krzysztof Kozlowski
2020-01-08  7:59         ` Krzysztof Kozlowski
2020-01-07  8:45 ` [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node Krzysztof Kozlowski
2020-01-07  8:45   ` Krzysztof Kozlowski
2020-01-07  8:49   ` Krzysztof Kozlowski
2020-01-07  8:49     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107090449.GA32007@pi3 \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tiny.windzz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.