From: Lee Jones <lee.jones@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Tony Lindgren <tony@atomide.com>,
Jean-Jacques Hiblot <jjhiblot@ti.com>,
jacek.anaszewski@gmail.com, sre@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, daniel.thompson@linaro.org, dmurphy@ti.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com
Subject: Re: [PATCH v10 6/6] backlight: add led-backlight driver
Date: Tue, 7 Jan 2020 14:33:42 +0000 [thread overview]
Message-ID: <20200107143342.GP14821@dell> (raw)
In-Reply-To: <20200107134540.x5tngzoslssesb2y@ucw.cz>
On Tue, 07 Jan 2020, Pavel Machek wrote:
> Hi!
>
> > > * Jean-Jacques Hiblot <jjhiblot@ti.com> [700101 00:00]:
> > > > From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > >
> > > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > > pwm_bl except the driver uses a LED class driver to adjust the
> > > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > > ...
> > >
> > > > + ret = of_property_read_u32(node, "default-brightness", &value);
> > > > + if (!ret && value <= priv->max_brightness)
> > > > + priv->default_brightness = value;
> > > > + else if (!ret && value > priv->max_brightness)
> > > > + dev_warn(dev, "Invalid default brightness. Ignoring it\n");
> > >
> > > Hmm so just wondering.. Are we using "default-brightness" instead of the
> > > usual "default-brightness-level" here?
> >
> > Did this get answered?
> >
> > > Please Cc me on the next patchset too :)
> >
> > I've been waiting for v11.
>
> I guess I could just remove it from a merge for now if there's no other
> fix.
What do you mean, sorry?
This patch should not be merged anywhere yet.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: mark.rutland@arm.com, daniel.thompson@linaro.org,
Tony Lindgren <tony@atomide.com>,
tomi.valkeinen@ti.com, sre@kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, jacek.anaszewski@gmail.com,
Jean-Jacques Hiblot <jjhiblot@ti.com>,
linux-leds@vger.kernel.org, dmurphy@ti.com
Subject: Re: [PATCH v10 6/6] backlight: add led-backlight driver
Date: Tue, 7 Jan 2020 14:33:42 +0000 [thread overview]
Message-ID: <20200107143342.GP14821@dell> (raw)
In-Reply-To: <20200107134540.x5tngzoslssesb2y@ucw.cz>
On Tue, 07 Jan 2020, Pavel Machek wrote:
> Hi!
>
> > > * Jean-Jacques Hiblot <jjhiblot@ti.com> [700101 00:00]:
> > > > From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > >
> > > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > > pwm_bl except the driver uses a LED class driver to adjust the
> > > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > > ...
> > >
> > > > + ret = of_property_read_u32(node, "default-brightness", &value);
> > > > + if (!ret && value <= priv->max_brightness)
> > > > + priv->default_brightness = value;
> > > > + else if (!ret && value > priv->max_brightness)
> > > > + dev_warn(dev, "Invalid default brightness. Ignoring it\n");
> > >
> > > Hmm so just wondering.. Are we using "default-brightness" instead of the
> > > usual "default-brightness-level" here?
> >
> > Did this get answered?
> >
> > > Please Cc me on the next patchset too :)
> >
> > I've been waiting for v11.
>
> I guess I could just remove it from a merge for now if there's no other
> fix.
What do you mean, sorry?
This patch should not be merged anywhere yet.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-07 14:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 8:51 [PATCH v10 0/6] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-10-09 8:51 ` Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 1/6] leds: populate the device's of_node Jean-Jacques Hiblot
2019-10-09 8:51 ` Jean-Jacques Hiblot
2019-10-09 10:52 ` Tomi Valkeinen
2019-10-09 10:52 ` Tomi Valkeinen
2019-10-09 8:51 ` [PATCH v10 2/6] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-10-09 8:51 ` Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 3/6] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-10-09 8:51 ` Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 4/6] dts-bindings: leds: Document the naming requirement for LED properties Jean-Jacques Hiblot
2019-10-09 8:51 ` Jean-Jacques Hiblot
2019-10-09 19:26 ` Rob Herring
2019-10-09 19:26 ` Rob Herring
2019-10-10 10:31 ` Jean-Jacques Hiblot
2019-10-10 10:31 ` Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 5/6] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-09 8:51 ` Jean-Jacques Hiblot
2019-10-09 19:35 ` Rob Herring
2019-11-21 18:22 ` Tony Lindgren
2019-11-21 18:22 ` Tony Lindgren
2019-10-09 8:51 ` [PATCH v10 6/6] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-10-09 8:51 ` Jean-Jacques Hiblot
2019-11-21 18:13 ` Tony Lindgren
2019-11-21 18:13 ` Tony Lindgren
2020-01-07 10:28 ` Lee Jones
2020-01-07 10:28 ` Lee Jones
2020-01-07 13:45 ` Pavel Machek
2020-01-07 13:45 ` Pavel Machek
2020-01-07 14:33 ` Lee Jones [this message]
2020-01-07 14:33 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107143342.GP14821@dell \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.