From: Joerg Roedel <jroedel@suse.de>
To: Qian Cai <cai@lca.pw>
Cc: iommu@lists.linux-foundation.org, robin.murphy@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/dma: fix variable 'cookie' set but not used
Date: Tue, 7 Jan 2020 17:03:08 +0100 [thread overview]
Message-ID: <20200107160308.GC5622@suse.de> (raw)
In-Reply-To: <20200106152727.1589-1-cai@lca.pw>
On Mon, Jan 06, 2020 at 10:27:27AM -0500, Qian Cai wrote:
> The commit c18647900ec8 ("iommu/dma: Relax locking in
> iommu_dma_prepare_msi()") introduced a compliation warning,
>
> drivers/iommu/dma-iommu.c: In function 'iommu_dma_prepare_msi':
> drivers/iommu/dma-iommu.c:1206:27: warning: variable 'cookie' set but
> not used [-Wunused-but-set-variable]
> struct iommu_dma_cookie *cookie;
> ^~~~~~
>
> Fixes: c18647900ec8 ("iommu/dma: Relax locking in iommu_dma_prepare_msi()")
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> drivers/iommu/dma-iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied for v5.5, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <jroedel@suse.de>
To: Qian Cai <cai@lca.pw>
Cc: robin.murphy@arm.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/dma: fix variable 'cookie' set but not used
Date: Tue, 7 Jan 2020 17:03:08 +0100 [thread overview]
Message-ID: <20200107160308.GC5622@suse.de> (raw)
In-Reply-To: <20200106152727.1589-1-cai@lca.pw>
On Mon, Jan 06, 2020 at 10:27:27AM -0500, Qian Cai wrote:
> The commit c18647900ec8 ("iommu/dma: Relax locking in
> iommu_dma_prepare_msi()") introduced a compliation warning,
>
> drivers/iommu/dma-iommu.c: In function 'iommu_dma_prepare_msi':
> drivers/iommu/dma-iommu.c:1206:27: warning: variable 'cookie' set but
> not used [-Wunused-but-set-variable]
> struct iommu_dma_cookie *cookie;
> ^~~~~~
>
> Fixes: c18647900ec8 ("iommu/dma: Relax locking in iommu_dma_prepare_msi()")
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> drivers/iommu/dma-iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied for v5.5, thanks.
next prev parent reply other threads:[~2020-01-07 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:27 [PATCH] iommu/dma: fix variable 'cookie' set but not used Qian Cai
2020-01-06 15:27 ` Qian Cai
2020-01-06 18:19 ` Robin Murphy
2020-01-06 18:19 ` Robin Murphy
2020-01-06 18:44 ` Qian Cai
2020-01-06 18:44 ` Qian Cai
2020-01-07 16:03 ` Joerg Roedel [this message]
2020-01-07 16:03 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107160308.GC5622@suse.de \
--to=jroedel@suse.de \
--cc=cai@lca.pw \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.