From: Jason Gunthorpe <jgg@ziepe.ca>
To: madhuparnabhowmik04@gmail.com
Cc: mike.marciniszyn@intel.com, paulmck@kernel.org,
linux-rdma@vger.kernel.org, dennis.dalessandro@intel.com,
linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
dledford@redhat.com, joel@joelfernandes.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
Date: Tue, 7 Jan 2020 16:33:54 -0400 [thread overview]
Message-ID: <20200107203354.GD26174@ziepe.ca> (raw)
In-Reply-To: <20200107192912.22691-1-madhuparnabhowmik04@gmail.com>
On Wed, Jan 08, 2020 at 12:59:12AM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..e6abdbcb4ffb 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
> opa_get_lid(packet->dlid, 9B));
> if (!mcast)
> goto drop;
> - list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> + list_for_each_entry_rcu(p, &mcast->qp_list, list,
> + lock_is_held(&(ibp->rvp.lock).dep_map)) {
Why .dep_map? Does this compile?
Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: madhuparnabhowmik04@gmail.com
To: jgg@ziepe.ca, madhuparnabhowmik04@gmail.com
Cc: mike.marciniszyn@intel.com, paulmck@kernel.org,
linux-rdma@vger.kernel.org, dennis.dalessandro@intel.com,
linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
dledford@redhat.com, joel@joelfernandes.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
Date: Wed, 8 Jan 2020 13:35:07 +0530 [thread overview]
Message-ID: <20200107203354.GD26174@ziepe.ca> (raw)
Message-ID: <20200108080507.nPKHNRH4jQDUUKHzjZ1fxS0Wi3bgglDsxm3KFjWvd2g@z> (raw)
In-Reply-To: <20200107192912.22691-1-madhuparnabhowmik04@gmail.com>
From: Jason Gunthorpe <jgg@ziepe.ca>
On Wed, Jan 08, 2020 at 12:59:12AM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..e6abdbcb4ffb 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
> opa_get_lid(packet->dlid, 9B));
> if (!mcast)
> goto drop;
> - list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> + list_for_each_entry_rcu(p, &mcast->qp_list, list,
> + lock_is_held(&(ibp->rvp.lock).dep_map)) {
Why .dep_map? Does this compile?
Alternatively, it can be lockdep_is_held(ibp->rvp.lock).
Please refer to the macro(link below) and let me know if the usage of lock_is_held()
in the patch is correct.
https://elixir.bootlin.com/linux/v5.5-rc2/source/include/linux/lockdep.h#L364
Thanks,
Madhuparna
Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: madhuparnabhowmik04@gmail.com
To: jgg@ziepe.ca, madhuparnabhowmik04@gmail.com
Cc: mike.marciniszyn@intel.com, paulmck@kernel.org,
linux-rdma@vger.kernel.org, dennis.dalessandro@intel.com,
linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
dledford@redhat.com, joel@joelfernandes.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
Date: Wed, 8 Jan 2020 13:38:50 +0530 [thread overview]
Message-ID: <20200107203354.GD26174@ziepe.ca> (raw)
Message-ID: <20200108080850.y8_V2Q9knvWcbA61rlXhN6e8osCqqVsdnXR3FVAZBsw@z> (raw)
In-Reply-To: <20200107192912.22691-1-madhuparnabhowmik04@gmail.com>
From: madhuparnabhowmik04@gmail.com
From: Jason Gunthorpe <jgg@ziepe.ca>
On Wed, Jan 08, 2020 at 12:59:12AM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..e6abdbcb4ffb 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
> opa_get_lid(packet->dlid, 9B));
> if (!mcast)
> goto drop;
> - list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> + list_for_each_entry_rcu(p, &mcast->qp_list, list,
> + lock_is_held(&(ibp->rvp.lock).dep_map)) {
Why .dep_map? Does this compile?
Yes, it compiles.
Alternatively, it can be lockdep_is_held(ibp->rvp.lock).
Please refer to the macro(link below) and let me know if the usage of lock_is_held()
in the patch is correct.
https://elixir.bootlin.com/linux/v5.5-rc2/source/include/linux/lockdep.h#L364
Thanks,
Madhuparna
Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: madhuparnabhowmik04@gmail.com
Cc: dennis.dalessandro@intel.com, mike.marciniszyn@intel.com,
dledford@redhat.com, paulmck@kernel.org, rcu@vger.kernel.org,
joel@joelfernandes.org, frextrite@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
Date: Tue, 7 Jan 2020 16:33:54 -0400 [thread overview]
Message-ID: <20200107203354.GD26174@ziepe.ca> (raw)
In-Reply-To: <20200107192912.22691-1-madhuparnabhowmik04@gmail.com>
On Wed, Jan 08, 2020 at 12:59:12AM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..e6abdbcb4ffb 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
> opa_get_lid(packet->dlid, 9B));
> if (!mcast)
> goto drop;
> - list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> + list_for_each_entry_rcu(p, &mcast->qp_list, list,
> + lock_is_held(&(ibp->rvp.lock).dep_map)) {
Why .dep_map? Does this compile?
Jason
next prev parent reply other threads:[~2020-01-07 20:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 19:29 [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking madhuparnabhowmik04
2020-01-07 19:29 ` madhuparnabhowmik04
2020-01-07 20:33 ` Jason Gunthorpe [this message]
2020-01-08 8:08 ` [Linux-kernel-mentees] " madhuparnabhowmik04
2020-01-08 8:05 ` madhuparnabhowmik04
2020-01-07 20:33 ` Jason Gunthorpe
2020-01-09 18:10 ` [Linux-kernel-mentees] " Jason Gunthorpe
2020-01-09 18:10 ` Jason Gunthorpe
2020-01-10 15:54 ` [Linux-kernel-mentees] " Joel Fernandes
2020-01-10 15:54 ` Joel Fernandes
-- strict thread matches above, loose matches on Subject: below --
2020-01-14 16:23 [Linux-kernel-mentees] " madhuparnabhowmik04
2020-01-14 16:57 ` Jason Gunthorpe
2020-01-14 17:00 ` Dennis Dalessandro
2020-01-14 18:24 ` Dennis Dalessandro
2020-01-14 18:34 ` madhuparnabhowmik04
2020-01-14 19:17 ` Joel Fernandes
2020-01-14 19:41 ` Jason Gunthorpe
2020-01-14 19:46 ` Dennis Dalessandro
2020-02-14 15:43 ` Madhuparna Bhowmik
2020-02-14 17:24 ` Dennis Dalessandro
2020-02-14 17:32 ` Madhuparna Bhowmik
2020-01-07 17:35 madhuparnabhowmik04
2020-01-07 18:26 ` Jason Gunthorpe
2020-01-07 18:35 ` Madhuparna Bhowmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107203354.GD26174@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=mike.marciniszyn@intel.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.