* [Buildroot] [PATCH 1/1] package/exim: fix host build
@ 2020-01-04 21:34 Bernd Kuhls
2020-01-07 15:32 ` Luca Ceresoli
2020-01-08 8:36 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2020-01-04 21:34 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/5a7/5a765f0e65e20266c7203412a46c684a40b66ea3/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
Locally I cannot reproduce the problem, hopefully this patch will fix
the problem.
package/exim/exim.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/exim/exim.mk b/package/exim/exim.mk
index 118ee4a1a4..1f814ef195 100644
--- a/package/exim/exim.mk
+++ b/package/exim/exim.mk
@@ -125,7 +125,7 @@ define EXIM_BUILD_CMDS
$(HOST_MAKE_ENV) $(MAKE1) -C $(@D)/build-br macro_predef \
CC=$(HOSTCC) \
LNCC=$(HOSTCC) \
- CFLAGS="$(HOST_CFLAGS)" \
+ CFLAGS="-std=c99 $(HOST_CFLAGS)" \
LFLAGS="-fPIC $(HOST_LDFLAGS)"
$(TARGET_MAKE_ENV) build=br $(MAKE1) -C $(@D) $(EXIM_STATIC_FLAGS)
endef
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/exim: fix host build
2020-01-04 21:34 [Buildroot] [PATCH 1/1] package/exim: fix host build Bernd Kuhls
@ 2020-01-07 15:32 ` Luca Ceresoli
2020-01-08 8:36 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2020-01-07 15:32 UTC (permalink / raw)
To: buildroot
Hi Bernd,
On 04/01/20 22:34, Bernd Kuhls wrote:
> Fixes:
> http://autobuild.buildroot.net/results/5a7/5a765f0e65e20266c7203412a46c684a40b66ea3/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> Locally I cannot reproduce the problem, hopefully this patch will fix
> the problem.
I also tried to reproduce the issue locally, but on my host (Ubuntu
18.04) all the builds succeed.
> package/exim/exim.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/exim/exim.mk b/package/exim/exim.mk
> index 118ee4a1a4..1f814ef195 100644
> --- a/package/exim/exim.mk
> +++ b/package/exim/exim.mk
> @@ -125,7 +125,7 @@ define EXIM_BUILD_CMDS
> $(HOST_MAKE_ENV) $(MAKE1) -C $(@D)/build-br macro_predef \
> CC=$(HOSTCC) \
> LNCC=$(HOSTCC) \
> - CFLAGS="$(HOST_CFLAGS)" \
> + CFLAGS="-std=c99 $(HOST_CFLAGS)" \
Applying your patch the builds still work, as expected. Then I tried to
pass -std=c90 instead of c99, and bang, they started failing! So I also
assume your patch solves the failure.
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/exim: fix host build
2020-01-04 21:34 [Buildroot] [PATCH 1/1] package/exim: fix host build Bernd Kuhls
2020-01-07 15:32 ` Luca Ceresoli
@ 2020-01-08 8:36 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-01-08 8:36 UTC (permalink / raw)
To: buildroot
On Sat, 4 Jan 2020 22:34:59 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/5a7/5a765f0e65e20266c7203412a46c684a40b66ea3/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> Locally I cannot reproduce the problem, hopefully this patch will fix
> the problem.
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-08 8:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-04 21:34 [Buildroot] [PATCH 1/1] package/exim: fix host build Bernd Kuhls
2020-01-07 15:32 ` Luca Ceresoli
2020-01-08 8:36 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.