All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
@ 2020-01-08 10:10 Marco Felsch
  2020-01-08 10:10 ` [PATCH v2 2/3] ARM: dts: imx6: phycore-som: fix emmc supply Marco Felsch
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Marco Felsch @ 2020-01-08 10:10 UTC (permalink / raw)
  To: robh+dt, shawnguo, festevam, linux-imx, c.hemp, s.christ,
	chf.fritz, s.riedmueller
  Cc: kernel, linux-arm-kernel

The current set minimum voltage of 730000mV seems to be wrong. I don't
know the document which specifies that but the imx6qdl datasheets says
that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).

Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v2:
- use ldo bypassed values
- adapt commit message

 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index 6486df3e2942..f23eef1e54e0 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -107,14 +107,14 @@
 		regulators {
 			vdd_arm: buck1 {
 				regulator-name = "vdd_arm";
-				regulator-min-microvolt = <730000>;
+				regulator-min-microvolt = <925000>;
 				regulator-max-microvolt = <1380000>;
 				regulator-always-on;
 			};
 
 			vdd_soc: buck2 {
 				regulator-name = "vdd_soc";
-				regulator-min-microvolt = <730000>;
+				regulator-min-microvolt = <1150000>;
 				regulator-max-microvolt = <1380000>;
 				regulator-always-on;
 			};
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/3] ARM: dts: imx6: phycore-som: fix emmc supply
  2020-01-08 10:10 [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
@ 2020-01-08 10:10 ` Marco Felsch
  2020-01-08 10:10 ` [PATCH v2 3/3] ARM: dts: imx6: phycore-som: add pmic onkey device Marco Felsch
  2020-01-08 10:34 ` [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Russell King - ARM Linux admin
  2 siblings, 0 replies; 5+ messages in thread
From: Marco Felsch @ 2020-01-08 10:10 UTC (permalink / raw)
  To: robh+dt, shawnguo, festevam, linux-imx, c.hemp, s.christ,
	chf.fritz, s.riedmueller
  Cc: kernel, linux-arm-kernel

Currently the vmmc is supplied by the 1.8V pmic rail but this is wrong.
On a default module VCCQ and VCC are powered by the 3.3V power rail and
the user can optional connect the VCCQ to the pmic 1.8V emmc power rail
using a solder jumper.

Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v2:
- remove all supplies references because per default the emmc is
  powered by the 3.3V power rail.
- adapt commit message

 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index f23eef1e54e0..31fa37d2fe47 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -183,7 +183,6 @@
 	pinctrl-0 = <&pinctrl_usdhc4>;
 	bus-width = <8>;
 	non-removable;
-	vmmc-supply = <&vdd_emmc_1p8>;
 	status = "disabled";
 };
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 3/3] ARM: dts: imx6: phycore-som: add pmic onkey device
  2020-01-08 10:10 [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
  2020-01-08 10:10 ` [PATCH v2 2/3] ARM: dts: imx6: phycore-som: fix emmc supply Marco Felsch
@ 2020-01-08 10:10 ` Marco Felsch
  2020-01-08 10:34 ` [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Russell King - ARM Linux admin
  2 siblings, 0 replies; 5+ messages in thread
From: Marco Felsch @ 2020-01-08 10:10 UTC (permalink / raw)
  To: robh+dt, shawnguo, festevam, linux-imx, c.hemp, s.christ,
	chf.fritz, s.riedmueller
  Cc: kernel, linux-arm-kernel

Without the onkey device it isn't possible to power off the system using
the X_PMIC_nONKEY signal which is routed to the SoM pin header.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
v2:
- no changes

 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index 31fa37d2fe47..0e7f452dfb81 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -100,6 +100,10 @@
 			compatible = "dlg,da9062-rtc";
 		};
 
+		da9062_onkey: onkey {
+			compatible = "dlg,da9062-onkey";
+		};
+
 		watchdog {
 			compatible = "dlg,da9062-watchdog";
 		};
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
  2020-01-08 10:10 [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
  2020-01-08 10:10 ` [PATCH v2 2/3] ARM: dts: imx6: phycore-som: fix emmc supply Marco Felsch
  2020-01-08 10:10 ` [PATCH v2 3/3] ARM: dts: imx6: phycore-som: add pmic onkey device Marco Felsch
@ 2020-01-08 10:34 ` Russell King - ARM Linux admin
  2020-01-08 10:42   ` Marco Felsch
  2 siblings, 1 reply; 5+ messages in thread
From: Russell King - ARM Linux admin @ 2020-01-08 10:34 UTC (permalink / raw)
  To: Marco Felsch
  Cc: s.riedmueller, s.christ, chf.fritz, robh+dt, linux-imx, kernel,
	c.hemp, shawnguo, festevam, linux-arm-kernel

On Wed, Jan 08, 2020 at 11:10:55AM +0100, Marco Felsch wrote:
> The current set minimum voltage of 730000mV seems to be wrong. I don't

mV = milli-volt, /1000th of a volt. So you just said 730V.
µV or uV = micro-volt, which I think is what you mean here.

> know the document which specifies that but the imx6qdl datasheets says
> that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
> 
> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> v2:
> - use ldo bypassed values
> - adapt commit message
> 
>  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index 6486df3e2942..f23eef1e54e0 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -107,14 +107,14 @@
>  		regulators {
>  			vdd_arm: buck1 {
>  				regulator-name = "vdd_arm";
> -				regulator-min-microvolt = <730000>;
> +				regulator-min-microvolt = <925000>;
>  				regulator-max-microvolt = <1380000>;
>  				regulator-always-on;
>  			};
>  
>  			vdd_soc: buck2 {
>  				regulator-name = "vdd_soc";
> -				regulator-min-microvolt = <730000>;
> +				regulator-min-microvolt = <1150000>;
>  				regulator-max-microvolt = <1380000>;
>  				regulator-always-on;
>  			};
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
  2020-01-08 10:34 ` [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Russell King - ARM Linux admin
@ 2020-01-08 10:42   ` Marco Felsch
  0 siblings, 0 replies; 5+ messages in thread
From: Marco Felsch @ 2020-01-08 10:42 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: s.riedmueller, s.christ, chf.fritz, robh+dt, linux-imx, kernel,
	c.hemp, shawnguo, festevam, linux-arm-kernel

On 20-01-08 10:34, Russell King - ARM Linux admin wrote:
> On Wed, Jan 08, 2020 at 11:10:55AM +0100, Marco Felsch wrote:
> > The current set minimum voltage of 730000mV seems to be wrong. I don't
> 
> mV = milli-volt, /1000th of a volt. So you just said 730V.
> µV or uV = micro-volt, which I think is what you mean here.

Arg.. you are right thanks for covering that.

> > know the document which specifies that but the imx6qdl datasheets says
> > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
> > 
> > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> > v2:
> > - use ldo bypassed values
> > - adapt commit message
> > 
> >  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > index 6486df3e2942..f23eef1e54e0 100644
> > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > @@ -107,14 +107,14 @@
> >  		regulators {
> >  			vdd_arm: buck1 {
> >  				regulator-name = "vdd_arm";
> > -				regulator-min-microvolt = <730000>;
> > +				regulator-min-microvolt = <925000>;
> >  				regulator-max-microvolt = <1380000>;
> >  				regulator-always-on;
> >  			};
> >  
> >  			vdd_soc: buck2 {
> >  				regulator-name = "vdd_soc";
> > -				regulator-min-microvolt = <730000>;
> > +				regulator-min-microvolt = <1150000>;
> >  				regulator-max-microvolt = <1380000>;
> >  				regulator-always-on;
> >  			};
> > -- 
> > 2.20.1
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> > 
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-01-08 10:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-08 10:10 [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
2020-01-08 10:10 ` [PATCH v2 2/3] ARM: dts: imx6: phycore-som: fix emmc supply Marco Felsch
2020-01-08 10:10 ` [PATCH v2 3/3] ARM: dts: imx6: phycore-som: add pmic onkey device Marco Felsch
2020-01-08 10:34 ` [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Russell King - ARM Linux admin
2020-01-08 10:42   ` Marco Felsch

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.