All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: virtio-fs-list <virtio-fs@redhat.com>
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Enable xattr support by default
Date: Wed, 8 Jan 2020 10:50:02 -0500	[thread overview]
Message-ID: <20200108155002.GE1995@redhat.com> (raw)
In-Reply-To: <CAOssrKdomzxQsMh3FeQYN+HdLt-MSoZOi_MnWAbbf3P=U8ToPA@mail.gmail.com>

On Wed, Jan 08, 2020 at 04:42:46PM +0100, Miklos Szeredi wrote:
> On Wed, Jan 8, 2020 at 4:24 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> >
> > Enable xattr support by default. Currently it is disabled by defaut
> > and that makes getfattr/setfattr fail in guest.
> 
> I think the reason this was disabled by default is that it's a
> significant performance hit for "ls" due to missing xattr caching.
> Not sure how much it affects other workloads.
> 

Aha... so this is intentional and not just an oversight. So maybe we can
leave it disabled by default for now and let people enable it as need be
(-o xattr).

Thanks
Vivek


  reply	other threads:[~2020-01-08 15:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 15:24 [Virtio-fs] [PATCH] virtiofsd: Enable xattr support by default Vivek Goyal
2020-01-08 15:42 ` Miklos Szeredi
2020-01-08 15:50   ` Vivek Goyal [this message]
2020-01-09 10:17     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200108155002.GE1995@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=mszeredi@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.