[Virtio-fs] [PATCH] virtiofsd: Enable xattr support by default

[Virtio-fs] [PATCH] virtiofsd: Enable xattr support by default

[Vivek Goyal]

Enable xattr support by default. Currently it is disabled by defaut
and that makes getfattr/setfattr fail in guest. 

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 contrib/virtiofsd/passthrough_ll.c |    1 +
 1 file changed, 1 insertion(+)

Index: qemu/contrib/virtiofsd/passthrough_ll.c
===================================================================
--- qemu.orig/contrib/virtiofsd/passthrough_ll.c	2020-01-08 10:10:08.762661288 -0500
+++ qemu/contrib/virtiofsd/passthrough_ll.c	2020-01-08 10:15:03.170488067 -0500
@@ -3096,6 +3096,7 @@ int main(int argc, char *argv[])
 	                      .writeback = 0,
 			      .posix_lock = 1,
 	                      .proc_self_fd = -1,
+			      .xattr = 1,
 	};
 	struct lo_map_elem *root_elem;
 	int ret = -1;

Re: [Virtio-fs] [PATCH] virtiofsd: Enable xattr support by default

[Miklos Szeredi]

On Wed, Jan 8, 2020 at 4:24 PM Vivek Goyal <vgoyal@redhat.com> wrote:
>
> Enable xattr support by default. Currently it is disabled by defaut
> and that makes getfattr/setfattr fail in guest.

I think the reason this was disabled by default is that it's a
significant performance hit for "ls" due to missing xattr caching.
Not sure how much it affects other workloads.

Thanks,
Miklos

Re: [Virtio-fs] [PATCH] virtiofsd: Enable xattr support by default

[Vivek Goyal]

On Wed, Jan 08, 2020 at 04:42:46PM +0100, Miklos Szeredi wrote:
> On Wed, Jan 8, 2020 at 4:24 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> >
> > Enable xattr support by default. Currently it is disabled by defaut
> > and that makes getfattr/setfattr fail in guest.
> 
> I think the reason this was disabled by default is that it's a
> significant performance hit for "ls" due to missing xattr caching.
> Not sure how much it affects other workloads.
> 

Aha... so this is intentional and not just an oversight. So maybe we can
leave it disabled by default for now and let people enable it as need be
(-o xattr).

Thanks
Vivek

Re: [Virtio-fs] [PATCH] virtiofsd: Enable xattr support by default

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

On Wed, Jan 08, 2020 at 10:50:02AM -0500, Vivek Goyal wrote:
> On Wed, Jan 08, 2020 at 04:42:46PM +0100, Miklos Szeredi wrote:
> > On Wed, Jan 8, 2020 at 4:24 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> > >
> > > Enable xattr support by default. Currently it is disabled by defaut
> > > and that makes getfattr/setfattr fail in guest.
> > 
> > I think the reason this was disabled by default is that it's a
> > significant performance hit for "ls" due to missing xattr caching.
> > Not sure how much it affects other workloads.
> > 
> 
> Aha... so this is intentional and not just an oversight. So maybe we can
> leave it disabled by default for now and let people enable it as need be
> (-o xattr).

I've added this issue to the virtio-fs issue tracker:

https://gitlab.com/virtio-fs/qemu/issues/15

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]