All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Airlie <airlied@linux.ie>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sean Paul <sean@poorly.run>,
	Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH] drm/drm_panel: fix export of drm_panel_of_backlight, try #3
Date: Wed, 8 Jan 2020 17:46:18 +0100	[thread overview]
Message-ID: <20200108164618.GA28588@ravnborg.org> (raw)
In-Reply-To: <CAK8P3a1FKOV=1No7Q0g1vF_NQmVHK+g0VOqzPL499Pxbbt1aPQ@mail.gmail.com>

Hi Arnd.

> > > All of this is just another hack until the backlight config usage is
> > > fixed for good. Do we really want to make this the example to copy paste
> > > wherever we hit the issue next?
> > >
> > > I'm not naking, but I'm not acking either.
> >
> > I will try to take a look at your old BACKLIGHT_CLASS_DEVICE patch this
> > weekend. I think we need that one fixed - and then we can have this mess
> > with "drm_panel_of_backlight" fixed in the right way.
> 
> I had also attempted to fix the larger mess around 'select' statements in DRM/FB
> around BACKLIGHT_CLASS_DEVICE  several times in the past, and even at
> some point sent a patch that was acked but never merged and later broke because
> of other changes.

Any chance you have the patch around or can dig up a pointer?
My google foo did not turn up anything.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jani Nikula <jani.nikula@intel.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sean Paul <sean@poorly.run>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Emil Velikov <emil.velikov@collabora.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/drm_panel: fix export of drm_panel_of_backlight, try #3
Date: Wed, 8 Jan 2020 17:46:18 +0100	[thread overview]
Message-ID: <20200108164618.GA28588@ravnborg.org> (raw)
In-Reply-To: <CAK8P3a1FKOV=1No7Q0g1vF_NQmVHK+g0VOqzPL499Pxbbt1aPQ@mail.gmail.com>

Hi Arnd.

> > > All of this is just another hack until the backlight config usage is
> > > fixed for good. Do we really want to make this the example to copy paste
> > > wherever we hit the issue next?
> > >
> > > I'm not naking, but I'm not acking either.
> >
> > I will try to take a look at your old BACKLIGHT_CLASS_DEVICE patch this
> > weekend. I think we need that one fixed - and then we can have this mess
> > with "drm_panel_of_backlight" fixed in the right way.
> 
> I had also attempted to fix the larger mess around 'select' statements in DRM/FB
> around BACKLIGHT_CLASS_DEVICE  several times in the past, and even at
> some point sent a patch that was acked but never merged and later broke because
> of other changes.

Any chance you have the patch around or can dig up a pointer?
My google foo did not turn up anything.

	Sam

  reply	other threads:[~2020-01-08 16:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 20:32 [PATCH] drm/drm_panel: fix export of drm_panel_of_backlight, try #3 Arnd Bergmann
2020-01-07 20:32 ` Arnd Bergmann
2020-01-08  9:55 ` Jani Nikula
2020-01-08  9:55   ` Jani Nikula
2020-01-08 10:08   ` Sam Ravnborg
2020-01-08 10:08     ` Sam Ravnborg
2020-01-08 10:33     ` Arnd Bergmann
2020-01-08 10:33       ` Arnd Bergmann
2020-01-08 16:46       ` Sam Ravnborg [this message]
2020-01-08 16:46         ` Sam Ravnborg
2020-01-08 20:17         ` Arnd Bergmann
2020-01-08 20:17           ` Arnd Bergmann
2020-01-12 20:22 ` Sam Ravnborg
2020-01-12 20:22   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200108164618.GA28588@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    --cc=jani.nikula@intel.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=rdunlap@infradead.org \
    --cc=sean@poorly.run \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.