From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Will Deacon <will@kernel.org>
Cc: pasha.tatashin@soleen.com, catalin.marinas@arm.com,
bhsharma@redhat.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
james.morse@arm.com, frowand.list@gmail.com,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: kexec_file: add crash dump support
Date: Thu, 9 Jan 2020 09:46:55 +0900 [thread overview]
Message-ID: <20200109004654.GA28530@linaro.org> (raw)
In-Reply-To: <20200108174839.GB21242@willie-the-truck>
On Wed, Jan 08, 2020 at 05:48:39PM +0000, Will Deacon wrote:
> On Mon, Dec 16, 2019 at 11:12:47AM +0900, AKASHI Takahiro wrote:
> > Enabling crash dump (kdump) includes
> > * prepare contents of ELF header of a core dump file, /proc/vmcore,
> > using crash_prepare_elf64_headers(), and
> > * add two device tree properties, "linux,usable-memory-range" and
> > "linux,elfcorehdr", which represent respectively a memory range
> > to be used by crash dump kernel and the header's location
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will.deacon@arm.com>
> > Reviewed-by: James Morse <james.morse@arm.com>
> > Tested-and-reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
> > ---
> > arch/arm64/include/asm/kexec.h | 4 +
> > arch/arm64/kernel/kexec_image.c | 4 -
> > arch/arm64/kernel/machine_kexec_file.c | 106 ++++++++++++++++++++++++-
> > 3 files changed, 106 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h
> > index 12a561a54128..d24b527e8c00 100644
> > --- a/arch/arm64/include/asm/kexec.h
> > +++ b/arch/arm64/include/asm/kexec.h
> > @@ -96,6 +96,10 @@ static inline void crash_post_resume(void) {}
> > struct kimage_arch {
> > void *dtb;
> > unsigned long dtb_mem;
> > + /* Core ELF header buffer */
> > + void *elf_headers;
> > + unsigned long elf_headers_mem;
> > + unsigned long elf_headers_sz;
> > };
>
> This conflicts with the cleanup work from Pavel. Please can you check my
> resolution? [1]
I don't know why we need to change a type of dtb_mem,
otherwise it looks good.
(I also assume that you notice that kimage_arch is of no use for kexec.)
Thank you for the merge,
-Takahiro Akashi
> Will
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/diff/?h=for-kernelci&id=aef73191765a88cadc0a627cdc070e5a0086b015
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Will Deacon <will@kernel.org>
Cc: pasha.tatashin@soleen.com, catalin.marinas@arm.com,
will.deacon@arm.com, robh+dt@kernel.org, frowand.list@gmail.com,
bhsharma@redhat.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: kexec_file: add crash dump support
Date: Thu, 9 Jan 2020 09:46:55 +0900 [thread overview]
Message-ID: <20200109004654.GA28530@linaro.org> (raw)
In-Reply-To: <20200108174839.GB21242@willie-the-truck>
On Wed, Jan 08, 2020 at 05:48:39PM +0000, Will Deacon wrote:
> On Mon, Dec 16, 2019 at 11:12:47AM +0900, AKASHI Takahiro wrote:
> > Enabling crash dump (kdump) includes
> > * prepare contents of ELF header of a core dump file, /proc/vmcore,
> > using crash_prepare_elf64_headers(), and
> > * add two device tree properties, "linux,usable-memory-range" and
> > "linux,elfcorehdr", which represent respectively a memory range
> > to be used by crash dump kernel and the header's location
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will.deacon@arm.com>
> > Reviewed-by: James Morse <james.morse@arm.com>
> > Tested-and-reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
> > ---
> > arch/arm64/include/asm/kexec.h | 4 +
> > arch/arm64/kernel/kexec_image.c | 4 -
> > arch/arm64/kernel/machine_kexec_file.c | 106 ++++++++++++++++++++++++-
> > 3 files changed, 106 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h
> > index 12a561a54128..d24b527e8c00 100644
> > --- a/arch/arm64/include/asm/kexec.h
> > +++ b/arch/arm64/include/asm/kexec.h
> > @@ -96,6 +96,10 @@ static inline void crash_post_resume(void) {}
> > struct kimage_arch {
> > void *dtb;
> > unsigned long dtb_mem;
> > + /* Core ELF header buffer */
> > + void *elf_headers;
> > + unsigned long elf_headers_mem;
> > + unsigned long elf_headers_sz;
> > };
>
> This conflicts with the cleanup work from Pavel. Please can you check my
> resolution? [1]
I don't know why we need to change a type of dtb_mem,
otherwise it looks good.
(I also assume that you notice that kimage_arch is of no use for kexec.)
Thank you for the merge,
-Takahiro Akashi
> Will
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/diff/?h=for-kernelci&id=aef73191765a88cadc0a627cdc070e5a0086b015
>
next prev parent reply other threads:[~2020-01-09 0:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 2:12 [PATCH v4 0/2] arm64: kexec_file: add kdump AKASHI Takahiro
2019-12-16 2:12 ` AKASHI Takahiro
2019-12-16 2:12 ` AKASHI Takahiro
2019-12-16 2:12 ` [PATCH v4 1/2] libfdt: include fdt_addresses.c AKASHI Takahiro
2019-12-16 2:12 ` AKASHI Takahiro
2019-12-16 2:12 ` AKASHI Takahiro
2019-12-16 2:12 ` [PATCH v4 2/2] arm64: kexec_file: add crash dump support AKASHI Takahiro
2019-12-16 2:12 ` AKASHI Takahiro
2019-12-16 2:12 ` AKASHI Takahiro
2020-01-08 17:48 ` Will Deacon
2020-01-08 17:48 ` Will Deacon
2020-01-08 17:58 ` Pavel Tatashin
2020-01-08 17:58 ` Pavel Tatashin
2020-01-09 0:46 ` AKASHI Takahiro [this message]
2020-01-09 0:46 ` AKASHI Takahiro
2020-01-09 8:32 ` Will Deacon
2020-01-09 8:32 ` Will Deacon
2020-01-10 16:05 ` Will Deacon
2020-01-10 16:05 ` Will Deacon
2020-01-10 16:19 ` Pavel Tatashin
2020-01-10 16:19 ` Pavel Tatashin
2020-01-13 11:21 ` Will Deacon
2020-01-13 11:21 ` Will Deacon
2020-01-14 5:38 ` AKASHI Takahiro
2020-01-14 5:38 ` AKASHI Takahiro
2020-01-16 18:08 ` Will Deacon
2020-01-16 18:08 ` Will Deacon
2020-01-17 6:38 ` AKASHI Takahiro
2020-01-17 6:38 ` AKASHI Takahiro
2020-01-17 12:45 ` Will Deacon
2020-01-17 12:45 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109004654.GA28530@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=frowand.list@gmail.com \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.