From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] hw/smbios/smbios: Remove unused include
Date: Thu, 9 Jan 2020 06:36:56 -0500 [thread overview]
Message-ID: <20200109063646-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200109112504.32622-1-philmd@redhat.com>
On Thu, Jan 09, 2020 at 12:25:04PM +0100, Philippe Mathieu-Daudé wrote:
> Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/smbios/smbios.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
> index ded5f1f4e2..1a0f461541 100644
> --- a/hw/smbios/smbios.c
> +++ b/hw/smbios/smbios.c
> @@ -24,7 +24,6 @@
> #include "qemu/option.h"
> #include "sysemu/sysemu.h"
> #include "qemu/uuid.h"
> -#include "sysemu/cpus.h"
> #include "hw/firmware/smbios.h"
> #include "hw/loader.h"
> #include "hw/boards.h"
> --
> 2.21.1
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-trivial@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/smbios/smbios: Remove unused include
Date: Thu, 9 Jan 2020 06:36:56 -0500 [thread overview]
Message-ID: <20200109063646-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200109112504.32622-1-philmd@redhat.com>
On Thu, Jan 09, 2020 at 12:25:04PM +0100, Philippe Mathieu-Daudé wrote:
> Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/smbios/smbios.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
> index ded5f1f4e2..1a0f461541 100644
> --- a/hw/smbios/smbios.c
> +++ b/hw/smbios/smbios.c
> @@ -24,7 +24,6 @@
> #include "qemu/option.h"
> #include "sysemu/sysemu.h"
> #include "qemu/uuid.h"
> -#include "sysemu/cpus.h"
> #include "hw/firmware/smbios.h"
> #include "hw/loader.h"
> #include "hw/boards.h"
> --
> 2.21.1
next prev parent reply other threads:[~2020-01-09 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 11:25 [PATCH] hw/smbios/smbios: Remove unused include Philippe Mathieu-Daudé
2020-01-09 11:25 ` Philippe Mathieu-Daudé
2020-01-09 11:36 ` Michael S. Tsirkin [this message]
2020-01-09 11:36 ` Michael S. Tsirkin
2020-02-06 9:39 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109063646-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=imammedo@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.