From: Shawn Guo <shawnguo@kernel.org>
To: Aapo Vienamo <aapo.vienamo@iki.fi>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: mxs: Enable usbphy1 and usb1 on apx4devkit DTS
Date: Thu, 9 Jan 2020 15:58:33 +0800 [thread overview]
Message-ID: <20200109075832.GG4456@T480> (raw)
In-Reply-To: <20191229131503.20843-1-aapo.vienamo@iki.fi>
On Sun, Dec 29, 2019 at 03:15:03PM +0200, Aapo Vienamo wrote:
> Enable the USB host port on the APx4 development board.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
> ---
> arch/arm/boot/dts/imx28-apx4devkit.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx28-apx4devkit.dts b/arch/arm/boot/dts/imx28-apx4devkit.dts
> index 3a184d13887b..f00d201ce242 100644
> --- a/arch/arm/boot/dts/imx28-apx4devkit.dts
> +++ b/arch/arm/boot/dts/imx28-apx4devkit.dts
> @@ -183,6 +183,12 @@ auart2: serial@8006e000 {
> pinctrl-0 = <&auart2_2pins_a>;
> status = "okay";
> };
> +
> + usbphy1: usbphy@8007e000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb1_pins_a>;
> + status = "okay";
> + };
> };
> };
>
> @@ -193,6 +199,10 @@ mac0: ethernet@800f0000 {
> pinctrl-0 = <&mac0_pins_a>;
> status = "okay";
> };
> +
> + usb1: usb@80090000 {
We want to keep nodes with unit-address sorted in that address. That
said, usb@80090000 should go before ethernet@800f0000.
Shawn
> + status = "okay";
> + };
> };
>
> regulators {
> --
> 2.24.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Aapo Vienamo <aapo.vienamo@iki.fi>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: mxs: Enable usbphy1 and usb1 on apx4devkit DTS
Date: Thu, 9 Jan 2020 15:58:33 +0800 [thread overview]
Message-ID: <20200109075832.GG4456@T480> (raw)
In-Reply-To: <20191229131503.20843-1-aapo.vienamo@iki.fi>
On Sun, Dec 29, 2019 at 03:15:03PM +0200, Aapo Vienamo wrote:
> Enable the USB host port on the APx4 development board.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
> ---
> arch/arm/boot/dts/imx28-apx4devkit.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx28-apx4devkit.dts b/arch/arm/boot/dts/imx28-apx4devkit.dts
> index 3a184d13887b..f00d201ce242 100644
> --- a/arch/arm/boot/dts/imx28-apx4devkit.dts
> +++ b/arch/arm/boot/dts/imx28-apx4devkit.dts
> @@ -183,6 +183,12 @@ auart2: serial@8006e000 {
> pinctrl-0 = <&auart2_2pins_a>;
> status = "okay";
> };
> +
> + usbphy1: usbphy@8007e000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb1_pins_a>;
> + status = "okay";
> + };
> };
> };
>
> @@ -193,6 +199,10 @@ mac0: ethernet@800f0000 {
> pinctrl-0 = <&mac0_pins_a>;
> status = "okay";
> };
> +
> + usb1: usb@80090000 {
We want to keep nodes with unit-address sorted in that address. That
said, usb@80090000 should go before ethernet@800f0000.
Shawn
> + status = "okay";
> + };
> };
>
> regulators {
> --
> 2.24.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-09 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 13:15 [PATCH] ARM: mxs: Enable usbphy1 and usb1 on apx4devkit DTS Aapo Vienamo
2019-12-29 13:15 ` Aapo Vienamo
2020-01-09 7:58 ` Shawn Guo [this message]
2020-01-09 7:58 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109075832.GG4456@T480 \
--to=shawnguo@kernel.org \
--cc=aapo.vienamo@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.