From: Kevin Wolf <kwolf@redhat.com>
To: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
Cc: peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru,
pbonzini@redhat.com, quintela@redhat.com,
ciro.santilli@gmail.com, jasowang@redhat.com,
crosthwaite.peter@gmail.com, qemu-devel@nongnu.org,
armbru@redhat.com, alex.bennee@linaro.org,
maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com,
boost.lists@gmail.com, thomas.dullien@googlemail.com,
dovgaluk@ispras.ru, mreitz@redhat.com,
artem.k.pisarenko@gmail.com, dgilbert@redhat.com,
rth@twiddle.net
Subject: Re: [for-5.0 PATCH 02/11] qcow2: introduce icount field for snapshots
Date: Thu, 9 Jan 2020 12:48:27 +0100 [thread overview]
Message-ID: <20200109114827.GB9504@linux.fritz.box> (raw)
In-Reply-To: <157709439859.12933.3023824005902199560.stgit@pasha-Precision-3630-Tower>
Am 23.12.2019 um 10:46 hat Pavel Dovgalyuk geschrieben:
> From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
>
> This patch introduces the icount field for saving within the snapshot.
> It is required for navigation between the snapshots in record/replay mode.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
> Acked-by: Kevin Wolf <kwolf@redhat.com>
> diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
> index af5711e533..aa9d447cda 100644
> --- a/docs/interop/qcow2.txt
> +++ b/docs/interop/qcow2.txt
> @@ -584,6 +584,10 @@ Snapshot table entry:
>
> Byte 48 - 55: Virtual disk size of the snapshot in bytes
>
> + Byte 56 - 63: icount value which corresponds to
> + the record/replay instruction count
> + when the snapshot was taken
> +
In the context of the next patch, I noticed that we should probably also
mention that -1ULL means "invalid".
Kevin
next prev parent reply other threads:[~2020-01-09 11:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 9:45 [for-5.0 PATCH 00/11] Support for reverse debugging with GDB Pavel Dovgalyuk
2019-12-23 9:46 ` [for-5.0 PATCH 01/11] replay: provide an accessor for rr filename Pavel Dovgalyuk
2019-12-23 9:46 ` [for-5.0 PATCH 02/11] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2020-01-09 11:48 ` Kevin Wolf [this message]
2019-12-23 9:47 ` [for-5.0 PATCH 03/11] migration: " Pavel Dovgalyuk
2020-01-09 11:59 ` Kevin Wolf
2020-01-13 17:11 ` Alex Bennée
2020-01-14 9:32 ` Pavel Dovgalyuk
2019-12-23 9:47 ` [for-5.0 PATCH 04/11] qapi: introduce replay.json for record/replay-related stuff Pavel Dovgalyuk
2019-12-23 9:47 ` [for-5.0 PATCH 05/11] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2020-01-09 12:23 ` Alex Bennée
2020-01-09 12:27 ` Pavel Dovgalyuk
2019-12-23 9:47 ` [for-5.0 PATCH 06/11] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2019-12-23 9:47 ` [for-5.0 PATCH 07/11] replay: implement replay-seek command Pavel Dovgalyuk
2019-12-23 9:48 ` [for-5.0 PATCH 08/11] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2020-01-13 17:48 ` Alex Bennée
2020-01-14 13:57 ` Pavel Dovgalyuk
2019-12-23 9:48 ` [for-5.0 PATCH 09/11] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2019-12-23 9:48 ` [for-5.0 PATCH 10/11] gdbstub: add reverse continue " Pavel Dovgalyuk
2019-12-23 9:48 ` [for-5.0 PATCH 11/11] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2020-01-09 6:13 ` [for-5.0 PATCH 00/11] Support for reverse debugging with GDB Pavel Dovgalyuk
2020-01-09 12:00 ` Kevin Wolf
2020-01-09 12:12 ` Pavel Dovgalyuk
2020-01-13 9:29 ` Markus Armbruster
2020-01-13 9:35 ` Pavel Dovgalyuk
2020-01-13 10:06 ` Kevin Wolf
2020-01-13 10:14 ` Peter Maydell
2020-01-13 10:27 ` Kevin Wolf
2020-01-13 10:47 ` Peter Maydell
2020-01-13 17:55 ` Alex Bennée
2020-01-16 11:11 ` Alex Bennée
2020-01-16 11:26 ` Pavel Dovgalyuk
2020-01-17 17:40 ` Alex Bennée
2020-01-20 11:58 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109114827.GB9504@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=artem.k.pisarenko@gmail.com \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pavel.dovgaluk@gmail.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=thomas.dullien@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.