From: "Alex Bennée" <alex.bennee@linaro.org>
To: Kevin Wolf <kwolf@redhat.com>
Cc: peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru,
pbonzini@redhat.com, crosthwaite.peter@gmail.com,
ciro.santilli@gmail.com, jasowang@redhat.com,
quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>,
maria.klimushenkova@ispras.ru, mst@redhat.com, kraxel@redhat.com,
boost.lists@gmail.com, thomas.dullien@googlemail.com,
dovgaluk@ispras.ru, mreitz@redhat.com,
artem.k.pisarenko@gmail.com, dgilbert@redhat.com,
rth@twiddle.net
Subject: Re: [for-5.0 PATCH 03/11] migration: introduce icount field for snapshots
Date: Mon, 13 Jan 2020 17:11:05 +0000 [thread overview]
Message-ID: <878smbnuxi.fsf@linaro.org> (raw)
In-Reply-To: <20200109115918.GC9504@linux.fritz.box>
Kevin Wolf <kwolf@redhat.com> writes:
> Am 23.12.2019 um 10:47 hat Pavel Dovgalyuk geschrieben:
>> From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
>>
>> Saving icount as a parameters of the snapshot allows navigation between
>> them in the execution replay scenario.
>> This information can be used for finding a specific snapshot for proceeding
>> the recorded execution to the specific moment of the time.
>> E.g., 'reverse step' action (introduced in one of the following patches)
>> needs to load the nearest snapshot which is prior to the current moment
>> of time.
>>
>> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
>> Acked-by: Markus Armbruster <armbru@redhat.com>
>
> Acked-by: Kevin Wolf <kwolf@redhat.com>
Apologies my mailer ignored my replay-all:
This commit breaks when of the iotests for me:
git bisect run /bin/sh -c "cd builds/all && make -j4 \
&& cd tests/qemu-iotests && ./check -qcow2 267"
Gives:
make[1]: Entering directory '/home/alex.bennee/lsrc/qemu.git/slirp'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/alex.bennee/lsrc/qemu.git/slirp'
QEMU -- "/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nodefaults -display none -accel qtest
QEMU_IMG -- "/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/../../qemu-img"
QEMU_IO -- "/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/../../qemu-io" --cache writeback -f qcow2
QEMU_NBD -- "/home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- qcow2 (compat=1.1)
IMGPROTO -- file
PLATFORM -- Linux/x86_64 hackbox2 4.15.0-66-generic
TEST_DIR -- /home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmp.NV0n5HqCUs
SOCKET_SCM_HELPER -- /home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/socket_scm_helper
267 fail [12:17:36] [12:17:38] (last: 1s) output mismatch (see 267.out.bad)
--- /home/alex.bennee/lsrc/qemu.git/tests/qemu-iotests/267.out 2019-10-31 10:46:30.559805129 +0000
+++ /home/alex.bennee/lsrc/qemu.git/builds/all/tests/qemu-iotests/267.out.bad 2020-01-13 12:17:38.096181947 +0000
@@ -33,7 +33,7 @@
(qemu) savevm snap0
(qemu) info snapshots
List of snapshots present on all disks:
-ID TAG VM SIZE DATE VM CLOCK
+ID TAG VM SIZE DATE VM CLOCK ICOUNT
-- snap0 SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000
(qemu) loadvm snap0
(qemu) quit
@@ -44,7 +44,7 @@
(qemu) savevm snap0
(qemu) info snapshots
List of snapshots present on all disks:
-ID TAG VM SIZE DATE VM CLOCK
+ID TAG VM SIZE DATE VM CLOCK ICOUNT
But I've also seen:
ERROR:/home/.../qemu.git/replay/replay-events.c:80:replay_flush_events:
assertion failed: (replay_mutex_locked())
--
Alex Bennée
next prev parent reply other threads:[~2020-01-13 17:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 9:45 [for-5.0 PATCH 00/11] Support for reverse debugging with GDB Pavel Dovgalyuk
2019-12-23 9:46 ` [for-5.0 PATCH 01/11] replay: provide an accessor for rr filename Pavel Dovgalyuk
2019-12-23 9:46 ` [for-5.0 PATCH 02/11] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2020-01-09 11:48 ` Kevin Wolf
2019-12-23 9:47 ` [for-5.0 PATCH 03/11] migration: " Pavel Dovgalyuk
2020-01-09 11:59 ` Kevin Wolf
2020-01-13 17:11 ` Alex Bennée [this message]
2020-01-14 9:32 ` Pavel Dovgalyuk
2019-12-23 9:47 ` [for-5.0 PATCH 04/11] qapi: introduce replay.json for record/replay-related stuff Pavel Dovgalyuk
2019-12-23 9:47 ` [for-5.0 PATCH 05/11] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2020-01-09 12:23 ` Alex Bennée
2020-01-09 12:27 ` Pavel Dovgalyuk
2019-12-23 9:47 ` [for-5.0 PATCH 06/11] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2019-12-23 9:47 ` [for-5.0 PATCH 07/11] replay: implement replay-seek command Pavel Dovgalyuk
2019-12-23 9:48 ` [for-5.0 PATCH 08/11] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2020-01-13 17:48 ` Alex Bennée
2020-01-14 13:57 ` Pavel Dovgalyuk
2019-12-23 9:48 ` [for-5.0 PATCH 09/11] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2019-12-23 9:48 ` [for-5.0 PATCH 10/11] gdbstub: add reverse continue " Pavel Dovgalyuk
2019-12-23 9:48 ` [for-5.0 PATCH 11/11] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2020-01-09 6:13 ` [for-5.0 PATCH 00/11] Support for reverse debugging with GDB Pavel Dovgalyuk
2020-01-09 12:00 ` Kevin Wolf
2020-01-09 12:12 ` Pavel Dovgalyuk
2020-01-13 9:29 ` Markus Armbruster
2020-01-13 9:35 ` Pavel Dovgalyuk
2020-01-13 10:06 ` Kevin Wolf
2020-01-13 10:14 ` Peter Maydell
2020-01-13 10:27 ` Kevin Wolf
2020-01-13 10:47 ` Peter Maydell
2020-01-13 17:55 ` Alex Bennée
2020-01-16 11:11 ` Alex Bennée
2020-01-16 11:26 ` Pavel Dovgalyuk
2020-01-17 17:40 ` Alex Bennée
2020-01-20 11:58 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878smbnuxi.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=artem.k.pisarenko@gmail.com \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pavel.dovgaluk@gmail.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=thomas.dullien@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.