All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw,
	richard@nod.at, linux-kernel@vger.kernel.org,
	marek.vasut@gmail.com, robh+dt@kernel.org,
	linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
	dwmw2@infradead.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix NAND device bindings
Date: Thu, 9 Jan 2020 17:30:28 +0100	[thread overview]
Message-ID: <20200109173028.09de5f08@xps13> (raw)
In-Reply-To: <1571902807-10388-3-git-send-email-masonccyang@mxic.com.tw>

Hi Mason,

Mason Yang <masonccyang@mxic.com.tw> wrote on Thu, 24 Oct 2019 15:40:07
+0800:

> Document the bindings used by the Macronix NAND device.
> 
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
>  .../devicetree/bindings/mtd/nand-macronix.txt        | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/nand-macronix.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-macronix.txt b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
> new file mode 100644
> index 0000000..cb60358
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
> @@ -0,0 +1,20 @@
> +Macronix NANDs Device Tree Bindings
> +-----------------------------------
> +
> +Macronix NANDs support randomizer operation for user data scrambled,
> +which can be enabled with a SET_FEATURE. The penalty of randomizer
> +is subpage accesses prohibited. By adding a new specific property
> +in children nodes to enable randomizer function.

You don't mention the performance penalty nor the benefits of such
operation.

Please also insist on the fact that this is a one time persistent, non
reversible operation and the use should use this property only if they
know what they are doing!

> +
> +Required NAND chip properties in children mode:
> +- randomizer enable: should be "mxic,enable-randomizer-otp"
> +
> +Example:
> +
> +	nand: nand-controller@unit-address {
> +
> +		nand@0 {
> +			reg = <0>;
> +			mxic,enable-randomizer-otp;
> +		};
> +	};

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: richard@nod.at, marek.vasut@gmail.com, dwmw2@infradead.org,
	bbrezillon@kernel.org, computersforpeace@gmail.com,
	vigneshr@ti.com, robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, juliensu@mxic.com.tw,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix NAND device bindings
Date: Thu, 9 Jan 2020 17:30:28 +0100	[thread overview]
Message-ID: <20200109173028.09de5f08@xps13> (raw)
In-Reply-To: <1571902807-10388-3-git-send-email-masonccyang@mxic.com.tw>

Hi Mason,

Mason Yang <masonccyang@mxic.com.tw> wrote on Thu, 24 Oct 2019 15:40:07
+0800:

> Document the bindings used by the Macronix NAND device.
> 
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
>  .../devicetree/bindings/mtd/nand-macronix.txt        | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/nand-macronix.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-macronix.txt b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
> new file mode 100644
> index 0000000..cb60358
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
> @@ -0,0 +1,20 @@
> +Macronix NANDs Device Tree Bindings
> +-----------------------------------
> +
> +Macronix NANDs support randomizer operation for user data scrambled,
> +which can be enabled with a SET_FEATURE. The penalty of randomizer
> +is subpage accesses prohibited. By adding a new specific property
> +in children nodes to enable randomizer function.

You don't mention the performance penalty nor the benefits of such
operation.

Please also insist on the fact that this is a one time persistent, non
reversible operation and the use should use this property only if they
know what they are doing!

> +
> +Required NAND chip properties in children mode:
> +- randomizer enable: should be "mxic,enable-randomizer-otp"
> +
> +Example:
> +
> +	nand: nand-controller@unit-address {
> +
> +		nand@0 {
> +			reg = <0>;
> +			mxic,enable-randomizer-otp;
> +		};
> +	};

Thanks,
Miquèl

  parent reply	other threads:[~2020-01-09 16:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  7:40 [PATCH v4 0/2] mtd: rawnand: Add support Macronix NAND randomizer Mason Yang
2019-10-24  7:40 ` Mason Yang
2019-10-24  7:40 ` [PATCH v4 1/2] mtd: rawnand: Add support for " Mason Yang
2019-10-24  7:40   ` Mason Yang
2020-01-09 16:28   ` Miquel Raynal
2020-01-09 16:28     ` Miquel Raynal
2020-01-17  7:54     ` masonccyang
2020-01-17  7:54       ` masonccyang
2020-01-17  9:13       ` Miquel Raynal
2020-01-17  9:13         ` Miquel Raynal
2020-01-20  9:28         ` masonccyang
2020-01-20  9:28           ` masonccyang
2020-01-09 16:51   ` Miquel Raynal
2020-01-09 16:51     ` Miquel Raynal
2020-01-16  8:08     ` masonccyang
2020-01-16  8:08       ` masonccyang
2019-10-24  7:40 ` [PATCH v4 2/2] dt-bindings: mtd: Document Macronix NAND device bindings Mason Yang
2019-10-24  7:40   ` Mason Yang
2019-10-25 19:12   ` Rob Herring
2019-10-25 19:12     ` Rob Herring
2020-01-09 16:30   ` Miquel Raynal [this message]
2020-01-09 16:30     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200109173028.09de5f08@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=juliensu@mxic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.