From: Vinod Koul <vkoul@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Tony Lindgren <tony@atomide.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereferenced
Date: Fri, 10 Jan 2020 13:16:05 +0530 [thread overview]
Message-ID: <20200110074605.GD2818@vkoul-mobl> (raw)
In-Reply-To: <20200109131953.157154-1-colin.king@canonical.com>
On 09-01-20, 13:19, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently when the call to dev_get_platdata returns null the driver issues
> a warning and then later dereferences the null pointer. Avoid this issue
> by returning -ENODEV errror rather when the platform data is null and
s/errror/error :) never thought would correct Colin on spelling :)
With the typo fixes:
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Tony Lindgren <tony@atomide.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereference
Date: Fri, 10 Jan 2020 07:58:05 +0000 [thread overview]
Message-ID: <20200110074605.GD2818@vkoul-mobl> (raw)
In-Reply-To: <20200109131953.157154-1-colin.king@canonical.com>
On 09-01-20, 13:19, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently when the call to dev_get_platdata returns null the driver issues
> a warning and then later dereferences the null pointer. Avoid this issue
> by returning -ENODEV errror rather when the platform data is null and
s/errror/error :) never thought would correct Colin on spelling :)
With the typo fixes:
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
next prev parent reply other threads:[~2020-01-10 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 13:19 [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereferenced Colin King
2020-01-09 13:19 ` Colin King
2020-01-09 15:33 ` Peter Ujfalusi
2020-01-09 15:33 ` [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereference Peter Ujfalusi
2020-01-10 7:46 ` Vinod Koul [this message]
2020-01-10 7:58 ` Vinod Koul
2020-01-10 9:21 ` [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereferenced Colin Ian King
2020-01-10 9:21 ` [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereference Colin Ian King
2020-01-13 17:46 ` [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereferenced Tony Lindgren
2020-01-13 17:46 ` [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereference Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110074605.GD2818@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.