From: Amol Grover <frextrite@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Linux-kernel-mentees] [PATCH] drivers: nvme: target: core: Pass lockdep expression to RCU lists
Date: Fri, 10 Jan 2020 22:40:33 +0530 [thread overview]
Message-ID: <20200110171033.GA23748@workstation-kernel-dev> (raw)
In-Reply-To: <20200110163134.GA18579@redsun51.ssa.fujisawa.hgst.com>
On Sat, Jan 11, 2020 at 01:31:34AM +0900, Keith Busch wrote:
> On Fri, Jan 10, 2020 at 06:53:58PM +0530, Amol Grover wrote:
> > +#define subsys_lock_held() \
> > + lockdep_is_held(&subsys->lock)
>
> This macro requires "struct nvmet_subsys *subsys" was previously declared
> in the function using it, which isn't obvious when looking at the users. I
> don't think that's worth the conciseness.
>
Hey Keith,
If I understand correctly, you're saying `*subsys` is always declared in the
function using it, right? I too think, this could cause confusion to the person
going through the code, I'll fix it right away.
Thanks
Amol
> > @@ -555,7 +558,8 @@ int nvmet_ns_enable(struct nvmet_ns *ns)
> > } else {
> > struct nvmet_ns *old;
> >
> > - list_for_each_entry_rcu(old, &subsys->namespaces, dev_link) {
> > + list_for_each_entry_rcu(old, &subsys->namespaces, dev_link,
> > + subsys_lock_held()) {
> > BUG_ON(ns->nsid == old->nsid);
> > if (ns->nsid < old->nsid)
> > break;
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Amol Grover <frextrite@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Joel Fernandes <joel@joelfernandes.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Christoph Hellwig <hch@lst.de>,
Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
Subject: Re: [PATCH] drivers: nvme: target: core: Pass lockdep expression to RCU lists
Date: Fri, 10 Jan 2020 22:40:33 +0530 [thread overview]
Message-ID: <20200110171033.GA23748@workstation-kernel-dev> (raw)
In-Reply-To: <20200110163134.GA18579@redsun51.ssa.fujisawa.hgst.com>
On Sat, Jan 11, 2020 at 01:31:34AM +0900, Keith Busch wrote:
> On Fri, Jan 10, 2020 at 06:53:58PM +0530, Amol Grover wrote:
> > +#define subsys_lock_held() \
> > + lockdep_is_held(&subsys->lock)
>
> This macro requires "struct nvmet_subsys *subsys" was previously declared
> in the function using it, which isn't obvious when looking at the users. I
> don't think that's worth the conciseness.
>
Hey Keith,
If I understand correctly, you're saying `*subsys` is always declared in the
function using it, right? I too think, this could cause confusion to the person
going through the code, I'll fix it right away.
Thanks
Amol
> > @@ -555,7 +558,8 @@ int nvmet_ns_enable(struct nvmet_ns *ns)
> > } else {
> > struct nvmet_ns *old;
> >
> > - list_for_each_entry_rcu(old, &subsys->namespaces, dev_link) {
> > + list_for_each_entry_rcu(old, &subsys->namespaces, dev_link,
> > + subsys_lock_held()) {
> > BUG_ON(ns->nsid == old->nsid);
> > if (ns->nsid < old->nsid)
> > break;
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Amol Grover <frextrite@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Joel Fernandes <joel@joelfernandes.org>,
Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] drivers: nvme: target: core: Pass lockdep expression to RCU lists
Date: Fri, 10 Jan 2020 22:40:33 +0530 [thread overview]
Message-ID: <20200110171033.GA23748@workstation-kernel-dev> (raw)
In-Reply-To: <20200110163134.GA18579@redsun51.ssa.fujisawa.hgst.com>
On Sat, Jan 11, 2020 at 01:31:34AM +0900, Keith Busch wrote:
> On Fri, Jan 10, 2020 at 06:53:58PM +0530, Amol Grover wrote:
> > +#define subsys_lock_held() \
> > + lockdep_is_held(&subsys->lock)
>
> This macro requires "struct nvmet_subsys *subsys" was previously declared
> in the function using it, which isn't obvious when looking at the users. I
> don't think that's worth the conciseness.
>
Hey Keith,
If I understand correctly, you're saying `*subsys` is always declared in the
function using it, right? I too think, this could cause confusion to the person
going through the code, I'll fix it right away.
Thanks
Amol
> > @@ -555,7 +558,8 @@ int nvmet_ns_enable(struct nvmet_ns *ns)
> > } else {
> > struct nvmet_ns *old;
> >
> > - list_for_each_entry_rcu(old, &subsys->namespaces, dev_link) {
> > + list_for_each_entry_rcu(old, &subsys->namespaces, dev_link,
> > + subsys_lock_held()) {
> > BUG_ON(ns->nsid == old->nsid);
> > if (ns->nsid < old->nsid)
> > break;
next prev parent reply other threads:[~2020-01-10 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 13:23 [Linux-kernel-mentees] [PATCH] drivers: nvme: target: core: Pass lockdep expression to RCU lists Amol Grover
2020-01-10 13:23 ` Amol Grover
2020-01-10 13:23 ` Amol Grover
2020-01-10 15:47 ` [Linux-kernel-mentees] " Joel Fernandes
2020-01-10 15:47 ` Joel Fernandes
2020-01-10 15:47 ` Joel Fernandes
2020-01-10 16:31 ` [Linux-kernel-mentees] " Keith Busch
2020-01-10 16:31 ` Keith Busch
2020-01-10 16:31 ` Keith Busch
2020-01-10 17:10 ` Amol Grover [this message]
2020-01-10 17:10 ` Amol Grover
2020-01-10 17:10 ` Amol Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110171033.GA23748@workstation-kernel-dev \
--to=frextrite@gmail.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=joel@joelfernandes.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=paulmck@kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.