Re: [PATCH] input: max77650-onkey: add of_match table

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Dec 10, 2019 at 11:07:53AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> We need the of_match table if we want to use the compatible string in
> the pmic's child node and get the onkey driver loaded automatically.

Do we really need of_match table or adding

MODULE_ALIAS("platform:max77650-onkey");

will work as well?

In general, do we ever instantiate onkey portion from device tree? Or
is it always an MFD cell that is instantiated unconditionally?

> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  drivers/input/misc/max77650-onkey.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/misc/max77650-onkey.c b/drivers/input/misc/max77650-onkey.c
> index 4d875f2ac13d..ee55f22dbca5 100644
> --- a/drivers/input/misc/max77650-onkey.c
> +++ b/drivers/input/misc/max77650-onkey.c
> @@ -108,9 +108,16 @@ static int max77650_onkey_probe(struct platform_device *pdev)
>  	return input_register_device(onkey->input);
>  }
>  
> +static const struct of_device_id max77650_onkey_of_match[] = {
> +	{ .compatible = "maxim,max77650-onkey" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, max77650_onkey_of_match);
> +
>  static struct platform_driver max77650_onkey_driver = {
>  	.driver = {
>  		.name = "max77650-onkey",
> +		.of_match_table = max77650_onkey_of_match,
>  	},
>  	.probe = max77650_onkey_probe,
>  };
> -- 
> 2.23.0
> 

Thanks.

-- 
Dmitry