All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Input <linux-input@vger.kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH] input: max77650-onkey: add of_match table
Date: Thu, 16 Jan 2020 20:24:09 -0800	[thread overview]
Message-ID: <20200117042409.GE47797@dtor-ws> (raw)
In-Reply-To: <CAMRc=Mcu-oNC009JLkNSDrKjg_ygb63ZTnrmu+8NwNZrOVsEZQ@mail.gmail.com>

On Sat, Jan 11, 2020 at 11:22:55AM +0100, Bartosz Golaszewski wrote:
> pt., 10 sty 2020 o 19:28 Dmitry Torokhov <dmitry.torokhov@gmail.com> napisał(a):
> >
> > On Tue, Dec 10, 2019 at 11:07:53AM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > We need the of_match table if we want to use the compatible string in
> > > the pmic's child node and get the onkey driver loaded automatically.
> >
> > Do we really need of_match table or adding
> >
> 
> Not really. Technically not anyway but we merged bindings that define
> it (at the time I didn't know any better) and seems we're stuck with
> it. Please see the discussion below a similar patch for regulator
> subsystem[1].
> 
> > MODULE_ALIAS("platform:max77650-onkey");
> >
> 
> This is already in there, but if someone defines the compatible in the
> device tree as per bindings, the module won't be loaded despite the
> MODULE_ALIAS() definition.

I see. Applied, thank you.

-- 
Dmitry

      reply	other threads:[~2020-01-17  4:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 10:07 [PATCH] input: max77650-onkey: add of_match table Bartosz Golaszewski
2020-01-03 13:12 ` Bartosz Golaszewski
2020-01-10 13:06   ` Bartosz Golaszewski
2020-01-10 18:28 ` Dmitry Torokhov
2020-01-11 10:22   ` Bartosz Golaszewski
2020-01-17  4:24     ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117042409.GE47797@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=brgl@bgdev.pl \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.