From: Sam Ravnborg <sam@ravnborg.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH 0/6] dt-bindings: display: Update few panel bindings with YAML
Date: Fri, 10 Jan 2020 23:05:48 +0100 [thread overview]
Message-ID: <20200110220548.GB29600@ravnborg.org> (raw)
In-Reply-To: <CAMty3ZDbDf6YovrEdG0pACQAwMQidjKr6BJvx-FPXqyT11G05w@mail.gmail.com>
Hi Jagan.
On Mon, Jan 06, 2020 at 03:41:40PM +0530, Jagan Teki wrote:
> Hi Sam,
>
> On Sat, Jan 4, 2020 at 8:47 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Jagan.
> > On Wed, Jan 01, 2020 at 04:54:38PM +0530, Jagan Teki wrote:
> > > These panel bindings are owned by me, so updated all of them into
> > > YAML DT schema.
> > >
> > > Any inputs?
> > Thanks for doing the conversion.
> >
> > dt_binding_check was not happy:
> > Documentation/devicetree/bindings/display/panel/rocktech,rk070er9427.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+'
> > DTC Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+'
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: Additional items are not allowed ('simple-panel' was unexpected)
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: ['friendlyarm,hd702e', 'simple-panel'] is too long
> > DTC Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dt.yaml
> > Error: Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dts:22.42-43 syntax error
> > FATAL ERROR: Unable to parse input tree
> >
> > Please fix and check the bindings using dt_binding_check before
> > resubmit.
> >
> > I had to install libyaml-dev (as least I recall this was the name)
> > before dt_binding_check worked OK for me.
>
> I did check dt_binfing_check with this series. Here is the complete
> build log and you can see the panels related to this series are
> checked fine. Let me know if I miss anything here?
Due to other errors you never reached the poart that checks the example.
I use the following to focus on a single binding:
(from my script, but you get the idea)
domake ${arch} ${config} dt_binding_check DT_SCHEMA_FILES=${bindings}/display/panel/feixin,k101-im2ba02.yaml
In this way I can ignore all the bindings that otherwise fails.
Note: I sometimes have to clean my ouput directory to force that the
examples are tested.
It is also a good idea to introduce errors on purpose in the example, in
this way you can check that they are tested.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-amarula <linux-amarula@amarulasolutions.com>
Subject: Re: [PATCH 0/6] dt-bindings: display: Update few panel bindings with YAML
Date: Fri, 10 Jan 2020 23:05:48 +0100 [thread overview]
Message-ID: <20200110220548.GB29600@ravnborg.org> (raw)
In-Reply-To: <CAMty3ZDbDf6YovrEdG0pACQAwMQidjKr6BJvx-FPXqyT11G05w@mail.gmail.com>
Hi Jagan.
On Mon, Jan 06, 2020 at 03:41:40PM +0530, Jagan Teki wrote:
> Hi Sam,
>
> On Sat, Jan 4, 2020 at 8:47 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > Hi Jagan.
> > On Wed, Jan 01, 2020 at 04:54:38PM +0530, Jagan Teki wrote:
> > > These panel bindings are owned by me, so updated all of them into
> > > YAML DT schema.
> > >
> > > Any inputs?
> > Thanks for doing the conversion.
> >
> > dt_binding_check was not happy:
> > Documentation/devicetree/bindings/display/panel/rocktech,rk070er9427.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+'
> > DTC Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+'
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: Additional items are not allowed ('simple-panel' was unexpected)
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: ['friendlyarm,hd702e', 'simple-panel'] is too long
> > DTC Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dt.yaml
> > Error: Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dts:22.42-43 syntax error
> > FATAL ERROR: Unable to parse input tree
> >
> > Please fix and check the bindings using dt_binding_check before
> > resubmit.
> >
> > I had to install libyaml-dev (as least I recall this was the name)
> > before dt_binding_check worked OK for me.
>
> I did check dt_binfing_check with this series. Here is the complete
> build log and you can see the panels related to this series are
> checked fine. Let me know if I miss anything here?
Due to other errors you never reached the poart that checks the example.
I use the following to focus on a single binding:
(from my script, but you get the idea)
domake ${arch} ${config} dt_binding_check DT_SCHEMA_FILES=${bindings}/display/panel/feixin,k101-im2ba02.yaml
In this way I can ignore all the bindings that otherwise fails.
Note: I sometimes have to clean my ouput directory to force that the
examples are tested.
It is also a good idea to introduce errors on purpose in the example, in
this way you can check that they are tested.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-10 22:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 11:24 [PATCH 0/6] dt-bindings: display: Update few panel bindings with YAML Jagan Teki
2020-01-01 11:24 ` Jagan Teki
2020-01-01 11:24 ` [PATCH 1/6] dt-bindings: display: panel: Convert feiyang,fy07024di26a30d to DT schema Jagan Teki
2020-01-01 11:24 ` [PATCH 1/6] dt-bindings: display: panel: Convert feiyang, fy07024di26a30d " Jagan Teki
2020-01-01 11:24 ` [PATCH 2/6] dt-bindings: display: panel: Convert sitronix,st7701 " Jagan Teki
2020-01-01 11:24 ` [PATCH 2/6] dt-bindings: display: panel: Convert sitronix, st7701 " Jagan Teki
2020-01-01 11:24 ` [PATCH 3/6] MAINTAINERS: Update feiyang, st7701 panel bindings converted as YAML Jagan Teki
2020-01-01 11:24 ` Jagan Teki
2020-01-01 11:24 ` [PATCH 4/6] dt-bindings: display: panel: Convert friendlyarm,hd702e to DT schema Jagan Teki
2020-01-01 11:24 ` [PATCH 4/6] dt-bindings: display: panel: Convert friendlyarm, hd702e " Jagan Teki
2020-01-01 11:24 ` [PATCH 5/6] dt-bindings: display: panel: Convert rocktech,rk070er9427 " Jagan Teki
2020-01-01 11:24 ` [PATCH 5/6] dt-bindings: display: panel: Convert rocktech, rk070er9427 " Jagan Teki
2020-01-01 11:24 ` [PATCH 6/6] dt-bindings: display: panel: Convert koe,tx31d200vm0baa " Jagan Teki
2020-01-01 11:24 ` [PATCH 6/6] dt-bindings: display: panel: Convert koe, tx31d200vm0baa " Jagan Teki
2020-01-04 15:17 ` [PATCH 0/6] dt-bindings: display: Update few panel bindings with YAML Sam Ravnborg
2020-01-04 15:17 ` Sam Ravnborg
2020-01-06 10:11 ` Jagan Teki
2020-01-06 10:11 ` Jagan Teki
2020-01-10 22:05 ` Sam Ravnborg [this message]
2020-01-10 22:05 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110220548.GB29600@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.