From: Antoine Tenart <antoine.tenart@bootlin.com>
To: David Miller <davem@davemloft.net>
Cc: antoine.tenart@bootlin.com, sd@queasysnail.net, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com,
allan.nielsen@microchip.com, camelia.groza@nxp.com,
Simon.Edelhaus@aquantia.com, Igor.Russkikh@aquantia.com,
jakub.kicinski@netronome.com
Subject: Re: [PATCH net-next v5 00/15] net: macsec: initial support for hardware offloading
Date: Mon, 13 Jan 2020 10:38:58 +0100 [thread overview]
Message-ID: <20200113093858.GA3078@kwain> (raw)
In-Reply-To: <20200111.151030.80812382992588994.davem@davemloft.net>
Hello David,
On Sat, Jan 11, 2020 at 03:10:30PM -0800, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sat, 11 Jan 2020 15:08:07 -0800 (PST)
>
> > From: Antoine Tenart <antoine.tenart@bootlin.com>
> > Date: Fri, 10 Jan 2020 17:19:55 +0100
> >
> >> td;dr: When applying this series, do not apply patches 12 to 14.
> >>
> >> This series intends to add support for offloading MACsec transformations
> >> to hardware enabled devices. The series adds the necessary
> >> infrastructure for offloading MACsec configurations to hardware drivers,
> >> in patches 1 to 6; then introduces MACsec offloading support in the
> >> Microsemi MSCC PHY driver, in patches 7 to 11.
> >>
> >> The remaining 4 patches, 12 to 14, are *not* part of the series but
> >> provide the mandatory changes needed to support offloading MACsec
> >> operations to a MAC driver. Those patches are provided for anyone
> >> willing to add support for offloading MACsec operations to a MAC, and
> >> should be part of the first series adding a MAC as a MACsec offloading
> >> provider.
> >
> > You say four 4 patches, but 12 to 14 is 3. I think you meant 12 to 15
> > because 15 depends upon stuff added in 12 :-)
> >
> > I applied everything except patch #7, which had the unnecessary phy
> > exports, and also elided 12 to 15.
>
> Actually I had to revert.
>
> You are including net/macsec.h from a UAPI header, and that does not
> work once userlance tries to use things. And this even makes the
> kernel build fail:
>
> [davem@localhost net-next]$ make -s -j14
> In file included from <command-line>:32:
> ./usr/include/linux/if_macsec.h:17:10: fatal error: net/macsec.h: No such file or directory
> #include <net/macsec.h>
> ^~~~~~~~~~~~~~
> compilation terminated.
> make[2]: *** [usr/include/Makefile:104: usr/include/linux/if_macsec.hdrtest] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [scripts/Makefile.build:503: usr/include] Error 2
> make: *** [Makefile:1693: usr] Error 2
>
> Please fix this and respin. And honestly just leave 12-15 out of the v6
> submission, thanks.
Sorry for this, I'll fix the build issue and respin.
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-01-13 9:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 16:19 [PATCH net-next v5 00/15] net: macsec: initial support for hardware offloading Antoine Tenart
2020-01-10 16:19 ` [PATCH net-next v5 01/15] net: macsec: move some definitions in a dedicated header Antoine Tenart
2020-01-10 16:19 ` [PATCH net-next v5 02/15] net: macsec: introduce the macsec_context structure Antoine Tenart
2020-01-13 14:39 ` Jiri Pirko
2020-01-13 15:12 ` Antoine Tenart
2020-01-13 16:01 ` Jiri Pirko
2020-01-10 16:19 ` [PATCH net-next v5 03/15] net: macsec: introduce MACsec ops Antoine Tenart
2020-01-10 16:19 ` [PATCH net-next v5 04/15] net: phy: add MACsec ops in phy_device Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 05/15] net: macsec: hardware offloading infrastructure Antoine Tenart
2020-01-13 14:34 ` Jiri Pirko
2020-01-13 14:57 ` Antoine Tenart
2020-01-13 14:59 ` Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 06/15] net: macsec: add nla support for changing the offloading selection Antoine Tenart
2020-01-13 15:02 ` Jiri Pirko
2020-01-13 15:20 ` Antoine Tenart
2020-01-13 15:28 ` Jiri Pirko
2020-01-10 16:20 ` [PATCH net-next v5 07/15] net: phy: export __phy_read_page/__phy_write_page Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 08/15] net: phy: mscc: macsec initialization Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 09/15] net: phy: mscc: macsec support Antoine Tenart
2020-01-12 7:59 ` kbuild test robot
2020-01-10 16:20 ` [PATCH net-next v5 10/15] net: macsec: PN wrap callback Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 11/15] net: phy: mscc: PN rollover support Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 12/15] net: introduce the MACSEC netdev feature Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 13/15] net: add a reference to MACsec ops in net_device Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 14/15] net: macsec: allow to reference a netdev from a MACsec context Antoine Tenart
2020-01-10 16:20 ` [PATCH net-next v5 15/15] net: macsec: add support for offloading to the MAC Antoine Tenart
2020-01-10 16:26 ` [PATCH net-next v5 00/15] net: macsec: initial support for hardware offloading Antoine Tenart
2020-01-11 23:08 ` David Miller
2020-01-11 23:10 ` David Miller
2020-01-13 9:38 ` Antoine Tenart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113093858.GA3078@kwain \
--to=antoine.tenart@bootlin.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=Simon.Edelhaus@aquantia.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.