From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/olsr: use make foreach loops
Date: Mon, 13 Jan 2020 21:17:54 +0100 [thread overview]
Message-ID: <20200113211754.02aff2c1@windsurf> (raw)
In-Reply-To: <20200113180856.787063-1-fontaine.fabrice@gmail.com>
On Mon, 13 Jan 2020 19:08:56 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Replace shell for loops by make foreach loops
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/olsr/olsr.mk | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/package/olsr/olsr.mk b/package/olsr/olsr.mk
> index e643a0cfb3..3533e2a1fd 100644
> --- a/package/olsr/olsr.mk
> +++ b/package/olsr/olsr.mk
> @@ -18,19 +18,19 @@ OLSR_DEPENDENCIES = host-flex host-bison
>
> define OLSR_BUILD_CMDS
> $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D) olsrd
> - for p in $(OLSR_PLUGINS) ; do \
> - $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$$p ; \
> - done
> + $(foreach p,$(OLSR_PLUGINS),
Did you test this? To me, it seems like a backslash is missing at the end of this line.
> + $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$(p)
> + )
> endef
>
> define OLSR_INSTALL_TARGET_CMDS
> $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
> prefix="/usr" install_bin
> - for p in $(OLSR_PLUGINS) ; do \
> - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$$p \
> + $(foreach p,$(OLSR_PLUGINS),
Same here.
> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$(p) \
> LDCONFIG=/bin/true DESTDIR=$(TARGET_DIR) \
> - prefix="/usr" install ; \
> - done
> + prefix="/usr" install
> + )
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-01-13 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 18:08 [Buildroot] [PATCH 1/1] package/olsr: use make foreach loops Fabrice Fontaine
2020-01-13 20:17 ` Thomas Petazzoni [this message]
2020-01-13 20:32 ` Fabrice Fontaine
2020-01-13 22:15 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113211754.02aff2c1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.