* [Buildroot] [PATCH 1/1] package/olsr: use make foreach loops
@ 2020-01-13 18:08 Fabrice Fontaine
2020-01-13 20:17 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2020-01-13 18:08 UTC (permalink / raw)
To: buildroot
Replace shell for loops by make foreach loops
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/olsr/olsr.mk | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/package/olsr/olsr.mk b/package/olsr/olsr.mk
index e643a0cfb3..3533e2a1fd 100644
--- a/package/olsr/olsr.mk
+++ b/package/olsr/olsr.mk
@@ -18,19 +18,19 @@ OLSR_DEPENDENCIES = host-flex host-bison
define OLSR_BUILD_CMDS
$(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D) olsrd
- for p in $(OLSR_PLUGINS) ; do \
- $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$$p ; \
- done
+ $(foreach p,$(OLSR_PLUGINS),
+ $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$(p)
+ )
endef
define OLSR_INSTALL_TARGET_CMDS
$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
prefix="/usr" install_bin
- for p in $(OLSR_PLUGINS) ; do \
- $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$$p \
+ $(foreach p,$(OLSR_PLUGINS),
+ $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$(p) \
LDCONFIG=/bin/true DESTDIR=$(TARGET_DIR) \
- prefix="/usr" install ; \
- done
+ prefix="/usr" install
+ )
$(INSTALL) -D -m 0644 $(@D)/files/olsrd.conf.default.lq \
$(TARGET_DIR)/etc/olsrd/olsrd.conf
endef
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/olsr: use make foreach loops
2020-01-13 18:08 [Buildroot] [PATCH 1/1] package/olsr: use make foreach loops Fabrice Fontaine
@ 2020-01-13 20:17 ` Thomas Petazzoni
2020-01-13 20:32 ` Fabrice Fontaine
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2020-01-13 20:17 UTC (permalink / raw)
To: buildroot
On Mon, 13 Jan 2020 19:08:56 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Replace shell for loops by make foreach loops
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/olsr/olsr.mk | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/package/olsr/olsr.mk b/package/olsr/olsr.mk
> index e643a0cfb3..3533e2a1fd 100644
> --- a/package/olsr/olsr.mk
> +++ b/package/olsr/olsr.mk
> @@ -18,19 +18,19 @@ OLSR_DEPENDENCIES = host-flex host-bison
>
> define OLSR_BUILD_CMDS
> $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D) olsrd
> - for p in $(OLSR_PLUGINS) ; do \
> - $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$$p ; \
> - done
> + $(foreach p,$(OLSR_PLUGINS),
Did you test this? To me, it seems like a backslash is missing at the end of this line.
> + $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$(p)
> + )
> endef
>
> define OLSR_INSTALL_TARGET_CMDS
> $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
> prefix="/usr" install_bin
> - for p in $(OLSR_PLUGINS) ; do \
> - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$$p \
> + $(foreach p,$(OLSR_PLUGINS),
Same here.
> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$(p) \
> LDCONFIG=/bin/true DESTDIR=$(TARGET_DIR) \
> - prefix="/usr" install ; \
> - done
> + prefix="/usr" install
> + )
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/olsr: use make foreach loops
2020-01-13 20:17 ` Thomas Petazzoni
@ 2020-01-13 20:32 ` Fabrice Fontaine
2020-01-13 22:15 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2020-01-13 20:32 UTC (permalink / raw)
To: buildroot
Dear Thomas,
Le lun. 13 janv. 2020 ? 21:17, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Mon, 13 Jan 2020 19:08:56 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Replace shell for loops by make foreach loops
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/olsr/olsr.mk | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/package/olsr/olsr.mk b/package/olsr/olsr.mk
> > index e643a0cfb3..3533e2a1fd 100644
> > --- a/package/olsr/olsr.mk
> > +++ b/package/olsr/olsr.mk
> > @@ -18,19 +18,19 @@ OLSR_DEPENDENCIES = host-flex host-bison
> >
> > define OLSR_BUILD_CMDS
> > $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D) olsrd
> > - for p in $(OLSR_PLUGINS) ; do \
> > - $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$$p ; \
> > - done
> > + $(foreach p,$(OLSR_PLUGINS),
>
> Did you test this? To me, it seems like a backslash is missing at the end of this line.
Yes, it builds fine. I decided to skip the backslash as some packages
(ltp-testsuite, selinux-python, policycoreutils, python-pyqt5) don't
add it while others (systemd, sunxi-tools) do.
But I can add a backslash if you want, I don't know what is the "best practice".
>
> > + $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$(p)
> > + )
> > endef
> >
> > define OLSR_INSTALL_TARGET_CMDS
> > $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
> > prefix="/usr" install_bin
> > - for p in $(OLSR_PLUGINS) ; do \
> > - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$$p \
> > + $(foreach p,$(OLSR_PLUGINS),
>
> Same here.
>
> > + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$(p) \
> > LDCONFIG=/bin/true DESTDIR=$(TARGET_DIR) \
> > - prefix="/usr" install ; \
> > - done
> > + prefix="/usr" install
> > + )
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/olsr: use make foreach loops
2020-01-13 20:32 ` Fabrice Fontaine
@ 2020-01-13 22:15 ` Arnout Vandecappelle
0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2020-01-13 22:15 UTC (permalink / raw)
To: buildroot
On 13/01/2020 21:32, Fabrice Fontaine wrote:
> Dear Thomas,
>
> Le lun. 13 janv. 2020 ? 21:17, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> a ?crit :
>>
>> On Mon, 13 Jan 2020 19:08:56 +0100
>> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>>
>>> Replace shell for loops by make foreach loops
>>>
>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>>> ---
>>> package/olsr/olsr.mk | 14 +++++++-------
>>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/package/olsr/olsr.mk b/package/olsr/olsr.mk
>>> index e643a0cfb3..3533e2a1fd 100644
>>> --- a/package/olsr/olsr.mk
>>> +++ b/package/olsr/olsr.mk
>>> @@ -18,19 +18,19 @@ OLSR_DEPENDENCIES = host-flex host-bison
>>>
>>> define OLSR_BUILD_CMDS
>>> $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D) olsrd
>>> - for p in $(OLSR_PLUGINS) ; do \
>>> - $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$$p ; \
>>> - done
>>> + $(foreach p,$(OLSR_PLUGINS),
>>
>> Did you test this? To me, it seems like a backslash is missing at the end of this line.
> Yes, it builds fine. I decided to skip the backslash as some packages
> (ltp-testsuite, selinux-python, policycoreutils, python-pyqt5) don't
> add it while others (systemd, sunxi-tools) do.
> But I can add a backslash if you want, I don't know what is the "best practice".
It works because it's within a define:
-------------
# This works, because 'define' creates a multiline "statement"
define test1
$(foreach i,1 2 3,
$(info $(i)))
endef
$(test1)
# The following fail without backslash, because it's interpreted line-by-line
all:
$(foreach i,4 5,
$(info $(i)))
$(foreach i,7 8,
$(info $(i)))
-------------
For consistency, I think it makes sense to always use a backslash.
Regards,
Arnout
>>
>>> + $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$(p)
>>> + )
>>> endef
>>>
>>> define OLSR_INSTALL_TARGET_CMDS
>>> $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
>>> prefix="/usr" install_bin
>>> - for p in $(OLSR_PLUGINS) ; do \
>>> - $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$$p \
>>> + $(foreach p,$(OLSR_PLUGINS),
>>
>> Same here.
>>
>>> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$(p) \
>>> LDCONFIG=/bin/true DESTDIR=$(TARGET_DIR) \
>>> - prefix="/usr" install ; \
>>> - done
>>> + prefix="/usr" install
>>> + )
>>
>> Best regards,
>>
>> Thomas
>> --
>> Thomas Petazzoni, CTO, Bootlin
>> Embedded Linux and Kernel engineering
>> https://bootlin.com
> Best Regards,
>
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-13 22:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-13 18:08 [Buildroot] [PATCH 1/1] package/olsr: use make foreach loops Fabrice Fontaine
2020-01-13 20:17 ` Thomas Petazzoni
2020-01-13 20:32 ` Fabrice Fontaine
2020-01-13 22:15 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.