All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Chen-Yu Tsai <wens@csie.org>,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH] ARM: dts: sun8i: a83t: Fix incorrect clk and reset macros for EMAC device
Date: Tue, 14 Jan 2020 16:06:52 +0100	[thread overview]
Message-ID: <20200114150652.GA32269@Red> (raw)
In-Reply-To: <20200114094252.8908-1-wens@kernel.org>

On Tue, Jan 14, 2020 at 05:42:52PM +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
> 
> When the raw numbers used for clk and reset indices in the EMAC device
> node were converted to the new macros, the order of the clk and reset
> properties was overlooked, and thus the incorrect macros were used.
> This results in the EMAC being non-responsive, as well as an oops due
> to incorrect usage of the reset control.
> 
> Correct the macro types, and also reorder the clk and reset properties
> to match all the other device nodes.
> 
> Fixes: 765866edb16a ("ARM: dts: sunxi: Use macros for references to CCU clocks")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> 
> Error on my part. Hope no one was affected for too long.
> 

Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>

I saw this today and with this patch the board is back normal.

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>,
	devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: sun8i: a83t: Fix incorrect clk and reset macros for EMAC device
Date: Tue, 14 Jan 2020 16:06:52 +0100	[thread overview]
Message-ID: <20200114150652.GA32269@Red> (raw)
In-Reply-To: <20200114094252.8908-1-wens@kernel.org>

On Tue, Jan 14, 2020 at 05:42:52PM +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
> 
> When the raw numbers used for clk and reset indices in the EMAC device
> node were converted to the new macros, the order of the clk and reset
> properties was overlooked, and thus the incorrect macros were used.
> This results in the EMAC being non-responsive, as well as an oops due
> to incorrect usage of the reset control.
> 
> Correct the macro types, and also reorder the clk and reset properties
> to match all the other device nodes.
> 
> Fixes: 765866edb16a ("ARM: dts: sunxi: Use macros for references to CCU clocks")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> 
> Error on my part. Hope no one was affected for too long.
> 

Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>

I saw this today and with this patch the board is back normal.

Thanks

  reply	other threads:[~2020-01-14 15:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14  9:42 [PATCH] ARM: dts: sun8i: a83t: Fix incorrect clk and reset macros for EMAC device Chen-Yu Tsai
2020-01-14  9:42 ` Chen-Yu Tsai
2020-01-14 15:06 ` Corentin Labbe [this message]
2020-01-14 15:06   ` Corentin Labbe
2020-01-17 18:12 ` Maxime Ripard
2020-01-17 18:12   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200114150652.GA32269@Red \
    --to=clabbe.montjoie@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.