From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: John Crispin <john@phrozen.org>,
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>,
Anilkumar Kolli <akolli@codeaurora.org>,
Bhagavathi Perumal S <bperumal@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath11k: fix up some error paths
Date: Wed, 15 Jan 2020 09:19:03 +0000 [thread overview]
Message-ID: <20200115091903.7EC3FC4479C@smtp.codeaurora.org> (raw)
In-Reply-To: <20191213105448.b7lic5ddih6c3sqy@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There are two error paths where "ret" wasn't set. Ideally the compiler
> would have warned about these bugs, but we initialized "ret" to zero so
> it silenced the warning. I have removed that. Also if
> ath11k_hal_srng_get_entrysize() fails then we need to free some
> resources before returning.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Failed to apply:
error: patch failed: drivers/net/wireless/ath/ath11k/dp_tx.c:646
error: drivers/net/wireless/ath/ath11k/dp_tx.c: patch does not apply
stg import: Diff does not apply cleanly
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11290443/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: John Crispin <john@phrozen.org>,
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>,
Anilkumar Kolli <akolli@codeaurora.org>,
Bhagavathi Perumal S <bperumal@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath11k: fix up some error paths
Date: Wed, 15 Jan 2020 09:19:03 +0000 (UTC) [thread overview]
Message-ID: <20200115091903.7EC3FC4479C@smtp.codeaurora.org> (raw)
In-Reply-To: <20191213105448.b7lic5ddih6c3sqy@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There are two error paths where "ret" wasn't set. Ideally the compiler
> would have warned about these bugs, but we initialized "ret" to zero so
> it silenced the warning. I have removed that. Also if
> ath11k_hal_srng_get_entrysize() fails then we need to free some
> resources before returning.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Failed to apply:
error: patch failed: drivers/net/wireless/ath/ath11k/dp_tx.c:646
error: drivers/net/wireless/ath/ath11k/dp_tx.c: patch does not apply
stg import: Diff does not apply cleanly
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11290443/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-01-15 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 10:54 [PATCH] ath11k: fix up some error paths Dan Carpenter
2019-12-13 10:54 ` Dan Carpenter
2019-12-13 10:54 ` Dan Carpenter
2020-01-15 9:19 ` Kalle Valo [this message]
2020-01-15 9:19 ` Kalle Valo
2020-01-15 17:46 ` [PATCH v2] " Dan Carpenter
2020-01-15 17:46 ` Dan Carpenter
2020-01-15 17:46 ` Dan Carpenter
2020-01-26 10:51 ` Kalle Valo
2020-01-26 10:51 ` Kalle Valo
2020-01-26 10:51 ` Kalle Valo
2020-01-15 9:19 ` [PATCH] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115091903.7EC3FC4479C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=bperumal@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=john@phrozen.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.