All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12
@ 2020-01-14 22:45 Matt Roper
  2020-01-14 22:47 ` Chris Wilson
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Matt Roper @ 2020-01-14 22:45 UTC (permalink / raw)
  To: intel-gfx

Since gen12 platform support isn't finalized yet, let's kill off the
legacy color key ioctl for this platform; there's no userspace today
that can run on this platform that utilizes this legacy ioctl, so we can
safely kill it now before it becomes ABI.

Color key functionality never got integrated into the property / atomic
interface, and the only known open source consumer was the Intel DDX
which was never updated to run on platforms beyond gen9.  If color
keying is desired going forward, it should really be exposed as a
property so that it can be applied atomically with other display updates
(and should probably be standardized in a way all drivers can choose to
support rather than being i915-specific).

Arguably we might be able to prohibit this on gen10 and gen11 as well
since no open source userspace exists for those platforms that utilizes
these ioctls.  However there's always the very slight chance that
unknown closed source software is actively utilizing the color key ioctl
on those platforms, so we should maintain the support there to avoid
breaking ABI.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/display/intel_sprite.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index fca77ec1e0dd..6e8a4686a406 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -2290,6 +2290,14 @@ int intel_sprite_set_colorkey_ioctl(struct drm_device *dev, void *data,
 	struct drm_modeset_acquire_ctx ctx;
 	int ret = 0;
 
+	/*
+	 * Userspace that uses this legacy interface only exists up through
+	 * gen9.  Discontinue support for the interface starting with gen12 so
+	 * that it doesn't become ABI on newer platforms.
+	 */
+	if (INTEL_GEN(dev_priv) >= 12)
+		return -EINVAL;
+
 	/* ignore the pointless "none" flag */
 	set->flags &= ~I915_SET_COLORKEY_NONE;
 
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-17  4:49 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-14 22:45 [Intel-gfx] [RFC] drm/i915: Restrict legacy color key ioctl to pre-gen12 Matt Roper
2020-01-14 22:47 ` Chris Wilson
2020-01-14 22:54   ` Chris Wilson
2020-01-14 23:03     ` Matt Roper
2020-01-14 23:07       ` Chris Wilson
2020-01-15  0:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-15  0:07 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-15 14:31 ` [Intel-gfx] [RFC] " Ville Syrjälä
2020-01-17  4:49 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.