From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Robertson <dan@dlrobertson.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: accel: bma400: integer underflow setting accel scale
Date: Thu, 16 Jan 2020 06:24:38 +0000 [thread overview]
Message-ID: <20200116061916.GH9562@kadam> (raw)
In-Reply-To: <20200115181717.GA22797@nessie>
On Wed, Jan 15, 2020 at 06:17:17PM +0000, Dan Robertson wrote:
> On Wed, Jan 15, 2020 at 08:45:31PM +0300, Dan Carpenter wrote:
> > We put an upper bound on "val2" but we also need to prevent negative
> > values.
> >
> > Fixes: 465c811f1f20 ("iio: accel: Add driver for the BMA400")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/iio/accel/bma400_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
> > index ab4a158b35af..ffc7b146bbfc 100644
> > --- a/drivers/iio/accel/bma400_core.c
> > +++ b/drivers/iio/accel/bma400_core.c
> > @@ -752,7 +752,7 @@ static int bma400_write_raw(struct iio_dev *indio_dev,
> > mutex_unlock(&data->mutex);
> > return ret;
> > case IIO_CHAN_INFO_SCALE:
> > - if (val != 0 || val2 > BMA400_SCALE_MAX)
> > + if (val != 0 || val2 < 0 || val2 > BMA400_SCALE_MAX)
>
> AFAIK if val2 is less than BMA400_SCALE_MIN we should return -EINVAL.
>
Ah. Thanks. Let me resend.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Robertson <dan@dlrobertson.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: accel: bma400: integer underflow setting accel scale
Date: Thu, 16 Jan 2020 09:24:38 +0300 [thread overview]
Message-ID: <20200116061916.GH9562@kadam> (raw)
In-Reply-To: <20200115181717.GA22797@nessie>
On Wed, Jan 15, 2020 at 06:17:17PM +0000, Dan Robertson wrote:
> On Wed, Jan 15, 2020 at 08:45:31PM +0300, Dan Carpenter wrote:
> > We put an upper bound on "val2" but we also need to prevent negative
> > values.
> >
> > Fixes: 465c811f1f20 ("iio: accel: Add driver for the BMA400")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/iio/accel/bma400_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
> > index ab4a158b35af..ffc7b146bbfc 100644
> > --- a/drivers/iio/accel/bma400_core.c
> > +++ b/drivers/iio/accel/bma400_core.c
> > @@ -752,7 +752,7 @@ static int bma400_write_raw(struct iio_dev *indio_dev,
> > mutex_unlock(&data->mutex);
> > return ret;
> > case IIO_CHAN_INFO_SCALE:
> > - if (val != 0 || val2 > BMA400_SCALE_MAX)
> > + if (val != 0 || val2 < 0 || val2 > BMA400_SCALE_MAX)
>
> AFAIK if val2 is less than BMA400_SCALE_MIN we should return -EINVAL.
>
Ah. Thanks. Let me resend.
regards,
dan carpenter
next prev parent reply other threads:[~2020-01-16 6:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 17:45 [PATCH] iio: accel: bma400: integer underflow setting accel scale Dan Carpenter
2020-01-15 17:45 ` Dan Carpenter
2020-01-15 17:43 ` Dan Robertson
2020-01-15 18:09 ` Dan Carpenter
2020-01-15 18:09 ` Dan Carpenter
2020-01-15 17:58 ` Dan Robertson
2020-01-15 18:17 ` Dan Robertson
2020-01-16 6:24 ` Dan Carpenter [this message]
2020-01-16 6:24 ` Dan Carpenter
2020-01-16 10:08 ` [PATCH v2] iio: accel: bma400: prevent setting accel scale too low Dan Carpenter
2020-01-16 10:08 ` Dan Carpenter
2020-01-18 13:34 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116061916.GH9562@kadam \
--to=dan.carpenter@oracle.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan@dlrobertson.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.