All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Perret <qperret@google.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rui.zhang@intel.com, daniel.lezcano@linaro.org,
	viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
	amit.kachhap@gmail.com, javi.merino@kernel.org,
	kernel-team@android.com
Subject: Re: [Patch v8 7/7] sched/fair: Enable tuning of decay period
Date: Fri, 17 Jan 2020 11:47:58 +0000	[thread overview]
Message-ID: <20200117114758.GB219309@google.com> (raw)
In-Reply-To: <1579031859-18692-8-git-send-email-thara.gopinath@linaro.org>

On Tuesday 14 Jan 2020 at 14:57:39 (-0500), Thara Gopinath wrote:
> +static int __init setup_sched_thermal_decay_shift(char *str)
> +{
> +	int _shift;
> +
> +	if (kstrtoint(str, 0, &_shift))
> +		pr_warn("Unable to set scheduler thermal pressure decay shift parameter\n");

Nit: looking at kstrtoint() it seems that _shift will be left unmodified
upon failure. To avoid feeding a random value to clamp() below, perhaps
initialize _shift to 0 ?

> +	sched_thermal_decay_shift = clamp(_shift, 0, 10);
> +	return 1;
> +}

Thanks,
Quentin

  reply	other threads:[~2020-01-17 11:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 19:57 [Patch v8 0/7] Introduce Thermal Pressure Thara Gopinath
2020-01-14 19:57 ` [Patch v8 1/7] sched/pelt: Add support to track thermal pressure Thara Gopinath
2020-01-16 15:17   ` Peter Zijlstra
2020-01-23 19:15     ` Dietmar Eggemann
2020-01-24 19:07       ` Thara Gopinath
2020-01-27  9:28         ` Dietmar Eggemann
2020-01-28 13:32           ` Thara Gopinath
2020-01-28 16:15             ` Dietmar Eggemann
2020-02-13 12:03   ` Amit Kucheria
2020-02-13 12:31     ` Amit Kucheria
2020-01-14 19:57 ` [Patch v8 2/7] sched/topology: Add hook to read per cpu " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 3/7] arm,arm64,drivers:Add infrastructure to store and update instantaneous " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 4/7] sched/fair: Enable periodic update of average " Thara Gopinath
2020-01-16 15:15   ` Peter Zijlstra
2020-01-17 11:40     ` Quentin Perret
2020-01-17 12:31       ` Peter Zijlstra
2020-01-17 13:17         ` Vincent Guittot
2020-01-17 13:45           ` Quentin Perret
2020-01-17 13:22     ` Vincent Guittot
2020-01-17 14:55       ` Peter Zijlstra
2020-01-17 15:39         ` Vincent Guittot
2020-01-24 15:37           ` Dietmar Eggemann
2020-01-24 15:45             ` Vincent Guittot
2020-01-27 12:09               ` Dietmar Eggemann
2020-01-27 15:15                 ` Vincent Guittot
2020-01-29 15:41                   ` Dietmar Eggemann
2020-01-30  9:49                     ` Vincent Guittot
2020-01-17 20:20     ` Thara Gopinath
2020-01-14 19:57 ` [Patch v8 5/7] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 6/7] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2020-01-14 19:57 ` [Patch v8 7/7] sched/fair: Enable tuning of decay period Thara Gopinath
2020-01-17 11:47   ` Quentin Perret [this message]
2020-01-17 15:45     ` Thara Gopinath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200117114758.GB219309@google.com \
    --to=qperret@google.com \
    --cc=amit.kachhap@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=ionela.voinescu@arm.com \
    --cc=javi.merino@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rui.zhang@intel.com \
    --cc=thara.gopinath@linaro.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.