From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
Thara Gopinath <thara.gopinath@linaro.org>
Cc: mingo@redhat.com, ionela.voinescu@arm.com,
vincent.guittot@linaro.org, rui.zhang@intel.com,
qperret@google.com, daniel.lezcano@linaro.org,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
amit.kachhap@gmail.com, javi.merino@kernel.org,
amit.kucheria@verdurent.com
Subject: Re: [Patch v8 1/7] sched/pelt: Add support to track thermal pressure
Date: Thu, 23 Jan 2020 20:15:47 +0100 [thread overview]
Message-ID: <e5ecad29-11d8-e7ff-27ff-b63ca44fdcd3@arm.com> (raw)
In-Reply-To: <20200116151724.GR2827@hirez.programming.kicks-ass.net>
On 16/01/2020 16:17, Peter Zijlstra wrote:
> On Tue, Jan 14, 2020 at 02:57:33PM -0500, Thara Gopinath wrote:
>
>> diff --git a/kernel/sched/pelt.h b/kernel/sched/pelt.h
>> index afff644..bf1e17b 100644
>> --- a/kernel/sched/pelt.h
>> +++ b/kernel/sched/pelt.h
>> @@ -7,6 +7,16 @@ int __update_load_avg_cfs_rq(u64 now, struct cfs_rq *cfs_rq);
>> int update_rt_rq_load_avg(u64 now, struct rq *rq, int running);
>> int update_dl_rq_load_avg(u64 now, struct rq *rq, int running);
>>
>> +#ifdef CONFIG_HAVE_SCHED_THERMAL_PRESSURE
I assume your plan is to enable this for Arm and Arm64? Otherwise the
code in 3/7 should also be guarded by this.
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index e688dfad0b72..9eb414b2c8b9 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -164,6 +164,7 @@ config ARM64
select HAVE_FUNCTION_ARG_ACCESS_API
select HAVE_RCU_TABLE_FREE
select HAVE_RSEQ
+ select HAVE_SCHED_THERMAL_PRESSURE
select HAVE_STACKPROTECTOR
select HAVE_SYSCALL_TRACEPOINTS
Currently it lives in the 'CPU/Task time and stats accounting' of
.config which doesn't feel right to me.
[...]
next prev parent reply other threads:[~2020-01-23 19:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 19:57 [Patch v8 0/7] Introduce Thermal Pressure Thara Gopinath
2020-01-14 19:57 ` [Patch v8 1/7] sched/pelt: Add support to track thermal pressure Thara Gopinath
2020-01-16 15:17 ` Peter Zijlstra
2020-01-23 19:15 ` Dietmar Eggemann [this message]
2020-01-24 19:07 ` Thara Gopinath
2020-01-27 9:28 ` Dietmar Eggemann
2020-01-28 13:32 ` Thara Gopinath
2020-01-28 16:15 ` Dietmar Eggemann
2020-02-13 12:03 ` Amit Kucheria
2020-02-13 12:31 ` Amit Kucheria
2020-01-14 19:57 ` [Patch v8 2/7] sched/topology: Add hook to read per cpu " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 3/7] arm,arm64,drivers:Add infrastructure to store and update instantaneous " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 4/7] sched/fair: Enable periodic update of average " Thara Gopinath
2020-01-16 15:15 ` Peter Zijlstra
2020-01-17 11:40 ` Quentin Perret
2020-01-17 12:31 ` Peter Zijlstra
2020-01-17 13:17 ` Vincent Guittot
2020-01-17 13:45 ` Quentin Perret
2020-01-17 13:22 ` Vincent Guittot
2020-01-17 14:55 ` Peter Zijlstra
2020-01-17 15:39 ` Vincent Guittot
2020-01-24 15:37 ` Dietmar Eggemann
2020-01-24 15:45 ` Vincent Guittot
2020-01-27 12:09 ` Dietmar Eggemann
2020-01-27 15:15 ` Vincent Guittot
2020-01-29 15:41 ` Dietmar Eggemann
2020-01-30 9:49 ` Vincent Guittot
2020-01-17 20:20 ` Thara Gopinath
2020-01-14 19:57 ` [Patch v8 5/7] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2020-01-14 19:57 ` [Patch v8 6/7] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2020-01-14 19:57 ` [Patch v8 7/7] sched/fair: Enable tuning of decay period Thara Gopinath
2020-01-17 11:47 ` Quentin Perret
2020-01-17 15:45 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5ecad29-11d8-e7ff-27ff-b63ca44fdcd3@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.