Re: [PATCH v2] dt-bindings: display: Convert a bunch of panels to DT schema

From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v2] dt-bindings: display: Convert a bunch of panels to DT schema
Date: Sat, 18 Jan 2020 10:11:40 +0100	[thread overview]
Message-ID: <20200118091140.GA12245@ravnborg.org> (raw)
In-Reply-To: <20200117231756.3141-1-robh@kernel.org>

Hi Rob.

On Fri, Jan 17, 2020 at 05:17:56PM -0600, Rob Herring wrote:
> Convert all the 'simple' panels which match the constraints of the
> common panel-simple.yaml schema. This conversion is based on how the
> panels are documented. Some may turn out to be more complex once the
> schema is applied to actual dts files.

Thanks for updating this patch - and very good to reduce the number of
files with almost the same content.

One comment below, with that addressed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

There are likely some dt files that assume panels need no power and need a
fixed-regulator or something as power-supply now is mandatory.
Should this be checked before we apply this patch?

As we continue to see new panels more or less every week I would like
this patch applied to drm-misc-next as soon as possible to avoid any
future conflicts.

> index 513f03466aba..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/innolux,p120zdg-bf1.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Innolux P120ZDG-BF1 12.02 inch eDP 2K display panel
> -
> -This binding is compatible with the simple-panel binding, which is specified
> -in simple-panel.txt in this directory.
> -
> -Required properties:
> -- compatible: should be "innolux,p120zdg-bf1"
> -- power-supply: regulator to provide the supply voltage
> -
> -Optional properties:
> -- enable-gpios: GPIO pin to enable or disable the panel
> -- backlight: phandle of the backlight device attached to the panel
> -- no-hpd: If HPD isn't hooked up; add this property.

panel-simple.yaml does not include the no-hpd property.
We only have 2 bindings, this and sharp,ld-d5116z01b.yaml
that include the no-hpd property.

We have two options:
1) add the no-hpd property to panel-simple.yaml
2) keep an independent binding for panels using no-hpd

I suggest to keep an independent binding for innolux,p120zdg-bf1
so we keep panel-simple.yaml slim.
In other words do not delete this file and remove the compatible from
panel-simple.yaml

	Sam