From: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Christian Brauner
<christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 5/6] clone3: allow spawning processes into cgroups
Date: Mon, 20 Jan 2020 16:39:30 +0100 [thread overview]
Message-ID: <20200120153930.GE30403@redhat.com> (raw)
In-Reply-To: <20200117181219.14542-6-christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
On 01/17, Christian Brauner wrote:
>
> +static int cgroup_css_set_fork(struct task_struct *parent,
> + struct kernel_clone_args *kargs)
...
> + kargs->cset = find_css_set(cset, dst_cgrp);
> + if (!kargs->cset) {
> + ret = -ENOMEM;
> + goto err;
> + }
> +
> + if (cgroup_is_dead(dst_cgrp)) {
> + ret = -ENODEV;
> + goto err;
^^^^^^^^
this looks wrong... don't we need put_css_set(kargs->cset) before "goto err" ?
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Li Zefan <lizefan@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
cgroups@vger.kernel.org
Subject: Re: [PATCH v4 5/6] clone3: allow spawning processes into cgroups
Date: Mon, 20 Jan 2020 16:39:30 +0100 [thread overview]
Message-ID: <20200120153930.GE30403@redhat.com> (raw)
In-Reply-To: <20200117181219.14542-6-christian.brauner@ubuntu.com>
On 01/17, Christian Brauner wrote:
>
> +static int cgroup_css_set_fork(struct task_struct *parent,
> + struct kernel_clone_args *kargs)
...
> + kargs->cset = find_css_set(cset, dst_cgrp);
> + if (!kargs->cset) {
> + ret = -ENOMEM;
> + goto err;
> + }
> +
> + if (cgroup_is_dead(dst_cgrp)) {
> + ret = -ENODEV;
> + goto err;
^^^^^^^^
this looks wrong... don't we need put_css_set(kargs->cset) before "goto err" ?
Oleg.
next prev parent reply other threads:[~2020-01-20 15:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 18:12 [PATCH v4 0/6] clone3 & cgroups: allow spawning processes into cgroups Christian Brauner
2020-01-17 18:12 ` Christian Brauner
[not found] ` <20200117181219.14542-1-christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2020-01-17 18:12 ` [PATCH v4 1/6] cgroup: unify attach permission checking Christian Brauner
2020-01-17 18:12 ` Christian Brauner
[not found] ` <20200117181219.14542-2-christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2020-01-20 14:42 ` Oleg Nesterov
2020-01-20 14:42 ` Oleg Nesterov
[not found] ` <20200120144244.GD30403-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-01-20 14:46 ` Christian Brauner
2020-01-20 14:46 ` Christian Brauner
2020-01-17 18:12 ` [PATCH v4 2/6] cgroup: add cgroup_get_from_file() helper Christian Brauner
2020-01-17 18:12 ` Christian Brauner
2020-01-17 18:12 ` [PATCH v4 3/6] cgroup: refactor fork helpers Christian Brauner
2020-01-17 18:12 ` Christian Brauner
2020-01-20 14:00 ` Oleg Nesterov
2020-01-20 14:04 ` Christian Brauner
2020-01-20 14:22 ` Oleg Nesterov
[not found] ` <20200120142202.GC30403-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2020-01-20 14:33 ` Christian Brauner
2020-01-20 14:33 ` Christian Brauner
2020-01-17 18:12 ` [PATCH v4 4/6] cgroup: add cgroup_may_write() helper Christian Brauner
2020-01-17 18:12 ` Christian Brauner
2020-01-17 18:12 ` [PATCH v4 5/6] clone3: allow spawning processes into cgroups Christian Brauner
2020-01-17 18:12 ` Christian Brauner
2020-01-17 18:12 ` Christian Brauner
[not found] ` <20200117181219.14542-6-christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2020-01-20 15:39 ` Oleg Nesterov [this message]
2020-01-20 15:39 ` Oleg Nesterov
2020-01-20 21:38 ` Christian Brauner
2020-01-17 18:12 ` [PATCH v4 6/6] selftests/cgroup: add tests for cloning " Christian Brauner
2020-01-17 20:24 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120153930.GE30403@redhat.com \
--to=oleg-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.