From: Sam Ravnborg <sam@ravnborg.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: David Airlie <airlied@linux.ie>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
intel-gfx@lists.freedesktop.org, sudeep.dutt@intel.com,
dri-devel@lists.freedesktop.org
Subject: Re: [[Intel-gfx] [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros
Date: Tue, 21 Jan 2020 10:13:06 +0100 [thread overview]
Message-ID: <20200121091306.GA29647@ravnborg.org> (raw)
In-Reply-To: <87muahfbjt.fsf@intel.com>
On Tue, Jan 21, 2020 at 10:39:34AM +0200, Jani Nikula wrote:
> On Wed, 15 Jan 2020, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Wed, 15 Jan 2020, Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> wrote:
> >> Add new struct drm_device based WARN* macros. These are modeled after
> >> the core kernel device based WARN* macros. These would be preferred
> >> over the regular WARN* macros, where possible.
> >>
> >> These macros include device information in the backtrace, so we know
> >> what device the warnings originate from.
> >>
> >> Knowing the device specific information in the backtrace would be
> >> helpful in development all around.
> >>
> >> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> >
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> All, I'd really appreciate acks or reviews on this one to unblock the
> rest. I think the patch is fine, but I'd like wider approval before
> merging.
Patch looks good:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Maxime Ripard <mripard@kernel.org>
Subject: Re: [Intel-gfx] [ [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros
Date: Tue, 21 Jan 2020 10:13:06 +0100 [thread overview]
Message-ID: <20200121091306.GA29647@ravnborg.org> (raw)
In-Reply-To: <87muahfbjt.fsf@intel.com>
On Tue, Jan 21, 2020 at 10:39:34AM +0200, Jani Nikula wrote:
> On Wed, 15 Jan 2020, Jani Nikula <jani.nikula@intel.com> wrote:
> > On Wed, 15 Jan 2020, Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> wrote:
> >> Add new struct drm_device based WARN* macros. These are modeled after
> >> the core kernel device based WARN* macros. These would be preferred
> >> over the regular WARN* macros, where possible.
> >>
> >> These macros include device information in the backtrace, so we know
> >> what device the warnings originate from.
> >>
> >> Knowing the device specific information in the backtrace would be
> >> helpful in development all around.
> >>
> >> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> >
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> All, I'd really appreciate acks or reviews on this one to unblock the
> rest. I think the patch is fine, but I'd like wider approval before
> merging.
Patch looks good:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-21 9:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 3:44 [[Intel-gfx] [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915 Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 10:02 ` [[Intel-gfx] " Jani Nikula
2020-01-15 10:02 ` [Intel-gfx] [ " Jani Nikula
2020-01-21 8:39 ` [[Intel-gfx] " Jani Nikula
2020-01-21 8:39 ` [Intel-gfx] [ " Jani Nikula
2020-01-21 9:13 ` Sam Ravnborg [this message]
2020-01-21 9:13 ` Sam Ravnborg
2020-01-22 13:30 ` Sean Paul
2020-01-22 13:30 ` Sean Paul
2020-01-22 15:32 ` Jani Nikula
2020-01-22 15:32 ` Jani Nikula
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 02/10] drm/i915/display: Make WARN* drm specific where drm_device ptr is available Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 03/10] drm/i915/display: Make WARN* drm specific where drm_priv " Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 04/10] drm/i915/display: Make WARN* drm specific where encoder " Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 05/10] drm/i915/gem: Make WARN* drm specific where drm_priv " Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 06/10] drm/i915/gt: " Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 07/10] drm/i915/gvt: " Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 08/10] drm/i915/gvt: Make WARN* drm specific where vgpu " Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 09/10] drm/i915: Make WARN* drm specific where drm_priv " Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 3:44 ` [[Intel-gfx] [PATCH v2 10/10] drm/i915: Make WARN* drm specific where uncore or stream " Pankaj Bharadiya
2020-01-15 3:44 ` [Intel-gfx] [ " Pankaj Bharadiya
2020-01-15 4:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Introduce struct drm_device based WARN* and use them in i915 (rev2) Patchwork
2020-01-15 4:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-01-15 4:38 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-17 11:31 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2020-01-22 16:22 ` [[Intel-gfx] [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915 Jani Nikula
2020-01-22 16:22 ` [Intel-gfx] [ " Jani Nikula
2020-01-23 9:00 ` [[Intel-gfx] " Bharadiya,Pankaj
2020-01-23 9:00 ` [Intel-gfx] [ " Bharadiya,Pankaj
2020-01-23 9:39 ` [[Intel-gfx] " Jani Nikula
2020-01-23 9:39 ` [Intel-gfx] [ " Jani Nikula
2020-01-27 8:14 ` [[Intel-gfx] " Bharadiya,Pankaj
2020-01-27 8:14 ` [Intel-gfx] [ " Bharadiya,Pankaj
2020-01-27 9:01 ` [[Intel-gfx] " Jani Nikula
2020-01-27 9:01 ` [Intel-gfx] [ " Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2020-01-15 3:43 [[Intel-gfx] " Pankaj Bharadiya
2020-01-15 3:43 ` [[Intel-gfx] [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros Pankaj Bharadiya
2020-01-15 3:43 ` [Intel-gfx] [ " Pankaj Bharadiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121091306.GA29647@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.