From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Fix wrong output format in lo_setxattr()
Date: Tue, 21 Jan 2020 10:02:35 +0000 [thread overview]
Message-ID: <20200121100235.GA2929@work-vm> (raw)
In-Reply-To: <20200121073236.9067-1-yangx.jy@cn.fujitsu.com>
* Xiao Yang (yangx.jy@cn.fujitsu.com) wrote:
> Actual debug output:
> -------------------------------
> [2778114403742] [ID: 00000033] lo_setxattr(ino=93998909307364[2778114466291] [ID: 00000033] unique: 56, success, outsize: 16
> -------------------------------
> Correct debug output:
> -------------------------------
> 383 [2341816212531] [ID: 00000098] lo_setxattr(ino=3, name=user.test value=test size=4)
> -------------------------------
>
> Fixes: 63bc560920ad ("virtiofsd: print log only when priority is high enough)"
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> tools/virtiofsd/passthrough_ll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 57f58aef26..ff34e77a23 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -2528,7 +2528,7 @@ static void lo_setxattr(fuse_req_t req, fuse_ino_t ino, const char *name,
> goto out;
> }
>
> - fuse_log(FUSE_LOG_DEBUG, "lo_setxattr(ino=%" PRIu64,
> + fuse_log(FUSE_LOG_DEBUG, "lo_setxattr(ino=%" PRIu64
> ", name=%s value=%s size=%zd)\n", ino, name, value, size);
>
> if (inode->is_symlink) {
Thank you for the fix! I think we need to mark fuse_log as being printf
format so hopefully it will spot more of these errors automatically.
Dave
> --
> 2.21.0
>
>
>
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-01-21 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 7:32 [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Fix wrong output format in lo_setxattr() Xiao Yang
2020-01-21 10:02 ` Dr. David Alan Gilbert [this message]
2020-01-21 10:45 ` Xiao Yang
2020-01-21 11:55 ` Dr. David Alan Gilbert
2020-01-28 9:52 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121100235.GA2929@work-vm \
--to=dgilbert@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.