From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Fix wrong output format in lo_setxattr()
Date: Tue, 21 Jan 2020 18:45:08 +0800 [thread overview]
Message-ID: <5E26D634.6000905@cn.fujitsu.com> (raw)
In-Reply-To: <20200121100235.GA2929@work-vm>
On 2020/1/21 18:02, Dr. David Alan Gilbert wrote:
> Thank you for the fix! I think we need to mark fuse_log as being printf
> format so hopefully it will spot more of these errors automatically.
Hi Dave,
Do you perfer to write output to stdout rather than stderr? right?(e.g.
replace vfprintf with vprintf?)
BTW: Perhaps, log_func() needs to call g_free() after using
g_strdup_printf().
Thanks,
Xiao Yang
> Dave
next prev parent reply other threads:[~2020-01-21 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 7:32 [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Fix wrong output format in lo_setxattr() Xiao Yang
2020-01-21 10:02 ` Dr. David Alan Gilbert
2020-01-21 10:45 ` Xiao Yang [this message]
2020-01-21 11:55 ` Dr. David Alan Gilbert
2020-01-28 9:52 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E26D634.6000905@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=dgilbert@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.