From: Cornelia Huck <cohuck@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
qemu-s390x@nongnu.org, David Hildenbrand <david@redhat.com>,
qemu-ppc@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Like Xu <like.xu@linux.intel.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-arm@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Alistair Francis <alistair.francis@wdc.com>,
kvm@vger.kernel.org (open list:Overall KVM CPUs)
Subject: Re: [PATCH v2 09/10] accel: Replace current_machine->accelerator by current_accel() wrapper
Date: Tue, 21 Jan 2020 15:03:58 +0100 [thread overview]
Message-ID: <20200121150358.63e5095b.cohuck@redhat.com> (raw)
In-Reply-To: <20200121110349.25842-10-philmd@redhat.com>
On Tue, 21 Jan 2020 12:03:48 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> We actually want to access the accelerator, not the machine, so
> use the current_accel() wrapper instead.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2:
> - Reworded description
> - Remove unused include in arm/kvm64
> ---
> accel/kvm/kvm-all.c | 4 ++--
> accel/tcg/tcg-all.c | 2 +-
> memory.c | 2 +-
> target/arm/kvm64.c | 5 ++---
> target/i386/kvm.c | 2 +-
> target/ppc/kvm.c | 2 +-
> vl.c | 2 +-
> 7 files changed, 9 insertions(+), 10 deletions(-)
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index b5799e62b4..45ede6b6d9 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -258,7 +258,7 @@ static void kvm_get_smmu_info(struct kvm_ppc_smmu_info *info, Error **errp)
>
> struct ppc_radix_page_info *kvm_get_radix_page_info(void)
> {
> - KVMState *s = KVM_STATE(current_machine->accelerator);
> + KVMState *s = KVM_STATE(current_accel());
> struct ppc_radix_page_info *radix_page_info;
> struct kvm_ppc_rmmu_info rmmu_info;
> int i;
What about the usage in kvmppc_svm_off()?
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair.francis@wdc.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Like Xu <like.xu@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"open list:Overall KVM CPUs" <kvm@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 09/10] accel: Replace current_machine->accelerator by current_accel() wrapper
Date: Tue, 21 Jan 2020 15:03:58 +0100 [thread overview]
Message-ID: <20200121150358.63e5095b.cohuck@redhat.com> (raw)
In-Reply-To: <20200121110349.25842-10-philmd@redhat.com>
On Tue, 21 Jan 2020 12:03:48 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> We actually want to access the accelerator, not the machine, so
> use the current_accel() wrapper instead.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2:
> - Reworded description
> - Remove unused include in arm/kvm64
> ---
> accel/kvm/kvm-all.c | 4 ++--
> accel/tcg/tcg-all.c | 2 +-
> memory.c | 2 +-
> target/arm/kvm64.c | 5 ++---
> target/i386/kvm.c | 2 +-
> target/ppc/kvm.c | 2 +-
> vl.c | 2 +-
> 7 files changed, 9 insertions(+), 10 deletions(-)
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index b5799e62b4..45ede6b6d9 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -258,7 +258,7 @@ static void kvm_get_smmu_info(struct kvm_ppc_smmu_info *info, Error **errp)
>
> struct ppc_radix_page_info *kvm_get_radix_page_info(void)
> {
> - KVMState *s = KVM_STATE(current_machine->accelerator);
> + KVMState *s = KVM_STATE(current_accel());
> struct ppc_radix_page_info *radix_page_info;
> struct kvm_ppc_rmmu_info rmmu_info;
> int i;
What about the usage in kvmppc_svm_off()?
next prev parent reply other threads:[~2020-01-21 14:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 11:03 [PATCH v2 00/10] Cleanups around the 'current_machine' global variable Philippe Mathieu-Daudé
2020-01-21 11:03 ` [PATCH v2 01/10] hw/ppc/spapr_rtas: Use local MachineState variable Philippe Mathieu-Daudé
2020-01-21 11:03 ` [PATCH v2 02/10] hw/ppc/spapr_rtas: Access MachineState via SpaprMachineState argument Philippe Mathieu-Daudé
2020-01-21 11:03 ` [PATCH v2 03/10] hw/ppc/spapr_rtas: Remove local variable Philippe Mathieu-Daudé
2020-01-22 3:27 ` David Gibson
2020-01-21 11:03 ` [PATCH v2 04/10] target/arm/kvm: Use CPUState::kvm_state in kvm_arm_pmu_supported() Philippe Mathieu-Daudé
2020-01-21 11:03 ` [PATCH v2 05/10] target/s390x: Remove duplicated ifdef macro Philippe Mathieu-Daudé
2020-01-21 13:52 ` Cornelia Huck
2020-01-21 16:45 ` Cornelia Huck
2020-01-21 11:03 ` [PATCH v2 06/10] qom/object: Display more helpful message when a parent is missing Philippe Mathieu-Daudé
2020-01-21 13:54 ` Cornelia Huck
2020-01-21 11:03 ` [PATCH v2 07/10] qdev: Abort if the root machine container " Philippe Mathieu-Daudé
2020-01-21 12:45 ` Markus Armbruster
2020-01-21 11:03 ` [PATCH v2 08/10] accel: Introduce the current_accel() wrapper Philippe Mathieu-Daudé
2020-01-21 13:56 ` Cornelia Huck
2020-01-21 11:03 ` [PATCH v2 09/10] accel: Replace current_machine->accelerator by " Philippe Mathieu-Daudé
2020-01-21 11:03 ` Philippe Mathieu-Daudé
2020-01-21 14:03 ` Cornelia Huck [this message]
2020-01-21 14:03 ` Cornelia Huck
2020-01-22 3:28 ` David Gibson
2020-01-22 3:28 ` David Gibson
2020-01-21 11:03 ` [PATCH v2 10/10] accel/tcg: Sanitize include path Philippe Mathieu-Daudé
2020-01-21 14:06 ` Cornelia Huck
2020-01-21 12:47 ` [PATCH v2 00/10] Cleanups around the 'current_machine' global variable Markus Armbruster
2020-01-21 12:49 ` Philippe Mathieu-Daudé
2020-01-21 16:27 ` Paolo Bonzini
2020-01-21 16:44 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121150358.63e5095b.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu@linux.intel.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.