All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Kukjin Kim <kgene@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] ARM: s3c24xx/rx1950: switch to atomic pwm API
Date: Tue, 21 Jan 2020 20:59:11 +0100	[thread overview]
Message-ID: <20200121195911.GA24380@kozik-lap> (raw)
In-Reply-To: <20200120193328.17007-1-uwe@kleine-koenig.org>

On Mon, Jan 20, 2020 at 08:33:28PM +0100, Uwe Kleine-König wrote:
> Stop using the legacy PWM API which only still exists because there are
> some users left.
> 
> Note this change make use of the fact that the value of struct
> pwm_state::duty_cycle doesn't matter for a disabled PWM and so its value
> can stay constant simplifying the code a bit.
> 
> A side effect of the conversion is that the pwm isn't stopped in
> rx1950_backlight_init() by the call to pwm_apply_args() just before
> reenabling it when rx1950_lcd_power(1) is called.
> 
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
>  arch/arm/mach-s3c24xx/mach-rx1950.c | 19 ++++++++++++-------

Thanks, applied.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] ARM: s3c24xx/rx1950: switch to atomic pwm API
Date: Tue, 21 Jan 2020 20:59:11 +0100	[thread overview]
Message-ID: <20200121195911.GA24380@kozik-lap> (raw)
In-Reply-To: <20200120193328.17007-1-uwe@kleine-koenig.org>

On Mon, Jan 20, 2020 at 08:33:28PM +0100, Uwe Kleine-König wrote:
> Stop using the legacy PWM API which only still exists because there are
> some users left.
> 
> Note this change make use of the fact that the value of struct
> pwm_state::duty_cycle doesn't matter for a disabled PWM and so its value
> can stay constant simplifying the code a bit.
> 
> A side effect of the conversion is that the pwm isn't stopped in
> rx1950_backlight_init() by the call to pwm_apply_args() just before
> reenabling it when rx1950_lcd_power(1) is called.
> 
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
>  arch/arm/mach-s3c24xx/mach-rx1950.c | 19 ++++++++++++-------

Thanks, applied.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-01-21 19:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 19:33 [PATCH] ARM: s3c24xx/rx1950: switch to atomic pwm API Uwe Kleine-König
2020-01-20 19:33 ` Uwe Kleine-König
2020-01-21  2:01 ` Vasily Khoruzhick
2020-01-21  2:01   ` Vasily Khoruzhick
2020-01-21 19:59 ` Krzysztof Kozlowski [this message]
2020-01-21 19:59   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200121195911.GA24380@kozik-lap \
    --to=krzk@kernel.org \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.