All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Cc: Rob Herring <robh@kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: display: add panel-timing.yaml
Date: Tue, 21 Jan 2020 21:05:08 +0100	[thread overview]
Message-ID: <20200121200508.GA12997@ravnborg.org> (raw)
In-Reply-To: <CAGgjyvGh8idpvijVcV0vA8R_iaB0mQMTk_=wWDSSKWX7hwdYPw@mail.gmail.com>

Hi Oleksandr.

> 
> There some typos:
> 
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> > new file mode 100644
> > index 000000000000..59891c7a58ee
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> > @@ -0,0 +1,253 @@
> ...
> > +description: |
> > +  There are different ways of describing the timing data data of a panel. The
> -----------------------------------------------------------------------^^^^^^^^^
> s/data data/data/
> 
> ...
> > +  vactive:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: |
> > +      Verical panel resolution in pixels
> ---------^^^^^^
> Vertical

Fixed in v2 - thanks.

> 
> Anyway, those are minor issues, so
> 
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: display: add panel-timing.yaml
Date: Tue, 21 Jan 2020 21:05:08 +0100	[thread overview]
Message-ID: <20200121200508.GA12997@ravnborg.org> (raw)
In-Reply-To: <CAGgjyvGh8idpvijVcV0vA8R_iaB0mQMTk_=wWDSSKWX7hwdYPw@mail.gmail.com>

Hi Oleksandr.

> 
> There some typos:
> 
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> > new file mode 100644
> > index 000000000000..59891c7a58ee
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> > @@ -0,0 +1,253 @@
> ...
> > +description: |
> > +  There are different ways of describing the timing data data of a panel. The
> -----------------------------------------------------------------------^^^^^^^^^
> s/data data/data/
> 
> ...
> > +  vactive:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: |
> > +      Verical panel resolution in pixels
> ---------^^^^^^
> Vertical

Fixed in v2 - thanks.

> 
> Anyway, those are minor issues, so
> 
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-01-21 20:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 20:06 [PATCH v1 0/3] dt-bindings: convert timing + panel-dpi to DT schema Sam Ravnborg
2020-01-20 20:06 ` Sam Ravnborg
2020-01-20 20:06 ` [PATCH v1 1/3] dt-bindings: display: add panel-timing.yaml Sam Ravnborg
2020-01-20 20:06   ` Sam Ravnborg
2020-01-20 20:48   ` Oleksandr Suvorov
2020-01-20 20:54     ` Oleksandr Suvorov
2020-01-21 20:05     ` Sam Ravnborg [this message]
2020-01-21 20:05       ` Sam Ravnborg
2020-01-25 18:29     ` Sam Ravnborg
2020-01-25 18:29       ` Sam Ravnborg
2020-01-21  7:29   ` Maxime Ripard
2020-01-21  7:29     ` Maxime Ripard
2020-01-25 18:26     ` Sam Ravnborg
2020-01-25 18:26       ` Sam Ravnborg
2020-01-21 14:35   ` Rob Herring
2020-01-21 14:35     ` Rob Herring
2020-01-20 20:06 ` [PATCH v1 2/3] dt-bindings: display: convert display-timings to DT schema Sam Ravnborg
2020-01-20 20:06   ` Sam Ravnborg
2020-01-20 20:06 ` [PATCH v1 3/3] dt-bindings: display: convert panel-dpi " Sam Ravnborg
2020-01-20 20:06   ` Sam Ravnborg
2020-01-21 14:50   ` Rob Herring
2020-01-21 14:50     ` Rob Herring
2020-01-25 19:39     ` Sam Ravnborg
2020-01-25 19:39       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200121200508.GA12997@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=oleksandr.suvorov@toradex.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.